TreeHouse\Model\Config\Validator\Constraints\ConfigValueValidator

Complexity

Total Complexity

10

Size/Duplication

Total Lines	76
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
B	validate()	0	34	6
A	validateFieldConfig()	0	14	3

<?php

namespace TreeHouse\Model\Config\Validator\Constraints;

use Symfony\Component\Validator\Constraint;
use Symfony\Component\Validator\ConstraintValidator;
use Symfony\Component\Validator\Exception\InvalidArgumentException;
use TreeHouse\Model\Config\Config;

class ConfigValueValidator extends ConstraintValidator
{
    /**
     * @var Config
     */
    protected $config;

    /**
     * @param Config $config
     */
    public function __construct(Config $config)
    {
        $this->config = $config;
    }

    /**
     * @param  integer|integer[] $value
     * @param  Constraint        $constraint
     *
     * @throws InvalidArgumentException
     */
    public function validate($value, Constraint $constraint)
    {
        /* @var $constraint ConfigValue */
        $name = $constraint->name;

        // config must exist
        if (!$this->config->hasFieldConfig($name)) {
            throw new InvalidArgumentException(sprintf('There is no config for the field "%s"', $name));
        }

        // value could be null
        if (null === $value) {
            return;
        }

        // check if field is multivalued
        $multiValued = $this->config->isMultiValued($name);

        // if it's multivalued, an array must be given
        if ($multiValued) {
            if (!is_array($value)) {
                $this->context->addViolation($constraint->arrayMessage);

                return;
            }

            // enforce array
            foreach ($value as $key) {
                $this->validateFieldConfig($constraint, $name, $key);
            }
        } else {
            $this->validateFieldConfig($constraint, $name, $value);

It seems like $value defined by parameter $value on line 31 can also be of type array<integer,integer>; however, TreeHouse\Model\Config\Validator\Constraints\ConfigValueValidator::validateFieldConfig() does only seem to accept integer, maybe add an additional type check?

        }
    }

    /**
     * @param ConfigValue $constraint
     * @param string      $name
     * @param integer     $value
     */
    protected function validateFieldConfig(ConfigValue $constraint, $name, $value)
    {
        // if it's single valued, value must be numeric
        if (!is_numeric($value)) {
            $this->context->addViolation($constraint->numericMessage, ['{{ value }}' => var_export($value, true)]);

            return;
        }

        // enforce array
        if (!$this->config->hasFieldConfigKey($name, intval($value))) {
            $this->context->addViolation($constraint->message, ['{{ value }}' => $value]);
        }
    }
}