FeedItemBagMapper::map() - Code Metrics - Inspection of "Set fallback time for modification date" - treehouselabs/io-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#37)

by Peter

created 2018-12-12 09:46 UTC

FeedItemBagMapper::map() A

↳ Parent: FeedItemBagMapper

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	1.0233

Importance

Changes

Metric	Value
dl	0
loc	8
ccs	5
cts	7
cp	0.7143
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1
crap	1.0233

<?php

namespace TreeHouse\IoBundle\Item\Modifier\Item\Mapper;

use Symfony\Component\HttpFoundation\ParameterBag;
use TreeHouse\Feeder\Modifier\Item\Mapper\MapperInterface;
use TreeHouse\IoBundle\Entity\Feed;
use TreeHouse\IoBundle\Import\Feed\FeedItemBag;

class FeedItemBagMapper implements MapperInterface
{
    /**
     * @var Feed
     */
    protected $feed;

    /**
     * @var \Closure
     */
    protected $originalIdCallback;

    /**
     * @var \Closure
     */
    protected $originalUrlCallback;

    /**
     * @var \Closure
     */
    protected $modificationDateCallback;

    /**
     * @param Feed     $feed
     * @param callable $originalIdCallback
     * @param callable $originalUrlCallback
     * @param callable $modificationDateCallback
     */
    public function __construct(Feed $feed, $originalIdCallback, $originalUrlCallback, $modificationDateCallback
    ) {
        $this->feed = $feed;
        $this->originalIdCallback = $originalIdCallback;

        $this->originalUrlCallback = $originalUrlCallback;

        $this->modificationDateCallback = $modificationDateCallback;

    }

    /**
     * {@inheritdoc}
     */
    public function map(ParameterBag $item)
    {
        $bag = new FeedItemBag($this->feed, call_user_func($this->originalIdCallback, $item), $item->all());
        $bag->setOriginalUrl(call_user_func($this->originalUrlCallback, $item));
        $bag->setDatetimeModified(call_user_func($this->modificationDateCallback, $item));

        return $bag;
    }
}


1		<?php
2
3		namespace TreeHouse\IoBundle\Item\Modifier\Item\Mapper;
4
5		use Symfony\Component\HttpFoundation\ParameterBag;
6		use TreeHouse\Feeder\Modifier\Item\Mapper\MapperInterface;
7		use TreeHouse\IoBundle\Entity\Feed;
8		use TreeHouse\IoBundle\Import\Feed\FeedItemBag;
9
10		class FeedItemBagMapper implements MapperInterface
11		{
12		/**
13		* @var Feed
14		*/
15		protected $feed;
16
17		/**
18		* @var \Closure
19		*/
20		protected $originalIdCallback;
21
22		/**
23		* @var \Closure
24		*/
25		protected $originalUrlCallback;
26
27		/**
28		* @var \Closure
29		*/
30		protected $modificationDateCallback;
31
32		/**
33		* @param Feed $feed
34		* @param callable $originalIdCallback
35		* @param callable $originalUrlCallback
36		* @param callable $modificationDateCallback
37		*/
38	2	public function __construct(Feed $feed, $originalIdCallback, $originalUrlCallback, $modificationDateCallback
39		) {
40	2	$this->feed = $feed;
41	2	$this->originalIdCallback = $originalIdCallback;
		0 ignored issues – show Documentation Bug introduced 2016-01-05 18:41 UTC by Report Bug Copy Issue Report It seems like `$originalIdCallback` of type `callable` is incompatible with the declared type `object<Closure>` of property `$originalIdCallback`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
42	2	$this->originalUrlCallback = $originalUrlCallback;
		0 ignored issues – show Documentation Bug introduced 2016-01-05 18:41 UTC by Report Bug Copy Issue Report It seems like `$originalUrlCallback` of type `callable` is incompatible with the declared type `object<Closure>` of property `$originalUrlCallback`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
43	2	$this->modificationDateCallback = $modificationDateCallback;
		0 ignored issues – show Documentation Bug introduced 2016-01-05 18:41 UTC by Report Bug Copy Issue Report It seems like `$modificationDateCallback` of type `callable` is incompatible with the declared type `object<Closure>` of property `$modificationDateCallback`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
44	2	}
45
46		/**
47		* {@inheritdoc}
48		*/
49	2	public function map(ParameterBag $item)
50		{
51	2	$bag = new FeedItemBag($this->feed, call_user_func($this->originalIdCallback, $item), $item->all());
52	2	$bag->setOriginalUrl(call_user_func($this->originalUrlCallback, $item));
53	2	$bag->setDatetimeModified(call_user_func($this->modificationDateCallback, $item));
54
55	2	return $bag;
56		}
57		}
58

treehouselabs / io-bundle

Pull Request — master (#37)

FeedItemBagMapper::map() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like