ImportLogViewCommand::execute() - Code Metrics - treehouselabs/io-bundle - Measure and Improve Code Quality continuously with Scrutinizer

ImportLogViewCommand::execute() B
last analyzed 2020-05-04 12:22 UTC

↳ Parent: ImportLogViewCommand

Complexity

Conditions	8
Paths	14

Size

Total Lines

Duplication

Lines	5
Ratio	10.87 %

Code Coverage

Tests	0
CRAP Score	72

Importance

Changes

Metric	Value
dl	5
loc	46
ccs	0
cts	38
cp	0
rs	7.9337
c	0
b	0
f	0
cc	8
nc	14
nop	2
crap	72

<?php

namespace TreeHouse\IoBundle\Command;

use Doctrine\Common\Persistence\ManagerRegistry;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use TreeHouse\IoBundle\Entity\Import;
use TreeHouse\IoBundle\Entity\ImportRepository;
use TreeHouse\IoBundle\Import\Log\ItemLoggerInterface;

class ImportLogViewCommand extends Command
{
    /**
     * @var ManagerRegistry
     */
    protected $doctrine;

    /**
     * @var ItemLoggerInterface
     */
    protected $itemLogger;

    /**
     * @param ManagerRegistry     $doctrine
     * @param ItemLoggerInterface $itemLogger
     */
    public function __construct(ManagerRegistry $doctrine, ItemLoggerInterface $itemLogger)
    {
        $this->doctrine = $doctrine;
        $this->itemLogger = $itemLogger;

        parent::__construct();
    }

    /**
     * @inheritdoc
     */
    protected function configure()
    {
        $this->setName('io:import:log:view');
        $this->addArgument('import', InputArgument::REQUIRED, 'The id of the import');
        $this->setDescription('View an import log');
    }

    /**
     * @inheritdoc
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        if (null === $import = $this->findImportById($input->getArgument('import'))) {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $output->writeln(sprintf('<error>Import %d does not exist</error>', $input->getArgument('import')));

            return 1;
        }

        $items = 0;
        $success = 0;
        $failed = 0;
        $skipped = 0;

        foreach ($this->itemLogger->getImportedItems($import) as $item) {
            $output->writeln(sprintf('<info>%s</info>:', $item['item']));

            ++$items;

            foreach ($item as $key => $value) {
                if ($key === 'item') {
                    continue;
                }

                $output->writeln(sprintf('  <info>%s</info>: <comment>%s</comment>', $key, $value));
            }

            switch ($item['result']) {
                case 'success':
                    $success++;
                    break;
                case 'failed':
                    $failed++;
                    break;
                case 'skipped':
                    $skipped++;
                    break;
            }
        }
        $output->writeln('');
        $output->writeln(sprintf('Imported <info>%s</info> items', $items));
        $output->writeln(sprintf('- succes:  <info>%s</info> (<info>%.2f%%</info>)', $success, $success / $items * 100));
        $output->writeln(sprintf('- failed:  <info>%s</info> (<info>%.2f%%</info>)', $failed, $failed / $items * 100));
        $output->writeln(sprintf('- skipped: <info>%s</info> (<info>%.2f%%</info>)', $skipped, $skipped / $items * 100));

        return 0;
    }

    /**
     * @param int $id
     *
     * @return Import
     */
    protected function findImportById($id)
    {
        return $this->getRepository()->find($id);
    }

    /**
     * @return ImportRepository
     */
    protected function getRepository()
    {
        return $this->doctrine->getRepository('TreeHouseIoBundle:Import');
    }
}


1		<?php
2
3		namespace TreeHouse\IoBundle\Command;
4
5		use Doctrine\Common\Persistence\ManagerRegistry;
6		use Symfony\Component\Console\Command\Command;
7		use Symfony\Component\Console\Input\InputArgument;
8		use Symfony\Component\Console\Input\InputInterface;
9		use Symfony\Component\Console\Output\OutputInterface;
10		use TreeHouse\IoBundle\Entity\Import;
11		use TreeHouse\IoBundle\Entity\ImportRepository;
12		use TreeHouse\IoBundle\Import\Log\ItemLoggerInterface;
13
14		class ImportLogViewCommand extends Command
15		{
16		/**
17		* @var ManagerRegistry
18		*/
19		protected $doctrine;
20
21		/**
22		* @var ItemLoggerInterface
23		*/
24		protected $itemLogger;
25
26		/**
27		* @param ManagerRegistry $doctrine
28		* @param ItemLoggerInterface $itemLogger
29		*/
30		public function __construct(ManagerRegistry $doctrine, ItemLoggerInterface $itemLogger)
31		{
32		$this->doctrine = $doctrine;
33		$this->itemLogger = $itemLogger;
34
35		parent::__construct();
36		}
37
38		/**
39		* @inheritdoc
40		*/
41		protected function configure()
42		{
43		$this->setName('io:import:log:view');
44		$this->addArgument('import', InputArgument::REQUIRED, 'The id of the import');
45		$this->setDescription('View an import log');
46		}
47
48		/**
49		* @inheritdoc
50		*/
51		protected function execute(InputInterface $input, OutputInterface $output)
52		{
53	View Code Duplication	if (null === $import = $this->findImportById($input->getArgument('import'))) {
		0 ignored issues – show Duplication introduced 2016-01-05 18:41 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Documentation introduced 2018-12-12 10:10 UTC by Report Bug Copy Issue Report `$input->getArgument('import')` is of type `string\|array<integer,string>\|null`, but the function expects a `integer`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
54		$output->writeln(sprintf('<error>Import %d does not exist</error>', $input->getArgument('import')));
55
56		return 1;
57		}
58
59		$items = 0;
60		$success = 0;
61		$failed = 0;
62		$skipped = 0;
63
64		foreach ($this->itemLogger->getImportedItems($import) as $item) {
65		$output->writeln(sprintf('<info>%s</info>:', $item['item']));
66
67		++$items;
68
69		foreach ($item as $key => $value) {
70		if ($key === 'item') {
71		continue;
72		}
73
74		$output->writeln(sprintf(' <info>%s</info>: <comment>%s</comment>', $key, $value));
75		}
76
77		switch ($item['result']) {
78		case 'success':
79		$success++;
80		break;
81		case 'failed':
82		$failed++;
83		break;
84		case 'skipped':
85		$skipped++;
86		break;
87		}
88		}
89		$output->writeln('');
90		$output->writeln(sprintf('Imported <info>%s</info> items', $items));
91		$output->writeln(sprintf('- succes: <info>%s</info> (<info>%.2f%%</info>)', $success, $success / $items * 100));
92		$output->writeln(sprintf('- failed: <info>%s</info> (<info>%.2f%%</info>)', $failed, $failed / $items * 100));
93		$output->writeln(sprintf('- skipped: <info>%s</info> (<info>%.2f%%</info>)', $skipped, $skipped / $items * 100));
94
95		return 0;
96		}
97
98		/**
99		* @param int $id
100		*
101		* @return Import
102		*/
103		protected function findImportById($id)
104		{
105		return $this->getRepository()->find($id);
106		}
107
108		/**
109		* @return ImportRepository
110		*/
111		protected function getRepository()
112		{
113		return $this->doctrine->getRepository('TreeHouseIoBundle:Import');
114		}
115		}
116

treehouselabs / io-bundle

ImportLogViewCommand::execute() B last analyzed 2020-05-04 12:22 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

ImportLogViewCommand::execute() B
last analyzed 2020-05-04 12:22 UTC