TreeHouse\IoBundle\Item\Modifier\Item\Filter\ModifiedItemFilter

Complexity

Total Complexity

8

Size/Duplication

Total Lines	56
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	5

Test Coverage

Coverage

81.25%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	4	4	1
A	findSource()	12	12	3
A	filter()	17	17	4

<?php

namespace TreeHouse\IoBundle\Item\Modifier\Item\Filter;

use Symfony\Component\HttpFoundation\ParameterBag;
use TreeHouse\Feeder\Exception\FilterException;
use TreeHouse\Feeder\Modifier\Item\Filter\FilterInterface;
use TreeHouse\IoBundle\Import\Feed\FeedItemBag;
use TreeHouse\IoBundle\Item\ItemBag;
use TreeHouse\IoBundle\Model\SourceInterface;
use TreeHouse\IoBundle\Scrape\ScrapedItemBag;
use TreeHouse\IoBundle\Source\Manager\CachedSourceManager;

/**
 * Filters out items in the feed that have a modification date
 * before its corresponding source's modification date.
 */
class ModifiedItemFilter implements FilterInterface

This class seems to be duplicated in your project.

{
    /**
     * @var CachedSourceManager
     */
    protected $sourceManager;

    /**
     * @param CachedSourceManager $sourceManager
     */
    public function __construct(CachedSourceManager $sourceManager)
    {
        $this->sourceManager = $sourceManager;
    }

    /**
     * @inheritdoc
     *
     * @param ItemBag $item
     */
    public function filter(ParameterBag $item)
    {
        /** @var FeedItemBag $item */
        // if source does not exist yet, by all means process it
        if (null === $source = $this->findSource($item)) {

$item of type object<Symfony\Component\HttpFoundation\ParameterBag> is not a sub-type of object<TreeHouse\IoBundle\Item\ItemBag>. It seems like you assume a child class of the class Symfony\Component\HttpFoundation\ParameterBag to be always present.

            return;
        }

        // first try modification date
        if (null !== $mutationDate = $item->getDatetimeModified()) {

It seems like you code against a specific sub-type and not the parent class Symfony\Component\HttpFoundation\ParameterBag as the method getDatetimeModified() does only exist in the following sub-classes of Symfony\Component\HttpFoundation\ParameterBag: TreeHouse\IoBundle\Import\Feed\FeedItemBag, TreeHouse\IoBundle\Item\ItemBag, TreeHouse\IoBundle\Scrape\ScrapedItemBag. Maybe you want to instanceof check for one of these explicitly?

            if ($source->getDatetimeImported() > $mutationDate) {
                throw new FilterException('Item is not modified');
            }
        }

        // item is modified or we don't have enough information to determine that, either way continue.
    }

    /**
     * @param ItemBag $item
     *
     * @return null|SourceInterface
     */
    protected function findSource(ItemBag $item)
    {
        if ($item instanceof FeedItemBag) {
            return $this->sourceManager->findSourceByFeed($item->getFeed(), $item->getOriginalId());
        }

        if ($item instanceof ScrapedItemBag) {
            return $this->sourceManager->findSourceByScraper($item->getScraper(), $item->getOriginalId());
        }

        return null;
    }
}