Treestoneit\ShoppingCart\Concerns\CalculatesTotals

Complexity

Total Complexity

12

Size/Duplication

Total Lines	97
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	content()	0	4	1
A	count()	0	4	1
A	subtotal()	0	10	2
A	tax()	0	8	2
A	clearCached()	0	5	1
A	getTaxAmountForItem()	0	16	5

<?php

namespace Treestoneit\ShoppingCart\Concerns;

use Closure;
use Illuminate\Support\Facades\Config;
use Treestoneit\ShoppingCart\Models\CartItem;
use Treestoneit\ShoppingCart\Models\CartItemCollection;
use Treestoneit\ShoppingCart\Taxable;

trait CalculatesTotals
{
    /**
     * @var float
     */
    protected $subtotal = 0.0;

    /**
     * @var float
     */
    protected $tax = 0.0;

    /**
     * Get the cart contents.
     *
     * @return \Treestoneit\ShoppingCart\Models\CartItemCollection
     */
    public function content(): CartItemCollection
    {
        return $this->items();

It seems like items() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * Get the number of items in the cart.
     *
     * @return int
     */
    public function count(): int
    {
        return $this->items()->sum('quantity');

It seems like items() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * Get the subtotal of items in the cart.
     *
     * @return int|float
     */
    public function subtotal(): float
    {
        if (! $this->subtotal) {
            $this->subtotal = $this->items()->sumRounded(function (CartItem $item) {

It seems like items() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                return $item->subtotal;
            });
        }

        return $this->subtotal;
    }

    /**
     * Get the tax for items in the cart.
     *
     * @param  int|float|null  $rate
     * @return float
     */
    public function tax($rate = null): float
    {
        if (! $this->tax) {
            $this->tax = $this->items()->sumRounded($this->getTaxAmountForItem($rate));

It seems like items() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }

        return $this->tax;
    }

    /**
     * Clear the cached totals.
     *
     * @return void
     */
    public function clearCached(): void
    {
        $this->subtotal = 0.0;
        $this->tax = 0.0;
    }

    /**
     * Figure out how to calculate tax for the cart items.
     *
     * @param  int|float|null  $rate
     * @return \Closure
     */
    protected function getTaxAmountForItem($rate = null): Closure
    {
        if (! $rate && Config::get('shopping-cart.tax.mode') == 'flat') {
            $rate = Config::get('shopping-cart.tax.rate');
        }

        return function (CartItem $item) use ($rate) {
            if (! $rate) {
                $rate = $item->buyable instanceof Taxable

Consider using a different name than the imported variable $rate, or did you forget to import by reference?

                    ? $item->buyable->getTaxRate()
                    : 0;
            }

            return round($item->price * $item->quantity * ($rate / 100), 2);
        };
    }
}