UserGroupMapper::populateUserGroupUpdateStruct() - Code Metrics - Inspection of "enhancement #75 Cleans up the mappers and introduc..." - transfer-framework/ezplatform - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 1.0 ( fb098d...df18cb )

by Valentin

created 2016-06-05 10:57 UTC

UserGroupMapper::populateUserGroupUpdateStruct() A

↳ Parent: UserGroupMapper

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	10
ccs	8
cts	8
cp	1
rs	9.4285
cc	2
eloc	6
nc	2
nop	1
crap	2

<?php

/**
 * This file is part of Transfer.
 *
 * For the full copyright and license information, please view the LICENSE file located
 * in the root directory.
 */
namespace Transfer\EzPlatform\Repository\Values\Mapper;

use eZ\Publish\API\Repository\Values\Content\ContentMetadataUpdateStruct;
use eZ\Publish\API\Repository\Values\User\UserGroup;
use eZ\Publish\API\Repository\Values\User\UserGroupCreateStruct;
use eZ\Publish\API\Repository\Values\User\UserGroupUpdateStruct;
use Transfer\EzPlatform\Repository\Values\UserGroupObject;

/**
 * Usergroup mapper.
 *
 * @author Harald Tollefsen <[email protected]>
 */
class UserGroupMapper
{
    /**
     * @var UserGroupObject
     */
    public $userGroupObject;

    /**
     * @param UserGroupObject $userGroupObject
     */
    public function __construct(UserGroupObject $userGroupObject)
    {
        $this->userGroupObject = $userGroupObject;
    }

    /**
     * @param UserGroup $userGroup
     */
    public function userGroupToObject(UserGroup $userGroup)
    {
        $this->userGroupObject->data['parent_id'] = $userGroup->parentId;

        $this->userGroupObject->data['fields'] = [];
        foreach ($userGroup->getFields() as $field) {
            $this->userGroupObject->data['fields'][$field->fieldDefIdentifier] = $field->value->text;
        }

        $this->userGroupObject->setProperty('id', $userGroup->contentInfo->id);
        $this->userGroupObject->setProperty('content_info', $userGroup->contentInfo);
        $this->userGroupObject->setProperty('version_info', $userGroup->versionInfo);
    }

    /**
     * @param UserGroupCreateStruct $createStruct
     */
    public function mapObjectToCreateStruct(UserGroupCreateStruct $createStruct)

    {
        // Name collection (ez => transfer)
        $keys = array(
            'remoteId' => 'remote_id',
        );

        $this->arrayToStruct($createStruct, $keys);

        $this->assignStructFieldValues($createStruct);

        $this->callStruct($createStruct);
    }

    /**
     * @param UserGroupUpdateStruct $updateStruct
     */
    public function mapObjectToUpdateStruct(UserGroupUpdateStruct $updateStruct)

    {
        // Name collection (ez => transfer)
        $keys = array(
            'remoteId' => 'remote_id',
        );

        $this->arrayToStruct($updateStruct, $keys);

        $this->assignStructFieldValues($updateStruct);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $this->callStruct($updateStruct);
    }

    /**
     * @param UserGroupCreateStruct $struct Struct to assign values to
     */
    private function assignStructFieldValues($struct)

    {
        foreach ($this->userGroupObject->data['fields'] as $key => $value) {
            if ($struct instanceof UserGroupUpdateStruct) {
                $struct->contentUpdateStruct->setField($key, $value);
            } else {
                $struct->setField($key, $value);
            }
        }
    }

    /**
     * @param UserGroupCreateStruct|UserGroupUpdateStruct $struct
     * @param array                                       $keys
     */
    private function arrayToStruct($struct, $keys)
    {
        foreach ($keys as $ezKey => $transferKey) {
            if (isset($this->userGroupObject->data[$transferKey])) {
                if ($struct instanceof UserGroupUpdateStruct) {
                    if (!$struct->contentMetadataUpdateStruct) {
                        $struct->contentMetadataUpdateStruct = new ContentMetadataUpdateStruct();
                    }
                    $struct->contentMetadataUpdateStruct->$ezKey = $this->userGroupObject->data[$transferKey];
                } else {
                    $struct->$ezKey = $this->userGroupObject->data[$transferKey];
                }
            }
        }
    }

    /**
     * @param UserGroupCreateStruct|UserGroupUpdateStruct $struct
     */
    private function callStruct($struct)
    {
        if ($this->userGroupObject->getProperty('struct_callback')) {
            $callback = $this->userGroupObject->getProperty('struct_callback');
            $callback($struct);
        }
    }
}


1			<?php
2
3			/**
4			* This file is part of Transfer.
5			*
6			* For the full copyright and license information, please view the LICENSE file located
7			* in the root directory.
8			*/
9			namespace Transfer\EzPlatform\Repository\Values\Mapper;
10
11			use eZ\Publish\API\Repository\Values\Content\ContentMetadataUpdateStruct;
12			use eZ\Publish\API\Repository\Values\User\UserGroup;
13			use eZ\Publish\API\Repository\Values\User\UserGroupCreateStruct;
14			use eZ\Publish\API\Repository\Values\User\UserGroupUpdateStruct;
15			use Transfer\EzPlatform\Repository\Values\UserGroupObject;
16
17			/**
18			* Usergroup mapper.
19			*
20			* @author Harald Tollefsen <[email protected]>
21			*/
22			class UserGroupMapper
23			{
24			/**
25			* @var UserGroupObject
26			*/
27			public $userGroupObject;
28
29			/**
30			* @param UserGroupObject $userGroupObject
31			*/
32	18		public function __construct(UserGroupObject $userGroupObject)
33			{
34	18		$this->userGroupObject = $userGroupObject;
35	18		}
36
37			/**
38			* @param UserGroup $userGroup
39			*/
40	18		public function userGroupToObject(UserGroup $userGroup)
41			{
42	18		$this->userGroupObject->data['parent_id'] = $userGroup->parentId;
43
44	18		$this->userGroupObject->data['fields'] = [];
45	18		foreach ($userGroup->getFields() as $field) {
46	18		$this->userGroupObject->data['fields'][$field->fieldDefIdentifier] = $field->value->text;
47	18		}
48
49	18		$this->userGroupObject->setProperty('id', $userGroup->contentInfo->id);
50	18		$this->userGroupObject->setProperty('content_info', $userGroup->contentInfo);
51	18		$this->userGroupObject->setProperty('version_info', $userGroup->versionInfo);
52	18		}
53
54			/**
55			* @param UserGroupCreateStruct $createStruct
56			*/
57	18	View Code Duplication	public function mapObjectToCreateStruct(UserGroupCreateStruct $createStruct)
			0 ignored issues – show Duplication introduced 2016-06-05 01:20 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
58			{
59			// Name collection (ez => transfer)
60			$keys = array(
61	18		'remoteId' => 'remote_id',
62	18		);
63
64	18		$this->arrayToStruct($createStruct, $keys);
65
66	18		$this->assignStructFieldValues($createStruct);
67
68	18		$this->callStruct($createStruct);
69	18		}
70
71			/**
72			* @param UserGroupUpdateStruct $updateStruct
73			*/
74	3	View Code Duplication	public function mapObjectToUpdateStruct(UserGroupUpdateStruct $updateStruct)
			0 ignored issues – show Duplication introduced 2016-06-05 01:20 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
75			{
76			// Name collection (ez => transfer)
77			$keys = array(
78	3		'remoteId' => 'remote_id',
79	3		);
80
81	3		$this->arrayToStruct($updateStruct, $keys);
82
83	3		$this->assignStructFieldValues($updateStruct);
			0 ignored issues – show Documentation introduced 2016-06-05 01:20 UTC by Report Bug Copy Issue Report `$updateStruct` is of type `object<eZ\Publish\API\Re...\UserGroupUpdateStruct>`, but the function expects a `object<eZ\Publish\API\Re...\UserGroupCreateStruct>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
84
85	3		$this->callStruct($updateStruct);
86	3		}
87
88			/**
89			* @param UserGroupCreateStruct $struct Struct to assign values to
90			*/
91	18	View Code Duplication	private function assignStructFieldValues($struct)
			0 ignored issues – show Duplication introduced 2016-06-05 01:20 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
92			{
93	18		foreach ($this->userGroupObject->data['fields'] as $key => $value) {
94	18		if ($struct instanceof UserGroupUpdateStruct) {
95	3		$struct->contentUpdateStruct->setField($key, $value);
96	3		} else {
97	18		$struct->setField($key, $value);
98			}
99	18		}
100	18		}
101
102			/**
103			* @param UserGroupCreateStruct\|UserGroupUpdateStruct $struct
104			* @param array $keys
105			*/
106	18		private function arrayToStruct($struct, $keys)
107			{
108	18		foreach ($keys as $ezKey => $transferKey) {
109	18		if (isset($this->userGroupObject->data[$transferKey])) {
110	3		if ($struct instanceof UserGroupUpdateStruct) {
111	2		if (!$struct->contentMetadataUpdateStruct) {
112	2		$struct->contentMetadataUpdateStruct = new ContentMetadataUpdateStruct();
113	2		}
114	2		$struct->contentMetadataUpdateStruct->$ezKey = $this->userGroupObject->data[$transferKey];
115	2		} else {
116	3		$struct->$ezKey = $this->userGroupObject->data[$transferKey];
117			}
118	3		}
119	18		}
120	18		}
121
122			/**
123			* @param UserGroupCreateStruct\|UserGroupUpdateStruct $struct
124			*/
125	18		private function callStruct($struct)
126			{
127	18		if ($this->userGroupObject->getProperty('struct_callback')) {
128	1		$callback = $this->userGroupObject->getProperty('struct_callback');
129	1		$callback($struct);
130	1		}
131	18		}
132			}
133

transfer-framework / ezplatform

Push — 1.0 ( fb098d...df18cb )

UserGroupMapper::populateUserGroupUpdateStruct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like