TraderInteractive\SolveMedia\ServiceTest

Complexity

Total Complexity

15

Size/Duplication

Total Lines	187
Duplicated Lines	13.37 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes

0

15 Methods

Rating	Name	Duplication	Size	Complexity
A	getHtmlWithArguments()	0	7	1
A	setUp()	0	4	1
A	constructWithInvalidArguments()	0	4	1
A	constructWithInvalidArgumentsData()	0	13	1
A	constructWithValidArguments()	0	5	1
A	getHtmlDefault()	0	11	1
A	checkAnswerNoRemoteIp()	0	5	1
A	checkAnswerNoRemoteIpData()	0	7	1
A	checkAnswerEmptyArguments()	0	9	1
A	checkAnswerEmptyArgumentsData()	0	13	1
A	checkAnswerErrorResponse()	13	13	1
A	checkAnswerErrorResponseData()	0	10	1
A	checkAnswerValidResponse()	12	12	1
A	checkAnswerValidResponseData()	0	7	1
A	getSignupUrl()	0	5	1

<?php
namespace TraderInteractive\SolveMedia;

use Guzzle\Http\Client as GuzzleClient;
use Guzzle\Http\Message\Response as GuzzleResponse;
use PHPUnit\Framework\TestCase;

/**
 * @coversDefaultClass \TraderInteractive\SolveMedia\Service
 */
class ServiceTest extends TestCase
{
    private $_realGuzzleClient;

    public function setUp()
    {
        $this->_realGuzzleClient = new GuzzleClient();
    }

    /**
     * @test
     * @dataProvider constructWithInvalidArgumentsData
     * @expectedException Exception
     * @covers ::__construct
     */
    public function constructWithInvalidArguments($pubkey, $privkey, $hashkey)
    {
        new Service($this->_realGuzzleClient, $pubkey, $privkey, $hashkey);
    }

    public function constructWithInvalidArgumentsData()
    {
        return [
            [$this->_realGuzzleClient, null, null, null],
            [$this->_realGuzzleClient, '', null, null],
            [$this->_realGuzzleClient, 0, null, null],
            [$this->_realGuzzleClient, false, null, null],
            [$this->_realGuzzleClient, 'test', null, null],
            [$this->_realGuzzleClient, 'test', '', null],
            [$this->_realGuzzleClient, 'test', 0, null],
            [$this->_realGuzzleClient, 'test', false, null],
        ];
    }

    /**
     * @test
     * @covers ::__construct
     */
    public function constructWithValidArguments()
    {
        $this->assertNotNull(new Service($this->_realGuzzleClient, 'test', 'test'));
        $this->assertNotNull(new Service($this->_realGuzzleClient, 'test', 'test', 'test'));
    }

    /**
     * @test
     * @covers ::getHtml
     */
    public function getHtmlDefault()
    {
        $client = new GuzzleClient();

$client is not used, you could remove the assignment.

        $pubkey = 'MyTestPubKeyStringToTestFor';
        $service = new Service($this->_realGuzzleClient, $pubkey, 'notest');

        $html = $service->getHtml();
        $this->assertRegExp("/k={$pubkey}/", $html);
        $this->assertNotRegExp('/;error=1/', $html);
        $this->assertRegExp('/' . preg_quote(Service::ADCOPY_API_SERVER, '/') . '/', $html);
    }

    /**
     * @test
     * @covers ::getHtml
     */
    public function getHtmlWithArguments()
    {
        $service = new Service($this->_realGuzzleClient, 'notest', 'notest');
        $html = $service->getHtml('test', true);
        $this->assertRegExp('/;error=1/', $html);
        $this->assertRegExp('/' . preg_quote(Service::ADCOPY_API_SECURE_SERVER, '/') . '/', $html);
    }

    /**
     * @test
     * @dataProvider checkAnswerNoRemoteIpData
     * @expectedException Exception
     * @covers ::checkAnswer
     */
    public function checkAnswerNoRemoteIp($remoteIp)
    {
        $service = new Service($this->_realGuzzleClient, 'notest', 'notest');
        $service->checkAnswer($remoteIp, null, null);
    }

    public function checkAnswerNoRemoteIpData()
    {
        return [
            [null],
            [''],
        ];
    }

    /**
     * @test
     * @dataProvider checkAnswerEmptyArgumentsData
     * @covers ::checkAnswer
     */
    public function checkAnswerEmptyArguments($challenge, $response)
    {
        $service = new Service($this->_realGuzzleClient, 'notest', 'notest');
        $response = $service->checkAnswer('notest', $challenge, $response);

        $this->assertInstanceOf('\TraderInteractive\SolveMedia\Response', $response);
        $this->assertFalse($response->valid());
        $this->assertSame('incorrect-solution', $response->getMessage());
    }

    public function checkAnswerEmptyArgumentsData()
    {
        return [
            [null, null],
            ['', null],
            [0, null],
            [false, null],
            ['test', null],
            ['test', ''],
            ['test', 0],
            ['test', false],
        ];
    }

    /**
     * @test
     * @dataProvider checkAnswerErrorResponseData
     * @covers ::checkAnswer
     */
    public function checkAnswerErrorResponse($hashKey, GuzzleResponse $guzzleResponse, $message)

This method seems to be duplicated in your project.

    {
        $guzzleRequest = $this->getMockForAbstractClass('\Guzzle\Http\Message\RequestInterface');
        $guzzleRequest->expects($this->once())->method('send')->will($this->returnValue($guzzleResponse));

        $guzzleClient = $this->getMockForAbstractClass('\Guzzle\Http\ClientInterface');
        $guzzleClient->expects($this->once())->method('post')->will($this->returnValue($guzzleRequest));

        $service = new Service($guzzleClient, 'notest', 'notest', $hashKey);

$guzzleClient is of type object<PHPUnit\Framework\MockObject\MockObject>, but the function expects a object<Guzzle\Http\ClientInterface>.

        $response = $service->checkAnswer('notest', 'foo', 'bar');
        $this->assertFalse($response->valid());
        $this->assertSame($message, $response->getMessage());
    }

    public function checkAnswerErrorResponseData()
    {
        return [
            ['', new GuzzleResponse(400), 'Bad Request'],
            ['', new GuzzleResponse(200, [], "false\nfailure-message"), 'failure-message'],
            ['hashKey', new GuzzleResponse(200, [], "true\nfailure-message\nnot-the-right-hash"), 'hash-fail'],
            ['hashKey', new GuzzleResponse(200, [], "false\nfailure-message\nnot-the-right-hash"), 'hash-fail'],
            ['hashKey', new GuzzleResponse(200, [], "false\nfailure-message\n" . sha1('falsefoohashKey')), 'failure-message'],
        ];
    }

    /**
     * @test
     * @dataProvider checkAnswerValidResponseData
     * @covers ::checkAnswer
     */
    public function checkAnswerValidResponse($hashKey, GuzzleResponse $guzzleResponse)

This method seems to be duplicated in your project.

    {
        $guzzleRequest = $this->getMockForAbstractClass('\Guzzle\Http\Message\RequestInterface');
        $guzzleRequest->expects($this->once())->method('send')->will($this->returnValue($guzzleResponse));

        $guzzleClient = $this->getMockForAbstractClass('\Guzzle\Http\ClientInterface');
        $guzzleClient->expects($this->once())->method('post')->will($this->returnValue($guzzleRequest));

        $service = new Service($guzzleClient, 'notest', 'notest', $hashKey);

$guzzleClient is of type object<PHPUnit\Framework\MockObject\MockObject>, but the function expects a object<Guzzle\Http\ClientInterface>.

        $response = $service->checkAnswer('notest', 'foo', 'bar');
        $this->assertTrue($response->valid());
    }

    public function checkAnswerValidResponseData()
    {
        return [
            ['', new GuzzleResponse(200, [], 'true')],
            ['hashKey', new GuzzleResponse(200, [], "true\n\n" . sha1('truefoohashKey'))],
        ];
    }

    /**
     * @test
     * @covers ::getSignupUrl
     */
    public function getSignupUrl()
    {
        $service = new Service($this->_realGuzzleClient, 'notest', 'notest');
        $this->assertNotEmpty($service->getSignupUrl());
    }
}