Queue::get() - Code Metrics - Inspection of "[WIP] Version 3" - traderinteractive/mongo-queue-php - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#60)

by Chad

created 2018-02-28 18:22 UTC

Queue::get() C

↳ Parent: Project

Complexity

Conditions	14
Paths	101

Size

Total Lines	70
Code Lines	32

Duplication

Lines	7
Ratio	10 %

Importance

Changes

Metric	Value
dl	7
loc	70
rs	5.5937
c	0
b	0
f	0
cc	14
eloc	32
nc	101
nop	4

How to fix Long Method Complexity

<?php
/**
 * Defines the TraderInteractive\Mongo\Queue class.
 */

namespace TraderInteractive\Mongo;

/**
 * Implementation of mongo db collection as priority queue.
 *
 * Tied priorities are ordered by time. So you may use a single priority for normal queuing (default args exist for
 * this purpose).  Using a random priority achieves random get()
 */
final class Queue extends AbstractQueue implements QueueInterface
{
    /**
     * Construct queue.
     *
     * @param \MongoDB\Collection|string $collectionOrUrl A MongoCollection instance or the mongo connection url.
     * @param string $db the mongo db name
     * @param string $collection the collection name to use for the queue
     *
     * @throws \InvalidArgumentException $collectionOrUrl, $db or $collection was not a string
     */
    public function __construct($collectionOrUrl, string $db = null, string $collection = null)
    {
        if ($collectionOrUrl instanceof \MongoDB\Collection) {
            $this->collection = $collectionOrUrl;
            return;
        }

        if (!is_string($collectionOrUrl)) {
            throw new \InvalidArgumentException('$collectionOrUrl was not a string');
        }

        $mongo = new \MongoDB\Client(
            $collectionOrUrl,
            [],
            ['typeMap' => ['root' => 'array', 'document' => 'array', 'array' => 'array']]
        );
        $mongoDb = $mongo->selectDatabase($db);
        $this->collection = $mongoDb->selectCollection($collection);
    }
}


1			<?php
2			/**
3			* Defines the TraderInteractive\Mongo\Queue class.
4			*/
5
6			namespace TraderInteractive\Mongo;
7
8			/**
9			* Implementation of mongo db collection as priority queue.
10			*
11			* Tied priorities are ordered by time. So you may use a single priority for normal queuing (default args exist for
12			* this purpose). Using a random priority achieves random get()
13			*/
14			final class Queue extends AbstractQueue implements QueueInterface
15			{
16			/**
17			* Construct queue.
18			*
19			* @param \MongoDB\Collection\|string $collectionOrUrl A MongoCollection instance or the mongo connection url.
20			* @param string $db the mongo db name
21			* @param string $collection the collection name to use for the queue
22			*
23			* @throws \InvalidArgumentException $collectionOrUrl, $db or $collection was not a string
24			*/
25			public function __construct($collectionOrUrl, string $db = null, string $collection = null)
26			{
27			if ($collectionOrUrl instanceof \MongoDB\Collection) {
28			$this->collection = $collectionOrUrl;
29			return;
30			}
31
32			if (!is_string($collectionOrUrl)) {
33			throw new \InvalidArgumentException('$collectionOrUrl was not a string');
34			}
35
36			$mongo = new \MongoDB\Client(
37			$collectionOrUrl,
38			[],
39			['typeMap' => ['root' => 'array', 'document' => 'array', 'array' => 'array']]
40			);
41			$mongoDb = $mongo->selectDatabase($db);
42			$this->collection = $mongoDb->selectCollection($collection);
43			}
44			}
45

traderinteractive / mongo-queue-php

Pull Request — master (#60)

Queue::get() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like