Complex classes like AbstractQueue often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use AbstractQueue, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
19 | abstract class AbstractQueue |
||
20 | { |
||
21 | /** |
||
22 | * Maximum millisecond value to use for UTCDateTime creation. |
||
23 | * |
||
24 | * @var integer |
||
25 | */ |
||
26 | const MONGO_INT32_MAX = PHP_INT_MAX; |
||
27 | |||
28 | /** |
||
29 | * mongo collection to use for queue. |
||
30 | * |
||
31 | * @var \MongoDB\Collection |
||
32 | */ |
||
33 | protected $collection; |
||
34 | |||
35 | /** |
||
36 | * @var array |
||
37 | */ |
||
38 | const FIND_ONE_AND_UPDATE_OPTIONS = [ |
||
39 | 'sort' => ['priority' => 1, 'created' => 1], |
||
40 | 'typeMap' => ['root' => 'array', 'document' => 'array', 'array' => 'array'], |
||
41 | 'returnDocument' => FindOneAndUpdate::RETURN_DOCUMENT_AFTER, |
||
42 | ]; |
||
43 | |||
44 | /** |
||
45 | * @var integer |
||
46 | */ |
||
47 | const DEFAULT_MAX_NUMBER_OF_MESSAGES = 1; |
||
48 | |||
49 | /** |
||
50 | * @var integer |
||
51 | */ |
||
52 | const DEFAULT_RUNNING_RESET_DURATION = 600000; |
||
53 | |||
54 | /** |
||
55 | * @var integer |
||
56 | */ |
||
57 | const DEFAULT_WAIT_DURATION_IN_MILLISECONDS = 3000; |
||
58 | |||
59 | /** |
||
60 | * @var integer |
||
61 | */ |
||
62 | const DEFAULT_POLL_DURATION_IN_MILLISECONDS = 200; |
||
63 | |||
64 | /** |
||
65 | * @var array |
||
66 | */ |
||
67 | const DEFAULT_GET_OPTIONS = [ |
||
68 | 'maxNumberOfMessages' => self::DEFAULT_MAX_NUMBER_OF_MESSAGES, |
||
69 | 'runningResetDuration' => self::DEFAULT_RUNNING_RESET_DURATION, |
||
70 | 'waitDurationInMillis' => self::DEFAULT_WAIT_DURATION_IN_MILLISECONDS, |
||
71 | 'pollDurationInMillis' => self::DEFAULT_POLL_DURATION_IN_MILLISECONDS, |
||
72 | ]; |
||
73 | |||
74 | /** |
||
75 | * Ensure an index for the get() method. |
||
76 | * |
||
77 | * @param array $beforeSort Fields in get() call to index before the sort field in same format |
||
78 | * as \MongoDB\Collection::ensureIndex() |
||
79 | * @param array $afterSort Fields in get() call to index after the sort field in same format as |
||
80 | * \MongoDB\Collection::ensureIndex() |
||
81 | * |
||
82 | * @return void |
||
83 | * |
||
84 | * @throws \InvalidArgumentException value of $beforeSort or $afterSort is not 1 or -1 for ascending and descending |
||
85 | * @throws \InvalidArgumentException key in $beforeSort or $afterSort was not a string |
||
86 | */ |
||
87 | final public function ensureGetIndex(array $beforeSort = [], array $afterSort = []) |
||
102 | |||
103 | /** |
||
104 | * Ensure an index for the count() method. |
||
105 | * Is a no-op if the generated index is a prefix of an existing one. If you have a similar ensureGetIndex call, |
||
106 | * call it first. |
||
107 | * |
||
108 | * @param array $fields fields in count() call to index in same format as \MongoDB\Collection::createIndex() |
||
109 | * @param bool $includeRunning whether to include the running field in the index |
||
110 | * |
||
111 | * @return void |
||
112 | * |
||
113 | * @throws \InvalidArgumentException key in $fields was not a string |
||
114 | * @throws \InvalidArgumentException value of $fields is not 1 or -1 for ascending and descending |
||
115 | */ |
||
116 | final public function ensureCountIndex(array $fields, bool $includeRunning) |
||
128 | |||
129 | /** |
||
130 | * Get a non running message from the queue. |
||
131 | * |
||
132 | * @param array $query in same format as \MongoDB\Collection::find() where top level fields do not contain |
||
133 | * operators. Lower level fields can however. eg: valid {a: {$gt: 1}, "b.c": 3}, |
||
134 | * invalid {$and: [{...}, {...}]} |
||
135 | * @param array $options Associative array of get options. |
||
136 | * runningResetDuration => integer |
||
137 | * The duration (in miiliseconds) that the received messages are hidden from |
||
138 | * subsequent retrieve requests after being retrieved by a get() request. |
||
139 | * waitDurationInMillis => integer |
||
140 | * The duration (in milliseconds) for which the call will wait for a message to |
||
141 | * arrive in the queue before returning. If a message is available, the call will |
||
142 | * return sooner than WaitTimeSeconds. |
||
143 | * pollDurationInMillis => integer |
||
144 | * The millisecond duration to wait between polls. |
||
145 | * maxNumberOfMessages => integer |
||
146 | * The maximum number of messages to return with get(). All of the messages are not |
||
147 | * necessarily returned. |
||
148 | * |
||
149 | * @return array Array of messages. |
||
150 | * |
||
151 | * @throws \InvalidArgumentException key in $query was not a string |
||
152 | */ |
||
153 | final public function get(array $query, array $options = []) : array |
||
179 | |||
180 | /** |
||
181 | * Count queue messages. |
||
182 | * |
||
183 | * @param array $query in same format as \MongoDB\Collection::find() where top level fields do not contain |
||
184 | * operators. Lower level fields can however. eg: valid {a: {$gt: 1}, "b.c": 3}, |
||
185 | * invalid {$and: [{...}, {...}]} |
||
186 | * @param bool|null $running query a running message or not or all |
||
187 | * |
||
188 | * @return int the count |
||
189 | * |
||
190 | * @throws \InvalidArgumentException key in $query was not a string |
||
191 | */ |
||
192 | final public function count(array $query, bool $running = null) : int |
||
203 | |||
204 | /** |
||
205 | * Acknowledge a message was processed and remove from queue. |
||
206 | * |
||
207 | * @param Message $message message received from get() |
||
208 | * |
||
209 | * @return void |
||
210 | */ |
||
211 | final public function ack(Message $message) |
||
215 | |||
216 | /** |
||
217 | * Atomically acknowledge and send a message to the queue. |
||
218 | * |
||
219 | * @param Message $message message received from get(). |
||
220 | * |
||
221 | * @return void |
||
222 | */ |
||
223 | final public function requeue(Message $message) |
||
234 | |||
235 | /** |
||
236 | * Send a message to the queue. |
||
237 | * |
||
238 | * @param Message $message The message to send. |
||
239 | * |
||
240 | * @return void |
||
241 | */ |
||
242 | final public function send(Message $message) |
||
254 | |||
255 | /** |
||
256 | * Ensure index of correct specification and a unique name whether the specification or name already exist or not. |
||
257 | * Will not create index if $index is a prefix of an existing index |
||
258 | * |
||
259 | * @param array $index index to create in same format as \MongoDB\Collection::createIndex() |
||
260 | * |
||
261 | * @return void |
||
262 | * |
||
263 | * @throws \Exception couldnt create index after 5 attempts |
||
264 | */ |
||
265 | final private function ensureIndex(array $index) |
||
280 | |||
281 | private function buildPayloadQuery(array $initialQuery, array $payloadQuery) |
||
293 | |||
294 | private function calculateSleepTime(int $pollDurationInMillis) : int |
||
301 | |||
302 | private function calculateEarliestGet(int $runningResetDuration) : UTCDateTime |
||
308 | |||
309 | private function tryFindOneAndUpdate(array $query, array $update, ArrayObject $messages) : bool |
||
325 | |||
326 | private function isIndexIncludedInExistingIndex(array $index) : bool |
||
338 | |||
339 | private function tryCreateIndex(array $index) : bool |
||
349 | |||
350 | private function tryCreateNamedIndex(array $index, string $name) : bool |
||
364 | |||
365 | private function indexExists(array $index) : bool |
||
375 | |||
376 | /** |
||
377 | * Helper method to validate keys and values for the given sort array |
||
378 | * |
||
379 | * @param array $sort The proposed sort for a mongo index. |
||
380 | * @param string $label The name of the variable given to the public ensureXIndex method. |
||
381 | * @param array &$completedFields The final index array with payload. prefix added to fields. |
||
382 | * |
||
383 | * @return void |
||
384 | */ |
||
385 | final private function verifySort(array $sort, string $label, array &$completeFields) |
||
397 | |||
398 | private function throwIfTrue( |
||
408 | |||
409 | private function calculateEndTime(int $waitDurationInMillis) : int |
||
414 | } |
||
415 |