Queue::get() - Code Metrics - Inspection of "[WIP] Version 3" - traderinteractive/mongo-queue-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#60)

by Chad

created 2018-03-02 23:56 UTC

Queue::get() C

↳ Parent: Project

Complexity

Conditions	13
Paths	101

Size

Total Lines	71
Code Lines	34

Duplication

Lines	7
Ratio	9.86 %

Importance

Changes

Metric	Value
dl	7
loc	71
rs	5.5441
c	0
b	0
f	0
cc	13
eloc	34
nc	101
nop	4

How to fix Long Method Complexity

<?php
/**
 * Defines the TraderInteractive\Mongo\Queue class.
 */

namespace TraderInteractive\Mongo;

use MongoDB\BSON\UTCDateTime;

/**
 * Abstraction of mongo db collection as priority queue.
 *
 * Tied priorities are ordered by time. So you may use a single priority for normal queuing (default args exist for
 * this purpose).  Using a random priority achieves random get()
 */
final class Queue extends AbstractQueue implements QueueInterface
{
    /**
     * Construct queue.
     *
     * @param \MongoDB\Collection|string $collectionOrUrl A MongoCollection instance or the mongo connection url.
     * @param string $db the mongo db name
     * @param string $collection the collection name to use for the queue
     *
     * @throws \InvalidArgumentException $collectionOrUrl, $db or $collection was not a string
     */
    public function __construct($collectionOrUrl, string $db = null, string $collection = null)
    {
        if ($collectionOrUrl instanceof \MongoDB\Collection) {
            $this->collection = $collectionOrUrl;
            return;
        }

        if (!is_string($collectionOrUrl)) {
            throw new \InvalidArgumentException('$collectionOrUrl was not a string');
        }

        $mongo = new \MongoDB\Client(
            $collectionOrUrl,
            [],
            ['typeMap' => ['root' => 'array', 'document' => 'array', 'array' => 'array']]
        );
        $mongoDb = $mongo->selectDatabase($db);
        $this->collection = $mongoDb->selectCollection($collection);
    }
}


1			<?php
2			/**
3			* Defines the TraderInteractive\Mongo\Queue class.
4			*/
5
6			namespace TraderInteractive\Mongo;
7
8			use MongoDB\BSON\UTCDateTime;
9
10			/**
11			* Abstraction of mongo db collection as priority queue.
12			*
13			* Tied priorities are ordered by time. So you may use a single priority for normal queuing (default args exist for
14			* this purpose). Using a random priority achieves random get()
15			*/
16			final class Queue extends AbstractQueue implements QueueInterface
17			{
18			/**
19			* Construct queue.
20			*
21			* @param \MongoDB\Collection\|string $collectionOrUrl A MongoCollection instance or the mongo connection url.
22			* @param string $db the mongo db name
23			* @param string $collection the collection name to use for the queue
24			*
25			* @throws \InvalidArgumentException $collectionOrUrl, $db or $collection was not a string
26			*/
27			public function __construct($collectionOrUrl, string $db = null, string $collection = null)
28			{
29			if ($collectionOrUrl instanceof \MongoDB\Collection) {
30			$this->collection = $collectionOrUrl;
31			return;
32			}
33
34			if (!is_string($collectionOrUrl)) {
35			throw new \InvalidArgumentException('$collectionOrUrl was not a string');
36			}
37
38			$mongo = new \MongoDB\Client(
39			$collectionOrUrl,
40			[],
41			['typeMap' => ['root' => 'array', 'document' => 'array', 'array' => 'array']]
42			);
43			$mongoDb = $mongo->selectDatabase($db);
44			$this->collection = $mongoDb->selectCollection($collection);
45			}
46			}
47

traderinteractive / mongo-queue-php

Pull Request — master (#60)

Queue::get() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like