TraderInteractive\Mongo\Queue::__construct()

Complexity

Conditions	3
Paths	3

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function __construct($collectionOrUrl, string $db = null, string $collection = null)
    {
        if ($collectionOrUrl instanceof \MongoDB\Collection) {
            $this->collection = $collectionOrUrl;
            return;
        }

        if (!is_string($collectionOrUrl)) {

The condition is_string($collectionOrUrl) is always true.

            throw new \InvalidArgumentException('$collectionOrUrl was not a string');
        }

        $this->collection = (new Client($collectionOrUrl))->selectDatabase($db)->selectCollection($collection);

It seems like $db can also be of type null; however, parameter $databaseName of MongoDB\Client::selectDatabase() does only seem to accept string, maybe add an additional type check?

It seems like $collection can also be of type null; however, parameter $collectionName of MongoDB\Database::selectCollection() does only seem to accept string, maybe add an additional type check?

    }