TraderInteractive\Filter\Url

Complexity

Total Complexity

7

Size/Duplication

Total Lines	38
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	filterUrl()	0	8	2
B	filter()	0	11	5

<?php

namespace TraderInteractive\Filter;

use TraderInteractive\Exceptions\FilterException;

/**
 * A collection of filters for urls.
 */
final class Url
{
    /**
     * Filter an url
     *
     * Filters value as URL (according to » http://www.faqs.org/rfcs/rfc2396)
     *
     * The return value is the url, as expected by the \TraderInteractive\Filterer class.
     * By default, nulls are not allowed.
     *
     * @param mixed $value The value to filter.
     * @param bool $allowNull True to allow nulls through, and false (default) if nulls should not be allowed.
     *
     * @return string|null The passed in $value.
     *
     * @throws FilterException if the value did not pass validation.
     */
    public static function filter(string $value = null, bool $allowNull = false)
    {
        if ($allowNull === true && $value === null) {
            return null;
        }

        if ($allowNull === false && $value === null) {
            throw new FilterException('Value failed filtering, $allowNull is set to false');
        }

        return self::filterUrl($value);

It seems like $value can also be of type null; however, parameter $value of TraderInteractive\Filter\Url::filterUrl() does only seem to accept string, maybe add an additional type check?

    }

    private static function filterUrl(string $value) : string
    {
        $filteredUrl = filter_var($value, FILTER_VALIDATE_URL);
        if ($filteredUrl === false) {
            throw new FilterException("Value '{$value}' is not a valid url");
        }

        return $filteredUrl;
    }
}