StringsTest::filterMinLengthNotInteger() - Code Metrics - Inspection of "Version 3.0" - traderinteractive/filter-strings-php - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#1)

unknown

created 2018-03-06 18:14 UTC

StringsTest::filterMinLengthNotInteger() A

↳ Parent: StringsTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	0
dl	0
loc	3
rs	10
c	0
b	0
f	0

<?php

namespace TraderInteractive\Filter;

use InvalidArgumentException;
use PHPUnit\Framework\TestCase;
use TraderInteractive\Exceptions\FilterException;

/**
 * @coversDefaultClass \TraderInteractive\Filter\Strings
 */
final class StringsTest extends TestCase
{
    /**
     * Verify basic use of filter
     *
     * @test
     * @covers ::filter
     * @dataProvider filterData
     *
     * @param mixed $input    The input.
     * @param mixed $expected The expected value(s).
     *
     * @return void
     * @throws FilterException
     */
    public function filter($input, $expected)
    {
        $this->assertSame($expected, Strings::filter($input));
    }

    /**
     * Data provider for basic filter tests
     *
     * @return array
     */
    public function filterData()
    {
        return [
            'string' => ['abc', 'abc'],
            'int' => [1, '1'],
            'float' => [1.1, '1.1'],
            'bool' => [true, '1'],
            'object' => [new \SplFileInfo(__FILE__), __FILE__],
        ];
    }

    /**
     * @test
     * @covers ::filter
     */
    public function filterNullPass()
    {
        $this->assertNull(Strings::filter(null, true));
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
    }

    /**
     * @test
     * @expectedException \TraderInteractive\Exceptions\FilterException
     * @expectedExceptionMessage Value failed filtering, $allowNull is set to false
     * @covers ::filter
     */
    public function filterNullFail()
    {
        Strings::filter(null);
    }

    /**
     * @test
     * @covers ::filter
     */
    public function filterMinLengthPass()
    {
        $this->assertSame('a', Strings::filter('a'));
    }

    /**
     * @test
     * @expectedException \TraderInteractive\Exceptions\FilterException
     * @covers ::filter
     */
    public function filterMinLengthFail()
    {
        Strings::filter('');
    }

    /**
     * @test
     * @covers ::filter
     */
    public function filterMaxLengthPass()
    {
        $this->assertSame('a', Strings::filter('a', false, 0, 1));
    }

    /**
     * @test
     * @expectedException \TraderInteractive\Exceptions\FilterException
     * @expectedExceptionMessage Value 'a' with length '1' is less than '0' or greater than '0'
     * @covers ::filter
     */
    public function filterMaxLengthFail()
    {
        Strings::filter('a', false, 0, 0);
    }

    /**
     * @test
     * @expectedException InvalidArgumentException
     * @expectedExceptionMessage $minLength was not a positive integer value
     * @covers ::filter
     */
    public function filterMinLengthNotInteger()
    {
        Strings::filter('a', false, -1);
    }

    /**
     * @test
     * @expectedException InvalidArgumentException
     * @expectedExceptionMessage $maxLength was not a positive integer value
     * @covers ::filter
     */
    public function filterMaxLengthNotInteger()
    {
        Strings::filter('a', false, 1, -1);
    }

    /**
     * @test
     * @expectedException InvalidArgumentException
     * @expectedExceptionMessage $minLength was not a positive integer value
     * @covers ::filter
     */
    public function filterMinLengthNegative()
    {
        Strings::filter('a', false, -1);
    }

    /**
     * @test
     * @expectedException InvalidArgumentException
     * @expectedExceptionMessage $maxLength was not a positive integer value
     * @covers ::filter
     */
    public function filterMaxLengthNegative()
    {
        Strings::filter('a', false, 1, -1);
    }

    /**
     * @test
     * @covers ::filter
     */
    public function filterWithScalar()
    {
        $this->assertSame('24141', Strings::filter(24141));
    }

    /**
     * @test
     * @covers ::filter
     */
    public function filterWithObject()
    {
        $testObject = new class() {
            private $data;

            public function __construct()
            {
                $this->data = [1,2,3,4,5];
            }

            public function __toString()
            {
                return implode(',', $this->data);
            }
        };

        $this->assertSame('1,2,3,4,5', Strings::filter(new $testObject));
    }

    /**
     * @test
     * @covers ::filter
     *
     * @expectedException \TraderInteractive\Exceptions\FilterException
     * @expectedExceptionMessage Value 'class@anonymous
     */
    public function filterWithObjectNoToStringMethod()
    {
        $testObject = new class() {
            private $data;

            public function __construct()
            {
                $this->data = [1, 2, 3, 4, 5];
            }
        };

        Strings::filter(new $testObject);
    }

    /**
     * Verifies basic explode functionality.
     *
     * @test
     * @covers ::explode
     */
    public function explode()
    {
        $this->assertSame(['a', 'bcd', 'e'], Strings::explode('a,bcd,e'));
    }

    /**
     * Verifies explode with a custom delimiter.
     *
     * @test
     * @covers ::explode
     */
    public function explodeCustomDelimiter()
    {
        $this->assertSame(['a', 'b', 'c', 'd,e'], Strings::explode('a b c d,e', ' '));
    }

    /**
     * @test
     * @expectedException \TraderInteractive\Exceptions\FilterException
     * @expectedExceptionMessage Value '1234' is not a string
     * @covers ::explode
     */
    public function explodeNonString()
    {
        Strings::explode(1234, '');
    }

    /**
     * Verifies explode filter with an empty delimiter.
     *
     * @test
     * @expectedException \InvalidArgumentException
     * @expectedExceptionMessage Delimiter '''' is not a non-empty string
     * @covers ::explode
     */
    public function explodeEmptyDelimiter()
    {
        Strings::explode('test', '');
    }
}


1			<?php
2
3			namespace TraderInteractive\Filter;
4
5			use InvalidArgumentException;
6			use PHPUnit\Framework\TestCase;
7			use TraderInteractive\Exceptions\FilterException;
8
9			/**
10			* @coversDefaultClass \TraderInteractive\Filter\Strings
11			*/
12			final class StringsTest extends TestCase
13			{
14			/**
15			* Verify basic use of filter
16			*
17			* @test
18			* @covers ::filter
19			* @dataProvider filterData
20			*
21			* @param mixed $input The input.
22			* @param mixed $expected The expected value(s).
23			*
24			* @return void
25			* @throws FilterException
26			*/
27			public function filter($input, $expected)
28			{
29			$this->assertSame($expected, Strings::filter($input));
30			}
31
32			/**
33			* Data provider for basic filter tests
34			*
35			* @return array
36			*/
37			public function filterData()
38			{
39			return [
40			'string' => ['abc', 'abc'],
41			'int' => [1, '1'],
42			'float' => [1.1, '1.1'],
43			'bool' => [true, '1'],
44			'object' => [new \SplFileInfo(__FILE__), __FILE__],
45			];
46			}
47
48			/**
49			* @test
50			* @covers ::filter
51			*/
52			public function filterNullPass()
53			{
54			$this->assertNull(Strings::filter(null, true));
			0 ignored issues – show Bug introduced 2018-03-05 22:43 UTC by Report Bug Copy Issue Report Are you sure the usage of `TraderInteractive\Filter...ngs::filter(null, true)` targeting `TraderInteractive\Filter\Strings::filter()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
55			}
56
57			/**
58			* @test
59			* @expectedException \TraderInteractive\Exceptions\FilterException
60			* @expectedExceptionMessage Value failed filtering, $allowNull is set to false
61			* @covers ::filter
62			*/
63			public function filterNullFail()
64			{
65			Strings::filter(null);
66			}
67
68			/**
69			* @test
70			* @covers ::filter
71			*/
72			public function filterMinLengthPass()
73			{
74			$this->assertSame('a', Strings::filter('a'));
75			}
76
77			/**
78			* @test
79			* @expectedException \TraderInteractive\Exceptions\FilterException
80			* @covers ::filter
81			*/
82			public function filterMinLengthFail()
83			{
84			Strings::filter('');
85			}
86
87			/**
88			* @test
89			* @covers ::filter
90			*/
91			public function filterMaxLengthPass()
92			{
93			$this->assertSame('a', Strings::filter('a', false, 0, 1));
94			}
95
96			/**
97			* @test
98			* @expectedException \TraderInteractive\Exceptions\FilterException
99			* @expectedExceptionMessage Value 'a' with length '1' is less than '0' or greater than '0'
100			* @covers ::filter
101			*/
102			public function filterMaxLengthFail()
103			{
104			Strings::filter('a', false, 0, 0);
105			}
106
107			/**
108			* @test
109			* @expectedException InvalidArgumentException
110			* @expectedExceptionMessage $minLength was not a positive integer value
111			* @covers ::filter
112			*/
113			public function filterMinLengthNotInteger()
114			{
115			Strings::filter('a', false, -1);
116			}
117
118			/**
119			* @test
120			* @expectedException InvalidArgumentException
121			* @expectedExceptionMessage $maxLength was not a positive integer value
122			* @covers ::filter
123			*/
124			public function filterMaxLengthNotInteger()
125			{
126			Strings::filter('a', false, 1, -1);
127			}
128
129			/**
130			* @test
131			* @expectedException InvalidArgumentException
132			* @expectedExceptionMessage $minLength was not a positive integer value
133			* @covers ::filter
134			*/
135			public function filterMinLengthNegative()
136			{
137			Strings::filter('a', false, -1);
138			}
139
140			/**
141			* @test
142			* @expectedException InvalidArgumentException
143			* @expectedExceptionMessage $maxLength was not a positive integer value
144			* @covers ::filter
145			*/
146			public function filterMaxLengthNegative()
147			{
148			Strings::filter('a', false, 1, -1);
149			}
150
151			/**
152			* @test
153			* @covers ::filter
154			*/
155			public function filterWithScalar()
156			{
157			$this->assertSame('24141', Strings::filter(24141));
158			}
159
160			/**
161			* @test
162			* @covers ::filter
163			*/
164			public function filterWithObject()
165			{
166			$testObject = new class() {
167			private $data;
168
169			public function __construct()
170			{
171			$this->data = [1,2,3,4,5];
172			}
173
174			public function __toString()
175			{
176			return implode(',', $this->data);
177			}
178			};
179
180			$this->assertSame('1,2,3,4,5', Strings::filter(new $testObject));
181			}
182
183			/**
184			* @test
185			* @covers ::filter
186			*
187			* @expectedException \TraderInteractive\Exceptions\FilterException
188			* @expectedExceptionMessage Value 'class@anonymous
189			*/
190			public function filterWithObjectNoToStringMethod()
191			{
192			$testObject = new class() {
193			private $data;
194
195			public function __construct()
196			{
197			$this->data = [1, 2, 3, 4, 5];
198			}
199			};
200
201			Strings::filter(new $testObject);
202			}
203
204			/**
205			* Verifies basic explode functionality.
206			*
207			* @test
208			* @covers ::explode
209			*/
210			public function explode()
211			{
212			$this->assertSame(['a', 'bcd', 'e'], Strings::explode('a,bcd,e'));
213			}
214
215			/**
216			* Verifies explode with a custom delimiter.
217			*
218			* @test
219			* @covers ::explode
220			*/
221			public function explodeCustomDelimiter()
222			{
223			$this->assertSame(['a', 'b', 'c', 'd,e'], Strings::explode('a b c d,e', ' '));
224			}
225
226			/**
227			* @test
228			* @expectedException \TraderInteractive\Exceptions\FilterException
229			* @expectedExceptionMessage Value '1234' is not a string
230			* @covers ::explode
231			*/
232			public function explodeNonString()
233			{
234			Strings::explode(1234, '');
235			}
236
237			/**
238			* Verifies explode filter with an empty delimiter.
239			*
240			* @test
241			* @expectedException \InvalidArgumentException
242			* @expectedExceptionMessage Delimiter '''' is not a non-empty string
243			* @covers ::explode
244			*/
245			public function explodeEmptyDelimiter()
246			{
247			Strings::explode('test', '');
248			}
249			}
250

traderinteractive / filter-strings-php

Pull Request — master (#1)

StringsTest::filterMinLengthNotInteger() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like