BooleansTest::filterInvalidString() - Code Metrics - Inspection of "[WIP] Version 3.0" - traderinteractive/filter-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#75)

unknown

created 2018-03-05 18:26 UTC

BooleansTest::filterInvalidString() A

↳ Parent: BooleansTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0

<?php

namespace TraderInteractive\Filter;

use PHPUnit\Framework\TestCase;

/**
 * @coversDefaultClass \TraderInteractive\Filter\Booleans
 */
final class BooleansTest extends TestCase
{
    /**
     * @test
     * @covers ::filter
     */
    public function filterBasic()
    {
        $this->assertTrue(Booleans::filter(true));

        $this->assertTrue(Booleans::filter('   true'));

        $this->assertTrue(Booleans::filter(' TRUE '));

        $this->assertTrue(Booleans::filter('True '));


        $this->assertFalse(Booleans::filter('false   '));

        $this->assertFalse(Booleans::filter('FALSE  '));

        $this->assertFalse(Booleans::filter(' False '));

        $this->assertFalse(Booleans::filter(false));

    }

    /**
     * @test
     * @covers ::filter
     */
    public function filterAllowNullIsTrueAndNullValue()
    {
        $this->assertNull(Booleans::filter(null, true));
    }

    /**
     * @test
     * @covers ::filter
     * @expectedException \TraderInteractive\Filter\Exception
     * @expectedExceptionMessage "1" $value is not a string
     */
    public function filterNonStringAndNonBoolValue()
    {
        Booleans::filter(1);
    }

    /**
     * @test
     * @covers ::filter
     * @expectedException \TraderInteractive\Filter\Exception
     * @expectedExceptionMessage invalid is not 'true' or 'false' disregarding case and whitespace
     */
    public function filterInvalidString()
    {
        Booleans::filter('invalid');
    }

    /**
     * @test
     * @covers ::filter
     */
    public function filterCustomTrueValues()
    {
        $this->assertTrue(Booleans::filter('Y', false, ['y']));

    }

    /**
     * @test
     * @covers ::filter
     */
    public function filterCustomFalseValues()
    {
        $this->assertFalse(Booleans::filter('0', false, ['true'], ['0']));

    }

    /**
     * @test
     * @covers ::filter
     * @expectedException \TraderInteractive\Filter\Exception
     * @expectedExceptionMessage true is not 'y' or '1' or 'n' or '0' disregarding case and whitespace
     */
    public function filterCustomBoolValuesInvalidString()
    {
        $this->assertFalse(Booleans::filter('true', false, ['y', '1'], ['n', '0']));

    }

    /**
     * Verify basic behavior of convert().
     *
     * @test
     * @covers ::convert
     *
     * @return void
     */
    public function convert()
    {
        $this->assertSame('yes', Booleans::convert(true, 'yes', 'no'));
        $this->assertSame('bar', Booleans::convert(false, 'foo', 'bar'));
    }
}


1			<?php
2
3			namespace TraderInteractive\Filter;
4
5			use PHPUnit\Framework\TestCase;
6
7			/**
8			* @coversDefaultClass \TraderInteractive\Filter\Booleans
9			*/
10			final class BooleansTest extends TestCase
11			{
12			/**
13			* @test
14			* @covers ::filter
15			*/
16			public function filterBasic()
17			{
18			$this->assertTrue(Booleans::filter(true));
			0 ignored issues – show Bug introduced 2018-03-02 20:25 UTC by Report Bug Copy Issue Report It seems like `\TraderInteractive\Filter\Booleans::filter(true)` targeting `TraderInteractive\Filter\Booleans::filter()` can also be of type `null`; however, `PHPUnit\Framework\Assert::assertTrue()` does only seem to accept `boolean`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
19			$this->assertTrue(Booleans::filter(' true'));
			0 ignored issues – show Bug introduced 2018-03-02 20:25 UTC by Report Bug Copy Issue Report It seems like `\TraderInteractive\Filte...eans::filter(' true')` targeting `TraderInteractive\Filter\Booleans::filter()` can also be of type `null`; however, `PHPUnit\Framework\Assert::assertTrue()` does only seem to accept `boolean`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
20			$this->assertTrue(Booleans::filter(' TRUE '));
			0 ignored issues – show Bug introduced 2018-03-02 20:25 UTC by Report Bug Copy Issue Report It seems like `\TraderInteractive\Filte...leans::filter(' TRUE ')` targeting `TraderInteractive\Filter\Booleans::filter()` can also be of type `null`; however, `PHPUnit\Framework\Assert::assertTrue()` does only seem to accept `boolean`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
21			$this->assertTrue(Booleans::filter('True '));
			0 ignored issues – show Bug introduced 2018-03-02 20:25 UTC by Report Bug Copy Issue Report It seems like `\TraderInteractive\Filte...oleans::filter('True ')` targeting `TraderInteractive\Filter\Booleans::filter()` can also be of type `null`; however, `PHPUnit\Framework\Assert::assertTrue()` does only seem to accept `boolean`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
22
23			$this->assertFalse(Booleans::filter('false '));
			0 ignored issues – show Bug introduced 2018-03-02 20:25 UTC by Report Bug Copy Issue Report It seems like `\TraderInteractive\Filte...ans::filter('false ')` targeting `TraderInteractive\Filter\Booleans::filter()` can also be of type `null`; however, `PHPUnit\Framework\Assert::assertFalse()` does only seem to accept `boolean`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
24			$this->assertFalse(Booleans::filter('FALSE '));
			0 ignored issues – show Bug introduced 2018-03-02 20:25 UTC by Report Bug Copy Issue Report It seems like `\TraderInteractive\Filte...eans::filter('FALSE ')` targeting `TraderInteractive\Filter\Booleans::filter()` can also be of type `null`; however, `PHPUnit\Framework\Assert::assertFalse()` does only seem to accept `boolean`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
25			$this->assertFalse(Booleans::filter(' False '));
			0 ignored issues – show Bug introduced 2018-03-02 20:25 UTC by Report Bug Copy Issue Report It seems like `\TraderInteractive\Filte...eans::filter(' False ')` targeting `TraderInteractive\Filter\Booleans::filter()` can also be of type `null`; however, `PHPUnit\Framework\Assert::assertFalse()` does only seem to accept `boolean`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
26			$this->assertFalse(Booleans::filter(false));
			0 ignored issues – show Bug introduced 2018-03-02 20:25 UTC by Report Bug Copy Issue Report It seems like `\TraderInteractive\Filter\Booleans::filter(false)` targeting `TraderInteractive\Filter\Booleans::filter()` can also be of type `null`; however, `PHPUnit\Framework\Assert::assertFalse()` does only seem to accept `boolean`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
27			}
28
29			/**
30			* @test
31			* @covers ::filter
32			*/
33			public function filterAllowNullIsTrueAndNullValue()
34			{
35			$this->assertNull(Booleans::filter(null, true));
36			}
37
38			/**
39			* @test
40			* @covers ::filter
41			* @expectedException \TraderInteractive\Filter\Exception
42			* @expectedExceptionMessage "1" $value is not a string
43			*/
44			public function filterNonStringAndNonBoolValue()
45			{
46			Booleans::filter(1);
47			}
48
49			/**
50			* @test
51			* @covers ::filter
52			* @expectedException \TraderInteractive\Filter\Exception
53			* @expectedExceptionMessage invalid is not 'true' or 'false' disregarding case and whitespace
54			*/
55			public function filterInvalidString()
56			{
57			Booleans::filter('invalid');
58			}
59
60			/**
61			* @test
62			* @covers ::filter
63			*/
64			public function filterCustomTrueValues()
65			{
66			$this->assertTrue(Booleans::filter('Y', false, ['y']));
			0 ignored issues – show Bug introduced 2018-03-02 20:25 UTC by Report Bug Copy Issue Report It seems like `\TraderInteractive\Filte...'Y', false, array('y'))` targeting `TraderInteractive\Filter\Booleans::filter()` can also be of type `null`; however, `PHPUnit\Framework\Assert::assertTrue()` does only seem to accept `boolean`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
67			}
68
69			/**
70			* @test
71			* @covers ::filter
72			*/
73			public function filterCustomFalseValues()
74			{
75			$this->assertFalse(Booleans::filter('0', false, ['true'], ['0']));
			0 ignored issues – show Bug introduced 2018-03-02 20:25 UTC by Report Bug Copy Issue Report It seems like `\TraderInteractive\Filte...ay('true'), array('0'))` targeting `TraderInteractive\Filter\Booleans::filter()` can also be of type `null`; however, `PHPUnit\Framework\Assert::assertFalse()` does only seem to accept `boolean`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
76			}
77
78			/**
79			* @test
80			* @covers ::filter
81			* @expectedException \TraderInteractive\Filter\Exception
82			* @expectedExceptionMessage true is not 'y' or '1' or 'n' or '0' disregarding case and whitespace
83			*/
84			public function filterCustomBoolValuesInvalidString()
85			{
86			$this->assertFalse(Booleans::filter('true', false, ['y', '1'], ['n', '0']));
			0 ignored issues – show Bug introduced 2018-03-02 20:25 UTC by Report Bug Copy Issue Report It seems like `\TraderInteractive\Filte... '1'), array('n', '0'))` targeting `TraderInteractive\Filter\Booleans::filter()` can also be of type `null`; however, `PHPUnit\Framework\Assert::assertFalse()` does only seem to accept `boolean`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
87			}
88
89			/**
90			* Verify basic behavior of convert().
91			*
92			* @test
93			* @covers ::convert
94			*
95			* @return void
96			*/
97			public function convert()
98			{
99			$this->assertSame('yes', Booleans::convert(true, 'yes', 'no'));
100			$this->assertSame('bar', Booleans::convert(false, 'foo', 'bar'));
101			}
102			}
103

traderinteractive / filter-php

Pull Request — master (#75)

BooleansTest::filterInvalidString() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like