FloatsTest - Code Metrics - Inspection of "[WIP] Version 3.0" - traderinteractive/filter-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#75)

unknown

created 2018-03-05 18:26 UTC

FloatsTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	236
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
wmc	21
lcom	1
cbo	2
dl	0
loc	236
rs	10
c	0
b	0
f	0

21 Methods

Rating	Name	Size	Complexity
A	filterAllowNullIsTrueAndNullValue()	4	1
A	filterPositiveFloat()	4	1
A	filterNegativeFloat()	4	1
A	filterZeroFloat()	6	1
A	filterPositiveString()	15	1
A	filterNegativeString()	13	1
A	filterNonStringOrFloat()	4	1
A	filterEmptyString()	4	1
A	filterWhitespaceString()	4	1
A	filterNonDigitString()	4	1
A	filterHexString()	4	1
A	filterRogueSpaceStringAfterPeriod()	4	1
A	filterRogueSpaceStringBetweenDigits()	4	1
A	filterOverflow()	4	1
A	filterUnderflow()	4	1
A	filterLessThanMin()	4	1
A	filterEqualToMin()	4	1
A	filterGreaterThanMax()	4	1
A	filterEqualToMax()	4	1
A	filterCastInts()	4	1
A	filterCastIntsIsFalse()	4	1

<?php

namespace TraderInteractive\Filter;

use PHPUnit\Framework\TestCase;

/**
 * @coversDefaultClass \TraderInteractive\Filter\Floats
 */
final class FloatsTest extends TestCase
{
    /**
     * @test
     * @covers ::filter
     */
    public function filterAllowNullIsTrueAndNullValue()
    {
        $this->assertNull(Floats::filter(null, true));
    }

    /**
     * @test
     * @covers ::filter
     */
    public function filterPositiveFloat()
    {
        $this->assertSame(123.0, Floats::filter(123.0));
    }

    /**
     * @test
     * @covers ::filter
     */
    public function filterNegativeFloat()
    {
        $this->assertSame(-123.0, Floats::filter(-123.0));
    }

    /**
     * @test
     * @covers ::filter
     */
    public function filterZeroFloat()
    {
        $positiveZero = + 0.0;
        $this->assertSame(0.0, Floats::filter($positiveZero));
        $this->assertSame(-0.0, Floats::filter(-0.0));
    }

    /**
     * @test
     * @covers ::filter
     */
    public function filterPositiveString()
    {
        $this->assertSame(123.0, Floats::filter('   123 '));
        $this->assertSame(123.0, Floats::filter('   +123 '));
        $this->assertSame(123.0, Floats::filter('   123.0 '));
        $this->assertSame(123.0, Floats::filter('   123E0 '));
        $this->assertSame(123.0, Floats::filter('   +123e0 '));
        $this->assertSame(123.0, Floats::filter('   +1230e-1 '));
        $this->assertSame(1230.0, Floats::filter('   +123e+1 '));
        $this->assertSame(0.0, Floats::filter('   +0 '));
        $this->assertSame(0.0, Floats::filter('   +0.0 '));
        $this->assertSame(0.0, Floats::filter('   0E0 '));
        $this->assertSame(0.0, Floats::filter('   00e-1 '));
        $this->assertSame(0.0, Floats::filter('   00e+1 '));
    }

    /**
     * @test
     * @covers ::filter
     */
    public function filterNegativeString()
    {
        $this->assertSame(-123.0, Floats::filter('   -123 '));
        $this->assertSame(-123.0, Floats::filter('   -123.0 '));
        $this->assertSame(-123.0, Floats::filter('   -123E0 '));
        $this->assertSame(-123.0, Floats::filter('   -1230E-1 '));
        $this->assertSame(-1230.0, Floats::filter('   -123e+1 '));
        $this->assertSame(-0.0, Floats::filter('   -0 '));
        $this->assertSame(-0.0, Floats::filter('   -0.0 '));
        $this->assertSame(-0.0, Floats::filter('   -0e0 '));
        $this->assertSame(-0.0, Floats::filter('   -00e-1 '));
        $this->assertSame(-0.0, Floats::filter('   -0e+1 '));
    }

    /**
     * @test
     * @covers ::filter
     * @expectedException \TraderInteractive\Filter\Exception
     * @expectedExceptionMessage "true" $value is not a string
     */
    public function filterNonStringOrFloat()
    {
        Floats::filter(true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * @test
     * @covers ::filter
     * @expectedException \TraderInteractive\Filter\Exception
     * @exceptedExceptionMessage  does not pass is_numeric
     */
    public function filterEmptyString()
    {
        Floats::filter('');
    }

    /**
     * @test
     * @covers ::filter
     * @expectedException \TraderInteractive\Filter\Exception
     * @expectedExceptionMessage  does not pass is_numeric
     */
    public function filterWhitespaceString()
    {
        Floats::filter('   ');
    }

    /**
     * @test
     * @covers ::filter
     * @expectedException \TraderInteractive\Filter\Exception
     * @expectedExceptionMessage 123-4 does not pass is_numeric
     */
    public function filterNonDigitString()
    {
        Floats::filter('123-4');
    }

    /**
     * @test
     * @covers ::filter
     * @expectedException \TraderInteractive\Filter\Exception
     */
    public function filterHexString()
    {
        Floats::filter('0xFF');
    }

    /**
     * @test
     * @covers ::filter
     * @expectedException \TraderInteractive\Filter\Exception
     * @expectedExceptionMessage 1. 0 does not pass is_numeric
     */
    public function filterRogueSpaceStringAfterPeriod()
    {
        Floats::filter('1. 0');
    }

    /**
     * @test
     * @covers ::filter
     * @expectedException \TraderInteractive\Filter\Exception
     * @expectedExceptionMessage 1 0 does not pass is_numeric
     */
    public function filterRogueSpaceStringBetweenDigits()
    {
        Floats::filter('1 0');
    }

    /**
     * @test
     * @covers ::filter
     * @expectedException \TraderInteractive\Filter\Exception
     * @expectedExceptionMessage 1e999999999999 overflow
     */
    public function filterOverflow()
    {
        Floats::filter('1e999999999999');
    }

    /**
     * @test
     * @covers ::filter
     * @expectedException \TraderInteractive\Filter\Exception
     * @expectedExceptionMessage -1e999999999999 overflow
     */
    public function filterUnderflow()
    {
        Floats::filter('-1e999999999999');
    }

    /**
     * @test
     * @covers ::filter
     * @expectedException \TraderInteractive\Filter\Exception
     * @expectedExceptionMessage -1 is less than 0
     */
    public function filterLessThanMin()
    {
        Floats::filter(-1.0, false, 0.0);
    }

    /**
     * @test
     * @covers ::filter
     */
    public function filterEqualToMin()
    {
        $this->assertSame(0.0, Floats::filter(0.0, false, 0.0));
    }

    /**
     * @test
     * @covers ::filter
     * @expectedException \TraderInteractive\Filter\Exception
     * @expectedExceptionMessage 1 is greater than 0
     */
    public function filterGreaterThanMax()
    {
        Floats::filter(1.0, false, null, 0.0);
    }

    /**
     * @test
     * @covers ::filter
     */
    public function filterEqualToMax()
    {
        $this->assertSame(0.0, Floats::filter(0.0, false, null, 0.0));
    }

    /**
     * @test
     * @covers ::filter
     */
    public function filterCastInts()
    {
        $this->assertSame(1.0, Floats::filter(1, false, null, null, true));
    }

    /**
     * @test
     * @covers ::filter
     * @expectedException \TraderInteractive\Filter\Exception
     * @expectedExceptionMessage "1" $value is not a string
     */
    public function filterCastIntsIsFalse()
    {
        Floats::filter(1, false, null, null, false);
    }
}


1			<?php
2
3			namespace TraderInteractive\Filter;
4
5			use PHPUnit\Framework\TestCase;
6
7			/**
8			* @coversDefaultClass \TraderInteractive\Filter\Floats
9			*/
10			final class FloatsTest extends TestCase
11			{
12			/**
13			* @test
14			* @covers ::filter
15			*/
16			public function filterAllowNullIsTrueAndNullValue()
17			{
18			$this->assertNull(Floats::filter(null, true));
19			}
20
21			/**
22			* @test
23			* @covers ::filter
24			*/
25			public function filterPositiveFloat()
26			{
27			$this->assertSame(123.0, Floats::filter(123.0));
28			}
29
30			/**
31			* @test
32			* @covers ::filter
33			*/
34			public function filterNegativeFloat()
35			{
36			$this->assertSame(-123.0, Floats::filter(-123.0));
37			}
38
39			/**
40			* @test
41			* @covers ::filter
42			*/
43			public function filterZeroFloat()
44			{
45			$positiveZero = + 0.0;
46			$this->assertSame(0.0, Floats::filter($positiveZero));
47			$this->assertSame(-0.0, Floats::filter(-0.0));
48			}
49
50			/**
51			* @test
52			* @covers ::filter
53			*/
54			public function filterPositiveString()
55			{
56			$this->assertSame(123.0, Floats::filter(' 123 '));
57			$this->assertSame(123.0, Floats::filter(' +123 '));
58			$this->assertSame(123.0, Floats::filter(' 123.0 '));
59			$this->assertSame(123.0, Floats::filter(' 123E0 '));
60			$this->assertSame(123.0, Floats::filter(' +123e0 '));
61			$this->assertSame(123.0, Floats::filter(' +1230e-1 '));
62			$this->assertSame(1230.0, Floats::filter(' +123e+1 '));
63			$this->assertSame(0.0, Floats::filter(' +0 '));
64			$this->assertSame(0.0, Floats::filter(' +0.0 '));
65			$this->assertSame(0.0, Floats::filter(' 0E0 '));
66			$this->assertSame(0.0, Floats::filter(' 00e-1 '));
67			$this->assertSame(0.0, Floats::filter(' 00e+1 '));
68			}
69
70			/**
71			* @test
72			* @covers ::filter
73			*/
74			public function filterNegativeString()
75			{
76			$this->assertSame(-123.0, Floats::filter(' -123 '));
77			$this->assertSame(-123.0, Floats::filter(' -123.0 '));
78			$this->assertSame(-123.0, Floats::filter(' -123E0 '));
79			$this->assertSame(-123.0, Floats::filter(' -1230E-1 '));
80			$this->assertSame(-1230.0, Floats::filter(' -123e+1 '));
81			$this->assertSame(-0.0, Floats::filter(' -0 '));
82			$this->assertSame(-0.0, Floats::filter(' -0.0 '));
83			$this->assertSame(-0.0, Floats::filter(' -0e0 '));
84			$this->assertSame(-0.0, Floats::filter(' -00e-1 '));
85			$this->assertSame(-0.0, Floats::filter(' -0e+1 '));
86			}
87
88			/**
89			* @test
90			* @covers ::filter
91			* @expectedException \TraderInteractive\Filter\Exception
92			* @expectedExceptionMessage "true" $value is not a string
93			*/
94			public function filterNonStringOrFloat()
95			{
96			Floats::filter(true);
			0 ignored issues – show Documentation introduced 2018-03-02 20:25 UTC by Report Bug Copy Issue Report `true` is of type `boolean`, but the function expects a `string\|double`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
97			}
98
99			/**
100			* @test
101			* @covers ::filter
102			* @expectedException \TraderInteractive\Filter\Exception
103			* @exceptedExceptionMessage does not pass is_numeric
104			*/
105			public function filterEmptyString()
106			{
107			Floats::filter('');
108			}
109
110			/**
111			* @test
112			* @covers ::filter
113			* @expectedException \TraderInteractive\Filter\Exception
114			* @expectedExceptionMessage does not pass is_numeric
115			*/
116			public function filterWhitespaceString()
117			{
118			Floats::filter(' ');
119			}
120
121			/**
122			* @test
123			* @covers ::filter
124			* @expectedException \TraderInteractive\Filter\Exception
125			* @expectedExceptionMessage 123-4 does not pass is_numeric
126			*/
127			public function filterNonDigitString()
128			{
129			Floats::filter('123-4');
130			}
131
132			/**
133			* @test
134			* @covers ::filter
135			* @expectedException \TraderInteractive\Filter\Exception
136			*/
137			public function filterHexString()
138			{
139			Floats::filter('0xFF');
140			}
141
142			/**
143			* @test
144			* @covers ::filter
145			* @expectedException \TraderInteractive\Filter\Exception
146			* @expectedExceptionMessage 1. 0 does not pass is_numeric
147			*/
148			public function filterRogueSpaceStringAfterPeriod()
149			{
150			Floats::filter('1. 0');
151			}
152
153			/**
154			* @test
155			* @covers ::filter
156			* @expectedException \TraderInteractive\Filter\Exception
157			* @expectedExceptionMessage 1 0 does not pass is_numeric
158			*/
159			public function filterRogueSpaceStringBetweenDigits()
160			{
161			Floats::filter('1 0');
162			}
163
164			/**
165			* @test
166			* @covers ::filter
167			* @expectedException \TraderInteractive\Filter\Exception
168			* @expectedExceptionMessage 1e999999999999 overflow
169			*/
170			public function filterOverflow()
171			{
172			Floats::filter('1e999999999999');
173			}
174
175			/**
176			* @test
177			* @covers ::filter
178			* @expectedException \TraderInteractive\Filter\Exception
179			* @expectedExceptionMessage -1e999999999999 overflow
180			*/
181			public function filterUnderflow()
182			{
183			Floats::filter('-1e999999999999');
184			}
185
186			/**
187			* @test
188			* @covers ::filter
189			* @expectedException \TraderInteractive\Filter\Exception
190			* @expectedExceptionMessage -1 is less than 0
191			*/
192			public function filterLessThanMin()
193			{
194			Floats::filter(-1.0, false, 0.0);
195			}
196
197			/**
198			* @test
199			* @covers ::filter
200			*/
201			public function filterEqualToMin()
202			{
203			$this->assertSame(0.0, Floats::filter(0.0, false, 0.0));
204			}
205
206			/**
207			* @test
208			* @covers ::filter
209			* @expectedException \TraderInteractive\Filter\Exception
210			* @expectedExceptionMessage 1 is greater than 0
211			*/
212			public function filterGreaterThanMax()
213			{
214			Floats::filter(1.0, false, null, 0.0);
215			}
216
217			/**
218			* @test
219			* @covers ::filter
220			*/
221			public function filterEqualToMax()
222			{
223			$this->assertSame(0.0, Floats::filter(0.0, false, null, 0.0));
224			}
225
226			/**
227			* @test
228			* @covers ::filter
229			*/
230			public function filterCastInts()
231			{
232			$this->assertSame(1.0, Floats::filter(1, false, null, null, true));
233			}
234
235			/**
236			* @test
237			* @covers ::filter
238			* @expectedException \TraderInteractive\Filter\Exception
239			* @expectedExceptionMessage "1" $value is not a string
240			*/
241			public function filterCastIntsIsFalse()
242			{
243			Floats::filter(1, false, null, null, false);
244			}
245			}
246

traderinteractive / filter-php

Pull Request — master (#75)

FloatsTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

21 Methods

Duplication Side-by-Side

Filter issues like