DateTime::filter() - Code Metrics - Inspection of "[WIP] Version 3.0" - traderinteractive/filter-php - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#75)

unknown

created 2018-03-02 20:21 UTC

DateTime::filter() C

↳ Parent: DateTime

Complexity

Conditions	10
Paths	7

Size

Total Lines	24
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	24
rs	5.2164
c	0
b	0
f	0
cc	10
eloc	12
nc	7
nop	3

How to fix Complexity

<?php
namespace TraderInteractive\Filter;

/**
 * A collection of filters for filtering strings into \DateTime objects.
 */
class DateTime
{
    /**
     * Filters the given value into a \DateTime object.
     *
     * @param mixed         $value     The value to be filtered.
     * @param boolean       $allowNull True to allow nulls through, and false (default) if nulls should not be allowed.
     * @param \DateTimeZone $timezone  A \DateTimeZone object representing the timezone of $value.
     *                                 If $timezone is omitted, the current timezone will be used.
     *
     * @return \DateTime
     *
     * @throws \InvalidArgumentException Thrown if $allowNull was not a boolean value.
     * @throws Exception if the value did not pass validation.
     */
    public static function filter($value, $allowNull = false, \DateTimeZone $timezone = null)
    {
        if ($allowNull !== false && $allowNull !== true) {
            throw new \InvalidArgumentException('$allowNull was not a boolean value');
        }

        if ($value === null && $allowNull) {
            return null;
        }

        if ($value instanceof \DateTime) {
            return $value;
        }

        if (is_int($value) || ctype_digit($value)) {
            $value = "@{$value}";
        }

        if (!is_string($value) || trim($value) == '') {
            throw new Exception('$value is not a non-empty string');
        }

        return new \DateTime($value, $timezone);
    }

    /**
     * Filters the give \DateTime object to a formatted string.
     *
     * @param \DateTimeInterface $dateTime The date to be formatted.
     * @param string             $format   The format of the outputted date string.
     *
     * @return string
     *
     * @throws \InvalidArgumentException Thrown if $format is not a string
     */
    public static function format(\DateTimeInterface $dateTime, $format = 'c')
    {
        if (!is_string($format) || trim($format) === '') {
            throw new \InvalidArgumentException('$format is not a non-empty string');
        }

        return $dateTime->format($format);
    }
}


1			<?php
2			namespace TraderInteractive\Filter;
3
4			/**
5			* A collection of filters for filtering strings into \DateTime objects.
6			*/
7			class DateTime
8			{
9			/**
10			* Filters the given value into a \DateTime object.
11			*
12			* @param mixed $value The value to be filtered.
13			* @param boolean $allowNull True to allow nulls through, and false (default) if nulls should not be allowed.
14			* @param \DateTimeZone $timezone A \DateTimeZone object representing the timezone of $value.
15			* If $timezone is omitted, the current timezone will be used.
16			*
17			* @return \DateTime
18			*
19			* @throws \InvalidArgumentException Thrown if $allowNull was not a boolean value.
20			* @throws Exception if the value did not pass validation.
21			*/
22			public static function filter($value, $allowNull = false, \DateTimeZone $timezone = null)
23			{
24			if ($allowNull !== false && $allowNull !== true) {
25			throw new \InvalidArgumentException('$allowNull was not a boolean value');
26			}
27
28			if ($value === null && $allowNull) {
29			return null;
30			}
31
32			if ($value instanceof \DateTime) {
33			return $value;
34			}
35
36			if (is_int($value) \|\| ctype_digit($value)) {
37			$value = "@{$value}";
38			}
39
40			if (!is_string($value) \|\| trim($value) == '') {
41			throw new Exception('$value is not a non-empty string');
42			}
43
44			return new \DateTime($value, $timezone);
45			}
46
47			/**
48			* Filters the give \DateTime object to a formatted string.
49			*
50			* @param \DateTimeInterface $dateTime The date to be formatted.
51			* @param string $format The format of the outputted date string.
52			*
53			* @return string
54			*
55			* @throws \InvalidArgumentException Thrown if $format is not a string
56			*/
57			public static function format(\DateTimeInterface $dateTime, $format = 'c')
58			{
59			if (!is_string($format) \|\| trim($format) === '') {
60			throw new \InvalidArgumentException('$format is not a non-empty string');
61			}
62
63			return $dateTime->format($format);
64			}
65			}
66

traderinteractive / filter-php

Pull Request — master (#75)

DateTime::filter() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like