Floats::filter() - Code Metrics - Inspection of "[WIP] Version 3" - traderinteractive/filter-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#76)

by Chad

created 2018-03-06 20:33 UTC

Floats::filter() C

↳ Parent: Floats

Complexity

Conditions	14
Paths	16

Size

Total Lines	49
Code Lines	30

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	49
rs	5.1329
c	0
b	0
f	0
cc	14
eloc	30
nc	16
nop	5

How to fix Complexity

<?php

namespace TraderInteractive\Filter;

/**
 * A collection of filters for floats.
 */
final class Floats
{
    /**
     * Filters $value to a float strictly.
     *
     * The return value is the float, as expected by the \TraderInteractive\Filterer class.
     *
     * @param string|float $value     the value to filter to a float
     * @param bool         $allowNull Set to true if NULL values are allowed. The filtered result of a NULL value is
     *                                NULL
     * @param float        $minValue  The minimum acceptable value
     * @param float        $maxValue  The maximum acceptable value
     * @param bool         $castInts  Flag to cast $value to float if it is an integer
     *
     * @return float|null The filtered value
     *
     * @throws Exception if $value is greater than $maxValue
     * @see is_numeric
     */
    public static function filter(
        $value,
        bool $allowNull = false,
        float $minValue = null,
        float $maxValue = null,
        bool $castInts = false
    ) {
        if ($allowNull === true && $value === null) {
            return null;
        }

        $valueFloat = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if (is_float($value)) {
            $valueFloat = $value;
        } elseif (is_int($value) && $castInts) {
            $valueFloat = (float)$value;
        } elseif (is_string($value)) {
            $value = trim($value);

            if (!is_numeric($value)) {
                throw new Exception("{$value} does not pass is_numeric");
            }

            $value = strtolower($value);

            //This is the only case (that we know of) where is_numeric does not return correctly cast-able float
            if (strpos($value, 'x') !== false) {
                throw new Exception("{$value} is hex format");
            }

            $valueFloat = (float)$value;
        } else {
            throw new Exception('"' . var_export($value, true) . '" $value is not a string');
        }

        if (is_infinite($valueFloat)) {
            throw new Exception("{$value} overflow");
        }

        if ($minValue !== null && $valueFloat < $minValue) {
            throw new Exception("{$valueFloat} is less than {$minValue}");
        }

        if ($maxValue !== null && $valueFloat > $maxValue) {
            throw new Exception("{$valueFloat} is greater than {$maxValue}");
        }

        return $valueFloat;
    }
}


1			<?php
2
3			namespace TraderInteractive\Filter;
4
5			/**
6			* A collection of filters for floats.
7			*/
8			final class Floats
9			{
10			/**
11			* Filters $value to a float strictly.
12			*
13			* The return value is the float, as expected by the \TraderInteractive\Filterer class.
14			*
15			* @param string\|float $value the value to filter to a float
16			* @param bool $allowNull Set to true if NULL values are allowed. The filtered result of a NULL value is
17			* NULL
18			* @param float $minValue The minimum acceptable value
19			* @param float $maxValue The maximum acceptable value
20			* @param bool $castInts Flag to cast $value to float if it is an integer
21			*
22			* @return float\|null The filtered value
23			*
24			* @throws Exception if $value is greater than $maxValue
25			* @see is_numeric
26			*/
27			public static function filter(
28			$value,
29			bool $allowNull = false,
30			float $minValue = null,
31			float $maxValue = null,
32			bool $castInts = false
33			) {
34			if ($allowNull === true && $value === null) {
35			return null;
36			}
37
38			$valueFloat = null;
			0 ignored issues – show Unused Code introduced 2017-12-13 16:49 UTC by Report Bug Copy Issue Report `$valueFloat` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
39			if (is_float($value)) {
40			$valueFloat = $value;
41			} elseif (is_int($value) && $castInts) {
42			$valueFloat = (float)$value;
43			} elseif (is_string($value)) {
44			$value = trim($value);
45
46			if (!is_numeric($value)) {
47			throw new Exception("{$value} does not pass is_numeric");
48			}
49
50			$value = strtolower($value);
51
52			//This is the only case (that we know of) where is_numeric does not return correctly cast-able float
53			if (strpos($value, 'x') !== false) {
54			throw new Exception("{$value} is hex format");
55			}
56
57			$valueFloat = (float)$value;
58			} else {
59			throw new Exception('"' . var_export($value, true) . '" $value is not a string');
60			}
61
62			if (is_infinite($valueFloat)) {
63			throw new Exception("{$value} overflow");
64			}
65
66			if ($minValue !== null && $valueFloat < $minValue) {
67			throw new Exception("{$valueFloat} is less than {$minValue}");
68			}
69
70			if ($maxValue !== null && $valueFloat > $maxValue) {
71			throw new Exception("{$valueFloat} is greater than {$maxValue}");
72			}
73
74			return $valueFloat;
75			}
76			}
77

traderinteractive / filter-php

Pull Request — master (#76)

Floats::filter() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like