IntsTest::nonDigitString() - Code Metrics - Inspection of "[WIP] Version 3.0" - traderinteractive/filter-ints-php - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#1)

unknown

created 2018-03-06 21:59 UTC

IntsTest::nonDigitString() A

↳ Parent: IntsTest

Complexity

Conditions	2
Paths	3

Size

Total Lines	10
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	8
nc	3
nop	0
dl	0
loc	10
rs	9.4285
c	0
b	0
f	0

<?php

namespace TraderInteractive\Filter;

use PHPUnit\Framework\TestCase;

/**
 * @coversDefaultClass \TraderInteractive\Filter\Ints
 * @covers ::<private>
 */
final class IntsTest extends TestCase
{
    /**
     * @test
     * @covers ::filter
     */
    public function filterAllowNullIsTrueAndNullValue()
    {
        $result = Ints::filter(null, true);
        $this->assertSame(null, $result);
    }

    /**
     * @test
     * @covers ::filter
     */
    public function filterPositiveInt()
    {
        $this->assertSame(123, Ints::filter(123));
    }

    /**
     * @test
     * @covers ::filter
     */
    public function filterNegativeInt()
    {
        $this->assertSame(-123, Ints::filter(-123));
    }

    /**
     * @test
     * @covers ::filter
     */
    public function filterZeroInt()
    {
        $positiveZero = + 0;
        $this->assertSame(0, Ints::filter($positiveZero));
        $this->assertSame(0, Ints::filter(-0));
    }

    /**
     * @test
     * @covers ::filter
     */
    public function filterPositiveString()
    {
        $this->assertSame(123, Ints::filter('   123 '));
        $this->assertSame(123, Ints::filter('   +123 '));
        $this->assertSame(0, Ints::filter('   +0 '));
    }

    /**
     * @test
     * @covers ::filter
     */
    public function filterNegativeString()
    {
        $this->assertSame(-123, Ints::filter('   -123 '));
        $this->assertSame(0, Ints::filter('   -0 '));
    }

    /**
     * @test
     * @covers ::filter
     * @expectedException \TraderInteractive\Exceptions\FilterException
     * @expectedExceptionMessage "true" $value is not a string
     */
    public function filterNonStringOrInt()
    {
        Ints::filter(true);
        Ints::filter(/** @scrutinizer ignore-type */ true);
    }

    /**
     * @test
     * @covers ::filter
     * @expectedException \TraderInteractive\Exceptions\FilterException
     * @expectedExceptionMessage $value string length is zero
     */
    public function filterEmptyString()
    {
        Ints::filter('');
    }

    /**
     * @test
     * @covers ::filter
     * @expectedException \TraderInteractive\Exceptions\FilterException
     * @expectedExceptionMessage $value string length is zero
     */
    public function filterWhitespaceString()
    {
        Ints::filter('   ');
    }

    /**
     * @test
     * @covers ::filter
     */
    public function nonDigitString()
    {
        try {
            Ints::filter('123.4');
            $this->fail("No exception thrown");
        } catch (\Throwable $e) {
            $this->assertSame(
                "123.4 does not contain all digits, optionally prepended by a '+' or '-' and optionally surrounded by "
                . "whitespace",
                $e->getMessage()
            );
        }
    }

    /**
     * @test
     * @covers ::filter
     * @expectedException \TraderInteractive\Exceptions\FilterException
     */
    public function filterGreaterThanPhpIntMax()
    {
        //32, 64 and 128 bit and their +1 's
        $maxes = [
            '2147483647' => '2147483648',
            '9223372036854775807' => '9223372036854775808',
            '170141183460469231731687303715884105727' => '170141183460469231731687303715884105728',
        ];
        $oneOverMax = $maxes[(string)PHP_INT_MAX];
        Ints::filter($oneOverMax);
    }

    /**
     * @test
     * @covers ::filter
     * @expectedException \TraderInteractive\Exceptions\FilterException
     */
    public function filterLessThanPhpIntMin()
    {
        //32, 64 and 128 bit and their -1 's
        $mins = [
            '-2147483648' => '-2147483649',
            '-9223372036854775808' => '-9223372036854775809',
            '-170141183460469231731687303715884105728' => '-170141183460469231731687303715884105729',
        ];
        $oneUnderMin = $mins[(string)~PHP_INT_MAX];
        Ints::filter($oneUnderMin);
    }

    /**
     * @test
     * @covers ::filter
     * @expectedException \TraderInteractive\Exceptions\FilterException
     * @expectedExceptionMessage -1 is less than 0
     */
    public function filterLessThanMin()
    {
        Ints::filter(-1, false, 0);
    }

    /**
     * @test
     * @covers ::filter
     */
    public function filterEqualToMin()
    {
        $this->assertSame(0, Ints::filter(0, false, 0));
    }

    /**
     * @test
     * @covers ::filter
     * @expectedException \TraderInteractive\Exceptions\FilterException
     * @expectedExceptionMessage 1 is greater than 0
     */
    public function filterGreaterThanMax()
    {
        Ints::filter(1, false, null, 0);
    }

    /**
     * @test
     * @covers ::filter
     */
    public function filterEqualToMax()
    {
        $this->assertSame(0, Ints::filter(0, false, null, 0));
    }
}


traderinteractive / filter-ints-php

Pull Request — master (#1)

IntsTest::nonDigitString() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like