PageController::getPage() - Code Metrics - Inspection of "Merge branch 'release/v0.4.1'" - torralbodavid/duck-funk-core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( bcfc51...2533f4 )

by David

created 2020-04-26 19:22 UTC

PageController::getPage() A

↳ Parent: PageController::__invoke()

Complexity

Conditions	4
Paths	6

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
nc	6
nop	1
dl	0
loc	22
rs	9.568
c	0
b	0
f	0

<?php

namespace Torralbodavid\DuckFunkCore\Http\Controllers;

use Illuminate\Http\Request;

class PageController
{
    public function __invoke(Request $request)
    {
        $page = $request->page;

        $packageController = package_namespace().'\Http\Controllers\Pages\\'.ucfirst($page->slug).'Controller';
        $projectController = 'App\Http\Controllers\Pages\\'.ucfirst($page->slug).'Controller';

        $controller = class_exists($projectController)
            ? $projectController
            : $packageController;

        if (! view()->exists("duck-funk-core::{$page->slug}") && ! class_exists($controller)) {
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            return abort(404);
        }

        if (! class_exists($controller)) {
            return abort(404);
        }

        if (view()->exists("duck-funk-core::{$page->slug}")) {
            $response = view("duck-funk-core::{$page->slug}")->with('page', $page);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        }

        $action = new $controller();

        return method_exists($action, 'index')
            ? $action->index($page)
            : $response;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }
}


Push — master ( bcfc51...2533f4 )

PageController::getPage() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			namespace Torralbodavid\DuckFunkCore\Http\Controllers;
4
5			use Illuminate\Http\Request;
6
7			class PageController
8			{
9			public function __invoke(Request $request)
10			{
11			$page = $request->page;
12
13			$packageController = package_namespace().'\Http\Controllers\Pages\\'.ucfirst($page->slug).'Controller';
14			$projectController = 'App\Http\Controllers\Pages\\'.ucfirst($page->slug).'Controller';
15
16			$controller = class_exists($projectController)
17			? $projectController
18			: $packageController;
19
20			if (! view()->exists("duck-funk-core::{$page->slug}") && ! class_exists($controller)) {
			0 ignored issues – show Bug introduced 2020-04-26 19:24 UTC by Report Bug Copy Issue Report The method `exists` does only exist in `Illuminate\Contracts\View\Factory`, but not in `Illuminate\View\View`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
21			return abort(404);
22			}
23
24			if (! class_exists($controller)) {
25			return abort(404);
26			}
27
28			if (view()->exists("duck-funk-core::{$page->slug}")) {
29			$response = view("duck-funk-core::{$page->slug}")->with('page', $page);
			0 ignored issues – show Bug introduced 2020-04-26 09:45 UTC by Report Bug Copy Issue Report The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
30			}
31
32			$action = new $controller();
33
34			return method_exists($action, 'index')
35			? $action->index($page)
36			: $response;
			0 ignored issues – show Bug introduced 2020-04-26 19:24 UTC by Report Bug Copy Issue Report The variable `$response` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
37			}
38			}
39

torralbodavid / duck-funk-core

Push — master ( bcfc51...2533f4 )

PageController::getPage() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like