PageController::store() - Code Metrics - torralbodavid/duck-funk-core - Measure and Improve Code Quality continuously with Scrutinizer

PageController::store() A
last analyzed 2020-05-01 10:31 UTC

↳ Parent: PageController

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
nc	2
nop	1
dl	0
loc	27
rs	9.488
c	0
b	0
f	0

<?php

namespace Torralbodavid\DuckFunkCore\Http\Controllers\Housekeeping;

use Illuminate\Http\Request;
use Illuminate\Routing\Controller;
use Torralbodavid\DuckFunkCore\Http\Request\Housekeeping\News\NewsStoreRequest;
use Torralbodavid\DuckFunkCore\Http\Resources\Marketing\NewsResource;
use Torralbodavid\DuckFunkCore\Models\Arcturus\Permissions;
use Torralbodavid\DuckFunkCore\Models\CMS\Page;
use Torralbodavid\DuckFunkCore\Models\Housekeeping\News;

class PageController extends Controller
{
    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index()
    {
        //
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        $data = [
            'permissions' => Permissions::all(),
            'pages' => Page::where('active', true)->get(),
        ];

        return response()->view('housekeeping::pages.edit', $data, 200);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param NewsStoreRequest $request
     * @return \Illuminate\Http\JsonResponse
     */
    public function store(NewsStoreRequest $request)
    {
        $validated = $request->validated();

        $news = Page::firstOrCreate(
            [
                'slug' => $validated['slug'],
                'route' => $validated['route'],
            ]);

        $news->categories = $validated['allCategories'];
        $news->draft = 0;

        try {
            $news->saveOrFail();
        } catch (\Throwable $e) {
            return response()->json([
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
                'message' => "Ha sucedido un error {$e->getMessage()}",
                'error' => true,
            ]);
        }

        return response()->json([
            'message' => 'Página publicada correctamente',
            'error' => false,
        ]);
    }

    /**
     * Display the specified resource.
     *
     * @param int $id
     * @return \Illuminate\Http\Response
     */
    public function show($id)

    {
        //
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param News $news
     * @return \Illuminate\Http\Response
     */
    public function edit(News $news)
    {
        $data = [
            'news' => new NewsResource($news),
        ];

        return view('housekeeping::pages.edit', $data);
    }

    /**
     * Update the specified resource in storage.
     *
     * @param \Illuminate\Http\Request $request
     * @param int $id
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)

    {
        //
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param int $id
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)

    {
        //
    }
}


1			<?php
2
3			namespace Torralbodavid\DuckFunkCore\Http\Controllers\Housekeeping;
4
5			use Illuminate\Http\Request;
6			use Illuminate\Routing\Controller;
7			use Torralbodavid\DuckFunkCore\Http\Request\Housekeeping\News\NewsStoreRequest;
8			use Torralbodavid\DuckFunkCore\Http\Resources\Marketing\NewsResource;
9			use Torralbodavid\DuckFunkCore\Models\Arcturus\Permissions;
10			use Torralbodavid\DuckFunkCore\Models\CMS\Page;
11			use Torralbodavid\DuckFunkCore\Models\Housekeeping\News;
12
13			class PageController extends Controller
14			{
15			/**
16			* Display a listing of the resource.
17			*
18			* @return \Illuminate\Http\Response
19			*/
20			public function index()
21			{
22			//
23			}
24
25			/**
26			* Show the form for creating a new resource.
27			*
28			* @return \Illuminate\Http\Response
29			*/
30			public function create()
31			{
32			$data = [
33			'permissions' => Permissions::all(),
34			'pages' => Page::where('active', true)->get(),
35			];
36
37			return response()->view('housekeeping::pages.edit', $data, 200);
			0 ignored issues – show Bug introduced 2020-04-26 09:45 UTC by Report Bug Copy Issue Report The method `view` does only exist in `Illuminate\Contracts\Routing\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
38			}
39
40			/**
41			* Store a newly created resource in storage.
42			*
43			* @param NewsStoreRequest $request
44			* @return \Illuminate\Http\JsonResponse
45			*/
46			public function store(NewsStoreRequest $request)
47			{
48			$validated = $request->validated();
49
50			$news = Page::firstOrCreate(
51			[
52			'slug' => $validated['slug'],
53			'route' => $validated['route'],
54			]);
55
56			$news->categories = $validated['allCategories'];
57			$news->draft = 0;
58
59			try {
60			$news->saveOrFail();
61			} catch (\Throwable $e) {
62			return response()->json([
			0 ignored issues – show Bug introduced 2020-04-26 09:45 UTC by Report Bug Copy Issue Report The method `json` does only exist in `Illuminate\Contracts\Routing\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
63			'message' => "Ha sucedido un error {$e->getMessage()}",
64			'error' => true,
65			]);
66			}
67
68			return response()->json([
69			'message' => 'Página publicada correctamente',
70			'error' => false,
71			]);
72			}
73
74			/**
75			* Display the specified resource.
76			*
77			* @param int $id
78			* @return \Illuminate\Http\Response
79			*/
80			public function show($id)
			0 ignored issues – show Unused Code introduced 2020-04-26 09:45 UTC by Report Bug Copy Issue Report The parameter `$id` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
81			{
82			//
83			}
84
85			/**
86			* Show the form for editing the specified resource.
87			*
88			* @param News $news
89			* @return \Illuminate\Http\Response
90			*/
91			public function edit(News $news)
92			{
93			$data = [
94			'news' => new NewsResource($news),
95			];
96
97			return view('housekeeping::pages.edit', $data);
98			}
99
100			/**
101			* Update the specified resource in storage.
102			*
103			* @param \Illuminate\Http\Request $request
104			* @param int $id
105			* @return \Illuminate\Http\Response
106			*/
107			public function update(Request $request, $id)
			0 ignored issues – show Unused Code introduced 2020-04-26 09:45 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2020-04-26 09:45 UTC by Report Bug Copy Issue Report The parameter `$id` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
108			{
109			//
110			}
111
112			/**
113			* Remove the specified resource from storage.
114			*
115			* @param int $id
116			* @return \Illuminate\Http\Response
117			*/
118			public function destroy($id)
			0 ignored issues – show Unused Code introduced 2020-04-26 09:45 UTC by Report Bug Copy Issue Report The parameter `$id` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
119			{
120			//
121			}
122			}
123

torralbodavid / duck-funk-core

PageController::store() A last analyzed 2020-05-01 10:31 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

PageController::store() A
last analyzed 2020-05-01 10:31 UTC