UserSave::render() - Code Metrics - torralbodavid/duck-funk-core - Measure and Improve Code Quality continuously with Scrutinizer

UserSave::render() A
last analyzed 2020-05-01 10:31 UTC

↳ Parent: UserSave

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
nc	2
nop	0
dl	0
loc	22
rs	9.568
c	0
b	0
f	0

<?php

namespace Torralbodavid\DuckFunkCore\Exceptions\Welcome;

use Exception;
use Illuminate\Contracts\Validation\Validator;

class UserSave extends Exception
{
    protected $validator;

    protected $code = 422;

    public function __construct(Validator $validator)
    {
        $this->validator = $validator;
    }

    public function render()
    {
        if ($this->validator->errors()->first() == 'validation.in') {
            return response()->json([
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
                'code' => 'INVALID_GENDER',
                'validationResult' => [
                    'resultType' => 'INVALID_GENDER',
                    'valid' => false,
                ],
            ]);
        }

        return response()->json([
            'code' => 'INVALID_NAME',
            'validationResult' => [
                'resultType' => 'VALIDATION_ERROR_UNKNOWN',
                'additionalInfo' => null,
                'valid' => false,
            ],
            'suggestions' => [],
        ]);
    }
}


1			<?php
2
3			namespace Torralbodavid\DuckFunkCore\Exceptions\Welcome;
4
5			use Exception;
6			use Illuminate\Contracts\Validation\Validator;
7
8			class UserSave extends Exception
9			{
10			protected $validator;
11
12			protected $code = 422;
13
14			public function __construct(Validator $validator)
15			{
16			$this->validator = $validator;
17			}
18
19			public function render()
20			{
21			if ($this->validator->errors()->first() == 'validation.in') {
22			return response()->json([
			0 ignored issues – show Bug introduced 2020-02-20 22:09 UTC by Report Bug Copy Issue Report The method `json` does only exist in `Illuminate\Contracts\Routing\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
23			'code' => 'INVALID_GENDER',
24			'validationResult' => [
25			'resultType' => 'INVALID_GENDER',
26			'valid' => false,
27			],
28			]);
29			}
30
31			return response()->json([
32			'code' => 'INVALID_NAME',
33			'validationResult' => [
34			'resultType' => 'VALIDATION_ERROR_UNKNOWN',
35			'additionalInfo' => null,
36			'valid' => false,
37			],
38			'suggestions' => [],
39			]);
40			}
41			}
42

torralbodavid / duck-funk-core

UserSave::render() A last analyzed 2020-05-01 10:31 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

UserSave::render() A
last analyzed 2020-05-01 10:31 UTC