Toplan\PhpSms\SmsBaoAgent

Complexity

Total Complexity

6

Size/Duplication

Total Lines	58
Duplicated Lines	41.38 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	sendSms()	0	4	1
A	sendContentSms()	12	12	1
A	voiceVerify()	12	12	1
A	setResult()	0	12	3

<?php

namespace Toplan\PhpSms;

/**
 * Class SmsBaoAgent
 *
 * @property string $username
 * @property string $password
 */
class SmsBaoAgent extends Agent implements ContentSms
{
    protected $resultArr = [
        '0'  => '发送成功',
        '-1' => '参数不全',
        '30' => '密码错误',
        '40' => '账号不存在',
        '41' => '余额不足',
        '42' => '帐户已过期',
        '43' => 'IP地址限制',
        '50' => '内容含有敏感词',
        '51' => '手机号码不正确',
    ];

    public function sendSms($to, $content, $tempId, array $data)
    {
        $this->sendContentSms($to, $content);
    }

    public function sendContentSms($to, $content)

This method seems to be duplicated in your project.

    {
        $url = 'http://api.smsbao.com/sms';
        $params = [
            'u' => $this->username,
            'p' => md5($this->password),
            'm' => $to,
            'c' => $content,
        ];
        $result = $this->curl($url, $params);
        $this->setResult($result);
    }

    public function voiceVerify($to, $code, $tempId, array $tempData)

This method seems to be duplicated in your project.

    {
        $url = 'http://api.smsbao.com/voice';
        $params = [
            'u' => $this->username,
            'p' => md5($this->password),
            'm' => $to,
            'c' => $code,
        ];
        $result = $this->curl($url, $params);
        $this->setResult($result);
    }

    protected function setResult($result)
    {
        if ($result['request']) {
            $result = $result['response'];
            $msg = array_key_exists($result, $this->resultArr) ? $this->resultArr[$result] : 'unknown error';
            $this->result(Agent::INFO, json_encode(['code' => $result, 'msg' => $msg]));
            $this->result(Agent::SUCCESS, $result === '0');
            $this->result(Agent::CODE, $result);
        } else {
            $this->result(Agent::INFO, 'request failed');
        }
    }
}