Toplan\PhpSms\UcpaasAgent

Complexity

Total Complexity

7

Size/Duplication

Total Lines	47
Duplicated Lines	46.81 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	3
Bugs	1	Features	1

5 Methods

Rating	Name	Duplication	Size	Complexity
A	sendSms()	0	4	1
A	sendTemplateSms()	11	11	1
A	voiceVerify()	11	11	1
A	setResult()	0	11	3
A	sendContentSms()	0	3	1

<?php

namespace Toplan\PhpSms;

/**
 * Class UcpaasAgent
 *
 * @property string $accountSid
 * @property string $accountToken
 * @property string $appId
 */
class UcpaasAgent extends Agent
{
    public function sendSms($to, $content, $tempId, array $data)
    {
        $this->sendTemplateSms($to, $tempId, $data);
    }

    public function sendTemplateSms($to, $tempId, array $data)

This method seems to be duplicated in your project.

    {
        $config = [
            'accountsid' => $this->accountSid,
            'token'      => $this->accountToken,
        ];
        $ucpaas = new \Ucpaas($config);
        $response = $ucpaas->templateSMS($this->appId, $to, $tempId, implode(',', $data));
        $result = json_decode($response);
        $this->setResult($result);
    }

    public function voiceVerify($to, $code, $tempId, array $data)

This method seems to be duplicated in your project.

    {
        $config = [
            'accountsid' => $this->accountSid,
            'token'      => $this->accountToken,
        ];
        $ucpass = new \Ucpaas($config);
        $response = $ucpass->voiceCode($this->appId, $code, $to, $type = 'json');
        $result = json_decode($response);
        $this->result($result);
    }

    protected function setResult($result)
    {
        if (empty($result) || !is_object($result)) {
            $this->result(Agent::INFO, '请求失败');

            return;
        }
        $this->result(Agent::SUCCESS, $result->resp->respCode === '000000');
        $this->result(Agent::CODE, $result->resp->respCode);
        $this->result(Agent::INFO, $result->resp->respCode);
    }

    public function sendContentSms($to, $content)
    {
    }
}