Toplan\PhpSms\YunTongXunAgent

Complexity

Total Complexity

11

Size/Duplication

Total Lines	49
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	sendTemplateSms()	0	6	1
A	sendVoiceCode()	0	11	4
A	rest()	0	8	1
B	setResult()	0	18	5

<?php

namespace Toplan\PhpSms;

use REST;

/**
 * Class YunTongXunAgent
 *
 * @property string $serverIP
 * @property string $serverPort
 * @property string $accountSid
 * @property string $accountToken
 * @property string $appId
 * @property int    $playTimes
 * @property string $displayNum
 */
class YunTongXunAgent extends Agent implements TemplateSms, VoiceCode
{
    public function sendTemplateSms($to, $tempId, array $data)
    {
        $data = array_values($data);
        $result = $this->rest()->sendTemplateSMS($to, $data, $tempId);

It seems like $to defined by parameter $to on line 20 can also be of type array; however, REST::sendTemplateSMS() does only seem to accept string, maybe add an additional type check?

        $this->setResult($result);
    }

    public function sendVoiceCode($to, $code)
    {
        $playTimes = intval($this->playTimes ?: 3);
        $displayNum = $this->displayNum ?: null;
        $lang = $this->params('lang') ?: 'zh';
        $respUrl = $this->params('respUrl');
        $userData = $this->params('userData');
        $welcomePrompt = $this->params('welcomePrompt');
        $result = $this->rest()->voiceVerify($code, $playTimes, $to, $displayNum, $respUrl, $lang, $userData, $welcomePrompt);
        $this->setResult($result);
    }

    protected function rest()
    {
        $rest = new REST($this->serverIP, $this->serverPort, '2013-12-26', 'json');
        $rest->setAccount($this->accountSid, $this->accountToken);
        $rest->setAppId($this->appId);

        return $rest;
    }

    protected function setResult($result)
    {
        if (!$result) {
            return;
        }
        $code = $info = (string) $result->statusCode;
        $success = $code === '000000';
        if (isset($result->statusMsg)) {
            $info = (string) $result->statusMsg;
        } elseif (isset($result->TemplateSMS)) {
            $info = 'smsSid:' . $result->TemplateSMS->smsMessageSid;
        } elseif (isset($result->VoiceVerify)) {
            $info = 'callSid:' . $result->VoiceVerify->callSid;
        }
        $this->result(Agent::SUCCESS, $success);
        $this->result(Agent::CODE, $code);
        $this->result(Agent::INFO, $info);
    }
}