think\middleware\SessionInit

Complexity

Total Complexity

6

Size/Duplication

Total Lines	44
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	handle()	0	22	5

<?php
// +----------------------------------------------------------------------

You must use "/**" style comments for a file comment

// | ThinkPHP [ WE CAN DO IT JUST THINK ]
// +----------------------------------------------------------------------
// | Copyright (c) 2006~2019 http://thinkphp.cn All rights reserved.
// +----------------------------------------------------------------------
// | Licensed ( http://www.apache.org/licenses/LICENSE-2.0 )
// +----------------------------------------------------------------------
// | Author: liu21st <liu21st@gmail.com>
// +----------------------------------------------------------------------
declare (strict_types = 1);

namespace think\middleware;

use Closure;
use think\App;
use think\Request;
use think\Session;

class SessionInit

Missing class doc comment

{

    /** @var Session */

The open comment tag must be the only content on the line

Missing short description in doc comment

The close comment tag must be the only content on the line

    protected $session;

    /** @var App */

The open comment tag must be the only content on the line

Missing short description in doc comment

The close comment tag must be the only content on the line

    protected $app;

    public function __construct(App $app, Session $session)

Missing function doc comment

    {
        $this->app     = $app;
        $this->session = $session;
    }

    /**
     * Session初始化
     * @access public
     * @param Request $request

Missing parameter comment

Tag value indented incorrectly; expected 2 spaces but found 1

     * @param Closure $next

Missing parameter comment

Tag value indented incorrectly; expected 2 spaces but found 1

     * @return void
     */
    public function handle($request, Closure $next)
    {
        // Session初始化
        $varSessionId = $this->app->config->get('route.var_session_id');

        if ($varSessionId && $request->request($varSessionId)) {
            $this->session->setId($request->request($varSessionId));

$request->request($varSessionId) of type array|null|object is incompatible with the type string expected by parameter $id of think\Session::setId().

        } else {
            $cookieName = $this->app->config->get('session.cookie_name', 'PHPSESSID');
            $sessionId  = $request->cookie($cookieName) ?: '';

It seems like $cookieName can also be of type array and array; however, parameter $name of think\Request::cookie() does only seem to accept string, maybe add an additional type check?

            $this->session->setId($sessionId);
        }

        $request->withSession($this->session);

        $response = $next($request);

        if (isset($cookieName)) {
            $this->app->cookie->set($cookieName, $this->session->getId());
        }

        return $response;
    }
}