think\Db

Complexity

Total Complexity

7

Size/Duplication

Total Lines	65
Duplicated Lines	0 %

Test Coverage

Coverage

16.66%

Importance

Changes	9
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__make()	0	9	1
A	setEvent()	0	3	1
A	modelMaker()	0	2	1
A	event()	0	4	2
A	trigger()	0	4	2

<?php
// +----------------------------------------------------------------------
// | ThinkPHP [ WE CAN DO IT JUST THINK ]
// +----------------------------------------------------------------------
// | Copyright (c) 2006~2019 http://thinkphp.cn All rights reserved.
// +----------------------------------------------------------------------
// | Licensed ( http://www.apache.org/licenses/LICENSE-2.0 )
// +----------------------------------------------------------------------
// | Author: liu21st <liu21st@gmail.com>
// +----------------------------------------------------------------------
declare (strict_types = 1);

namespace think;

/**
 * 数据库管理类
 * @package think

Package name "think" is not valid; consider "Think" instead

 */
class Db extends DbManager
{
    /**

Missing short description in doc comment

     * @param Event  $event

Missing parameter comment

     * @param Config $config

Missing parameter comment

     * @param Log    $log

Missing parameter comment

     * @param Cache  $cache

Missing parameter comment

     * @return Db
     * @codeCoverageIgnore
     */
    public static function __make(Event $event, Config $config, Log $log, Cache $cache)

Method name "Db::__make" is invalid; only PHP magic methods should be prefixed with a double underscore

Public method name "Db::__make" must not be prefixed with an underscore

    {
        $db = new static();
        $db->setConfig($config->get('database'));

It seems like $config->get('database') can also be of type null; however, parameter $config of think\DbManager::setConfig() does only seem to accept array, maybe add an additional type check?

        $db->setEvent($event);
        $db->setLog($log);

The method setLog() does not exist on think\Db. Since you implemented __call, consider adding a @method annotation.

        $db->setCache($cache);

        return $db;
    }

    /**
     * 注入模型对象
     * @access public
     * @return void
     */
    protected function modelMaker()
    {
    }

    /**
     * 设置Event对象
     * @param Event $event

Missing parameter comment

     */

Missing @return tag in function comment

    public function setEvent(Event $event)
    {
        $this->event = $event;

It seems like $event of type think\Event is incompatible with the declared type array of property $event.

    }

    /**
     * 注册回调方法
     * @access public
     * @param string   $event    事件名
     * @param callable $callback 回调方法
     * @return void
     */
    public function event(string $event, callable $callback): void
    {
        if ($this->event) {

The expression $this->event of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $this->event->listen('db.' . $event, $callback);
        }
    }

    /**
     * 触发事件
     * @access public
     * @param string $event  事件名
     * @param mixed  $params 传入参数
     * @param bool   $once

Missing parameter comment

     * @return mixed
     */
    public function trigger(string $event, $params = null, bool $once = false)
    {
        if ($this->event) {

The expression $this->event of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            return $this->event->trigger('db.' . $event, $params, $once);
        }
    }
}