think\middleware\CheckRequestCache

Complexity

Total Complexity

8

Size/Duplication

Total Lines	47
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
B	handle()	0	31	7

<?php
// +----------------------------------------------------------------------

You must use "/**" style comments for a file comment

// | ThinkPHP [ WE CAN DO IT JUST THINK ]
// +----------------------------------------------------------------------
// | Copyright (c) 2006~2019 http://thinkphp.cn All rights reserved.
// +----------------------------------------------------------------------
// | Licensed ( http://www.apache.org/licenses/LICENSE-2.0 )
// +----------------------------------------------------------------------
// | Author: liu21st <liu21st@gmail.com>
// +----------------------------------------------------------------------
declare (strict_types = 1);

namespace think\middleware;

use Closure;
use think\Cache;
use think\Request;
use think\Response;

class CheckRequestCache

Missing doc comment for class CheckRequestCache

{
    protected $cache;

    public function __construct(Cache $cache)

Missing doc comment for function __construct()

    {
        $this->cache = $cache;
    }

    /**

Parameter $next should have a doc-comment as per coding-style.

     * 设置当前地址的请求缓存
     * @access public
     * @param Request $request

Missing parameter comment

Tag value for @param tag indented incorrectly; expected 2 spaces but found 1

     * @param         $next

Missing parameter name

Tag value for @param tag indented incorrectly; expected 2 spaces but found 9

     * @return Response
     */
    public function handle($request, Closure $next)
    {
        $cache = $request->cache();

        if ($cache) {
            list($key, $expire, $tag) = $cache;

            if (strtotime($request->server('HTTP_IF_MODIFIED_SINCE')) + $expire > $request->server('REQUEST_TIME')) {
                // 读取缓存
                return Response::create()->code(304);
            } elseif ($this->cache->has($key)) {
                list($content, $header) = $this->cache->get($key);

                return Response::create($content)->header($header);
            }
        }

        $response = $next($request);

        if (200 == $response->getCode() && $response->isAllowCache()) {
            if ($cache) {
                $header                  = $response->getHeader();
                $header['Cache-Control'] = 'max-age=' . $expire . ',must-revalidate';

The variable $expire does not seem to be defined for all execution paths leading up to this point.

                $header['Last-Modified'] = gmdate('D, d M Y H:i:s') . ' GMT';
                $header['Expires']       = gmdate('D, d M Y H:i:s', time() + $expire) . ' GMT';

                $this->cache->tag($tag)->set($key, [$response->getContent(), $header], $expire);

The variable $tag does not seem to be defined for all execution paths leading up to this point.

The variable $key does not seem to be defined for all execution paths leading up to this point.

            }
        }

        return $response;
    }
}