think\View

Complexity

Total Complexity

16

Size/Duplication

Total Lines	184
Duplicated Lines	0 %

Importance

Changes

0

12 Methods

Rating	Name	Duplication	Size	Complexity
A	filter()	0	4	1
A	display()	0	3	1
A	engine()	0	5	1
A	fetch()	0	23	4
A	__construct()	0	8	1
A	assign()	0	9	2
A	__isset()	0	3	1
A	exists()	0	3	1
A	__get()	0	3	1
A	config()	0	5	1
A	__make()	0	3	1
A	__set()	0	3	1

<?php
// +----------------------------------------------------------------------

You must use "/**" style comments for a file comment

// | ThinkPHP [ WE CAN DO IT JUST THINK ]
// +----------------------------------------------------------------------
// | Copyright (c) 2006~2019 http://thinkphp.cn All rights reserved.
// +----------------------------------------------------------------------
// | Licensed ( http://www.apache.org/licenses/LICENSE-2.0 )
// +----------------------------------------------------------------------
// | Author: liu21st <liu21st@gmail.com>
// +----------------------------------------------------------------------
declare (strict_types = 1);

namespace think;

class View

Missing class doc comment

{
    /**
     * 模板引擎实例
     * @var object
     */
    public $engine;

    /**
     * 模板变量
     * @var array
     */
    protected $data = [];

    /**
     * 内容过滤
     * @var mixed
     */
    protected $filter;

    /**
     * 初始化
     * @access public
     * @param  array $options  模板引擎参数

Expected 1 spaces after parameter name; 2 found

     * @return $this
     */
    public function __construct(array $options = [])
    {
        // 初始化模板引擎
        $type = $options['type'] ?? 'think';
        unset($options['type']);
        $this->engine($type, $options);

        return $this;
    }

    public static function __make(Config $config)

Missing function doc comment

Method name "View::__make" is invalid; only PHP magic methods should be prefixed with a double underscore

    {
        return new static($config->get('template'));

It seems like $config->get('template') can also be of type null; however, parameter $options of think\View::__construct() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * 模板变量赋值
     * @access public
     * @param  string|array $name  模板变量
     * @param  mixed        $value 变量值
     * @return $this
     */
    public function assign($name, $value = null)
    {
        if (is_array($name)) {
            $this->data = array_merge($this->data, $name);
        } else {
            $this->data[$name] = $value;
        }

        return $this;
    }

    /**
     * 设置当前模板解析的引擎
     * @access public
     * @param  string       $type    模板引擎类型
     * @param  array|string $options 模板引擎参数
     * @return $this
     */
    public function engine(string $type, array $options = [])
    {
        $this->engine = App::factory($type, '\\think\\view\\driver\\', $options);

        return $this;
    }

    /**

Parameter $config should have a doc-comment as per coding-style.

     * 配置模板引擎
     * @access public
     * @param  array  $name 模板参数

Doc comment for parameter $name does not match actual variable name $config

     * @return $this
     */
    public function config(array $config)
    {
        $this->engine->config($config);

        return $this;
    }

    /**
     * 检查模板是否存在
     * @access public
     * @param  string  $name 参数名
     * @return bool
     */
    public function exists(string $name): bool
    {
        return $this->engine->exists($name);
    }

    /**
     * 视图过滤
     * @access public
     * @param Callable  $filter 过滤方法或闭包

Tag value indented incorrectly; expected 2 spaces but found 1

     * @return $this
     */
    public function filter(callable $filter = null)
    {
        $this->filter = $filter;
        return $this;
    }

    /**
     * 解析和获取模板内容 用于输出
     * @access public
     * @param  string    $template 模板文件名或者内容

Expected 6 spaces after parameter name; 1 found

     * @param  bool      $renderContent     是否渲染内容

Expected 1 spaces after parameter name; 5 found

     * @return string
     * @throws \Exception
     */
    public function fetch(string $template = '', bool $renderContent = false): string
    {
        // 页面缓存
        ob_start();
        ob_implicit_flush(0);

        // 渲染输出
        try {
            $method = $renderContent ? 'display' : 'fetch';
            $this->engine->$method($template, $this->data);
        } catch (\Exception $e) {
            ob_end_clean();
            throw $e;
        }

        // 获取并清空缓存
        $content = ob_get_clean();

        if ($this->filter) {
            $content = call_user_func_array($this->filter, [$content]);
        }

        return $content;
    }

    /**
     * 渲染内容输出
     * @access public
     * @param  string $content 内容
     * @return string
     */
    public function display(string $content): string
    {
        return $this->fetch($content, true);
    }

    /**
     * 模板变量赋值
     * @access public
     * @param  string    $name  变量名
     * @param  mixed     $value 变量值
     */

Missing @return tag in function comment

    public function __set($name, $value)
    {
        $this->data[$name] = $value;
    }

    /**
     * 取得模板显示变量的值
     * @access protected
     * @param  string $name 模板变量
     * @return mixed
     */
    public function __get($name)
    {
        return $this->data[$name];
    }

    /**
     * 检测模板变量是否设置
     * @access public
     * @param  string $name 模板变量名
     * @return bool
     */
    public function __isset($name)
    {
        return isset($this->data[$name]);
    }
}