Config::parse() - Code Metrics - Inspection of "Apply fixes from StyleCI" - top-think/framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 6.0 (#1853)

by liu

created 2019-06-14 08:28 UTC

Config::parse() B

↳ Parent: Config

Complexity

Conditions	10
Paths	32

Size

Total Lines	23
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	32.8211

Importance

Changes

Metric	Value
cc	10
eloc	17
nc	32
nop	2
dl	0
loc	23
ccs	7
cts	18
cp	0.3889
crap	32.8211
rs	7.6666
c	0
b	0
f	0

How to fix Complexity

<?php
// +----------------------------------------------------------------------

// | ThinkPHP [ WE CAN DO IT JUST THINK ]
// +----------------------------------------------------------------------
// | Copyright (c) 2006~2019 http://thinkphp.cn All rights reserved.
// +----------------------------------------------------------------------
// | Licensed ( http://www.apache.org/licenses/LICENSE-2.0 )
// +----------------------------------------------------------------------
// | Author: liu21st <[email protected]>
// +----------------------------------------------------------------------
declare (strict_types = 1);

namespace think;

/**
 * 配置管理类
 */

class Config
{
    /**
     * 配置参数
     * @var array
     */
    protected $config = [];

    /**
     * 配置文件目录
     * @var string
     */
    protected $path;

    /**
     * 配置文件后缀
     * @var string
     */
    protected $ext;

    /**

     * 构造方法
     * @access public
     */
    public function __construct(string $path = null, string $ext = '.php')
    {
        $this->path = $path ?: '';
        $this->ext  = $ext;
    }

    public static function __make(App $app)

    {
        $path = $app->getConfigPath();
        $ext  = $app->getConfigExt();

        return new static($path, $ext);
    }

    /**
     * 加载配置文件（多种格式）
     * @access public
     * @param  string $file 配置文件名
     * @param  string $name 一级配置名
     * @return array
     */
    public function load(string $file, string $name = ''): array
    {
        if (is_file($file)) {
            $filename = $file;
        } elseif (is_file($this->path . $file . $this->ext)) {
            $filename = $this->path . $file . $this->ext;
        }

        if (isset($filename)) {
            return $this->parse($filename, $name);
        }

        return $this->config;
    }

    /**
     * 解析配置文件
     * @access public
     * @param  string $file 配置文件名
     * @param  string $name 一级配置名
     * @return array
     */
    protected function parse(string $file, string $name): array
    {
        $type = pathinfo($file, PATHINFO_EXTENSION);

        switch ($type) {
            case 'php':

                $config = include $file;
                break;
            case 'yml':

            case 'yaml':

                if (function_exists('yaml_parse_file')) {

                    $config = yaml_parse_file($file);
                }

                break;
            case 'ini':

                $config = parse_ini_file($file, true, INI_SCANNER_TYPED) ?: [];
                break;
            case 'json':

                $config = json_decode(file_get_contents($file), true);
                break;
        }

        return isset($config) && is_array($config) ? $this->set($config, strtolower($name)) : [];
    }

    /**
     * 检测配置是否存在
     * @access public
     * @param  string $name 配置参数名（支持多级配置 .号分割）
     * @return bool
     */
    public function has(string $name): bool
    {
        return !is_null($this->get($name));
    }

    /**
     * 获取一级配置
     * @access protected
     * @param  string $name 一级配置名
     * @return array
     */
    protected function pull(string $name): array
    {
        $name = strtolower($name);

        return $this->config[$name] ?? [];
    }

    /**
     * 获取配置参数 为空则获取所有配置
     * @access public
     * @param  string $name    配置参数名（支持多级配置 .号分割）
     * @param  mixed  $default 默认值
     * @return mixed
     */
    public function get(string $name = null, $default = null)
    {
        // 无参数时获取所有
        if (empty($name)) {
            return $this->config;
        }

        if (false === strpos($name, '.')) {
            return $this->pull($name);
        }

        $name    = explode('.', $name);
        $name[0] = strtolower($name[0]);
        $config  = $this->config;

        // 按.拆分成多维数组进行判断
        foreach ($name as $val) {
            if (isset($config[$val])) {
                $config = $config[$val];
            } else {
                return $default;
            }
        }

        return $config;
    }

    /**
     * 设置配置参数 name为数组则为批量设置
     * @access public
     * @param  array  $config 配置参数
     * @param  string $name 配置名

     * @return array
     */
    public function set(array $config, string $name = null): array
    {
        if (!empty($name)) {
            if (isset($this->config[$name])) {
                $result = array_merge($this->config[$name], $config);
            } else {
                $result = $config;
            }

            $this->config[$name] = $result;
        } else {
            $result = $this->config = array_merge($this->config, array_change_key_case($config));
        }

        return $result;
    }

}


1		<?php
2		// +----------------------------------------------------------------------
		1 ignored issue – show Coding Style introduced 2019-02-27 06:16 UTC by Report Bug Copy Issue Report You must use "/**" style comments for a file comment Loading history...
3		// \| ThinkPHP [ WE CAN DO IT JUST THINK ]
4		// +----------------------------------------------------------------------
5		// \| Copyright (c) 2006~2019 http://thinkphp.cn All rights reserved.
6		// +----------------------------------------------------------------------
7		// \| Licensed ( http://www.apache.org/licenses/LICENSE-2.0 )
8		// +----------------------------------------------------------------------
9		// \| Author: liu21st <[email protected]>
10		// +----------------------------------------------------------------------
11		declare (strict_types = 1);
12
13		namespace think;
14
15		/**
16		* 配置管理类
17		*/
		5 ignored issues – show Coding Style introduced 2019-04-19 04:35 UTC by Report Bug Copy Issue Report Missing @category tag in class comment Loading history... Coding Style introduced 2019-04-19 04:35 UTC by Report Bug Copy Issue Report Missing @package tag in class comment Loading history... Coding Style introduced 2019-04-19 04:35 UTC by Report Bug Copy Issue Report Missing @author tag in class comment Loading history... Coding Style introduced 2019-04-19 04:35 UTC by Report Bug Copy Issue Report Missing @license tag in class comment Loading history... Coding Style introduced 2019-04-19 04:35 UTC by Report Bug Copy Issue Report Missing @link tag in class comment Loading history...
18		class Config
19		{
20		/**
21		* 配置参数
22		* @var array
23		*/
24		protected $config = [];
25
26		/**
27		* 配置文件目录
28		* @var string
29		*/
30		protected $path;
31
32		/**
33		* 配置文件后缀
34		* @var string
35		*/
36		protected $ext;
37
38		/**
		0 ignored issues – show Coding Style introduced 2019-02-27 06:16 UTC by Report Bug Copy Issue Report Parameter `$path` should have a doc-comment as per coding-style. Loading history... Coding Style introduced 2019-02-27 06:16 UTC by Report Bug Copy Issue Report Parameter `$ext` should have a doc-comment as per coding-style. Loading history...
39		* 构造方法
40		* @access public
41		*/
42	11	public function __construct(string $path = null, string $ext = '.php')
43		{
44	11	$this->path = $path ?: '';
45	11	$this->ext = $ext;
46	11	}
47
48	9	public static function __make(App $app)
		2 ignored issues – show Coding Style introduced 2019-03-30 12:16 UTC by Report Bug Copy Issue Report Missing doc comment for function __make() Loading history... Coding Style introduced 2019-02-27 06:16 UTC by Report Bug Copy Issue Report Method name "Config::__make" is invalid; only PHP magic methods should be prefixed with a double underscore Loading history... Coding Style introduced 2019-03-30 12:16 UTC by Report Bug Copy Issue Report Public method name "Config::__make" must not be prefixed with an underscore Loading history...
49		{
50	9	$path = $app->getConfigPath();
51	9	$ext = $app->getConfigExt();
52
53	9	return new static($path, $ext);
54		}
55
56		/**
57		* 加载配置文件（多种格式）
58		* @access public
59		* @param string $file 配置文件名
60		* @param string $name 一级配置名
61		* @return array
62		*/
63	1	public function load(string $file, string $name = ''): array
64		{
65	1	if (is_file($file)) {
66	1	$filename = $file;
67		} elseif (is_file($this->path . $file . $this->ext)) {
68		$filename = $this->path . $file . $this->ext;
69		}
70
71	1	if (isset($filename)) {
72	1	return $this->parse($filename, $name);
73		}
74
75		return $this->config;
76		}
77
78		/**
79		* 解析配置文件
80		* @access public
81		* @param string $file 配置文件名
82		* @param string $name 一级配置名
83		* @return array
84		*/
85	1	protected function parse(string $file, string $name): array
86		{
87	1	$type = pathinfo($file, PATHINFO_EXTENSION);
88
89	1	switch ($type) {
90	1	case 'php':
		1 ignored issue – show Coding Style introduced 2019-04-18 10:58 UTC by Report Bug Copy Issue Report Line indented incorrectly; expected 8 spaces, found 12 Loading history...
91	1	$config = include $file;
92	1	break;
93		case 'yml':
		1 ignored issue – show Coding Style introduced 2019-05-31 14:24 UTC by Report Bug Copy Issue Report Line indented incorrectly; expected 8 spaces, found 12 Loading history...
94		case 'yaml':
		1 ignored issue – show Coding Style introduced 2019-05-31 14:24 UTC by Report Bug Copy Issue Report Line indented incorrectly; expected 8 spaces, found 12 Loading history...
95		if (function_exists('yaml_parse_file')) {
		1 ignored issue – show Coding Style introduced 2019-05-31 14:24 UTC by Report Bug Copy Issue Report Line indented incorrectly; expected 12 spaces, found 16 Loading history...
96		$config = yaml_parse_file($file);
97		}
		1 ignored issue – show Coding Style introduced 2019-05-31 14:24 UTC by Report Bug Copy Issue Report Line indented incorrectly; expected 12 spaces, found 16 Loading history...
98		break;
99		case 'ini':
		1 ignored issue – show Coding Style introduced 2019-04-18 10:58 UTC by Report Bug Copy Issue Report Line indented incorrectly; expected 8 spaces, found 12 Loading history...
100		$config = parse_ini_file($file, true, INI_SCANNER_TYPED) ?: [];
101		break;
102		case 'json':
		1 ignored issue – show Coding Style introduced 2019-04-18 10:58 UTC by Report Bug Copy Issue Report Line indented incorrectly; expected 8 spaces, found 12 Loading history...
103		$config = json_decode(file_get_contents($file), true);
104		break;
105		}
106
107	1	return isset($config) && is_array($config) ? $this->set($config, strtolower($name)) : [];
108		}
109
110		/**
111		* 检测配置是否存在
112		* @access public
113		* @param string $name 配置参数名（支持多级配置 .号分割）
114		* @return bool
115		*/
116	1	public function has(string $name): bool
117		{
118	1	return !is_null($this->get($name));
119		}
120
121		/**
122		* 获取一级配置
123		* @access protected
124		* @param string $name 一级配置名
125		* @return array
126		*/
127	10	protected function pull(string $name): array
128		{
129	10	$name = strtolower($name);
130
131	10	return $this->config[$name] ?? [];
132		}
133
134		/**
135		* 获取配置参数为空则获取所有配置
136		* @access public
137		* @param string $name 配置参数名（支持多级配置 .号分割）
138		* @param mixed $default 默认值
139		* @return mixed
140		*/
141	11	public function get(string $name = null, $default = null)
142		{
143		// 无参数时获取所有
144	11	if (empty($name)) {
145		return $this->config;
146		}
147
148	11	if (false === strpos($name, '.')) {
149	10	return $this->pull($name);
150		}
151
152	10	$name = explode('.', $name);
153	10	$name[0] = strtolower($name[0]);
154	10	$config = $this->config;
155
156		// 按.拆分成多维数组进行判断
157	10	foreach ($name as $val) {
158	10	if (isset($config[$val])) {
159	2	$config = $config[$val];
160		} else {
161	9	return $default;
162		}
163		}
164
165	2	return $config;
166		}
167
168		/**
169		* 设置配置参数 name为数组则为批量设置
170		* @access public
171		* @param array $config 配置参数
172		* @param string $name 配置名
		0 ignored issues – show Coding Style introduced 2019-02-27 06:16 UTC by Report Bug Copy Issue Report Expected 3 spaces after parameter name; 1 found Loading history...
173		* @return array
174		*/
175	2	public function set(array $config, string $name = null): array
176		{
177	2	if (!empty($name)) {
178	2	if (isset($this->config[$name])) {
179		$result = array_merge($this->config[$name], $config);
180		} else {
181	2	$result = $config;
182		}
183
184	2	$this->config[$name] = $result;
185		} else {
186		$result = $this->config = array_merge($this->config, array_change_key_case($config));
187		}
188
189	2	return $result;
190		}
191
192		}
193

top-think / framework

Pull Request — 6.0 (#1853)

Config::parse() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like