think\file\UploadedFile

Complexity

Total Complexity

21

Size/Duplication

Total Lines	116
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	3
A	getOriginalName()	0	3	1
A	extension()	0	3	1
B	getErrorMessage()	0	24	7
A	getOriginalMime()	0	3	1
A	move()	0	25	4
A	getOriginalExtension()	0	3	1
A	isValid()	0	5	3

<?php
// +----------------------------------------------------------------------
// | ThinkPHP [ WE CAN DO IT JUST THINK ]
// +----------------------------------------------------------------------
// | Copyright (c) 2006~2019 http://thinkphp.cn All rights reserved.
// +----------------------------------------------------------------------
// | Licensed ( http://www.apache.org/licenses/LICENSE-2.0 )
// +----------------------------------------------------------------------
// | Author: yunwuxin <448901948@qq.com>
// +----------------------------------------------------------------------
namespace think\file;

use think\exception\FileException;
use think\File;

class UploadedFile extends File

Missing doc comment for class UploadedFile

{

    private $test = false;

Private member variable "test" must be prefixed with an underscore

    private $originalName;

Private member variable "originalName" must be prefixed with an underscore

    private $mimeType;

Private member variable "mimeType" must be prefixed with an underscore

    private $error;

Private member variable "error" must be prefixed with an underscore

    public function __construct(string $path, string $originalName, string $mimeType = null, int $error = null, $test = false)

Missing doc comment for function __construct()

    {
        $this->originalName = $originalName;
        $this->mimeType     = $mimeType ?: 'application/octet-stream';
        $this->test         = $test;
        $this->error        = $error ?: UPLOAD_ERR_OK;
        parent::__construct($path, UPLOAD_ERR_OK === $this->error);
    }

    public function isValid()

Missing doc comment for function isValid()

    {
        $isOk = UPLOAD_ERR_OK === $this->error;

        return $this->test ? $isOk : $isOk && is_uploaded_file($this->getPathname());
    }

    public function move(string $directory, $name = null)

Missing doc comment for function move()

    {
        if ($this->isValid()) {
            if ($this->test) {
                return parent::move($directory, $name);
            }

            $target = $this->getTargetFile($directory, $name);

            set_error_handler(function ($type, $msg) use (&$error) {

The opening parenthesis of a multi-line function call should be the last content on the line.

                $error = $msg;
            });

For multi-line function calls, the closing parenthesis should be on a new line.

            $moved = move_uploaded_file($this->getPathname(), $target);
            restore_error_handler();
            if (!$moved) {
                throw new FileException(sprintf('Could not move the file "%s" to "%s" (%s)', $this->getPathname(), $target, strip_tags($error)));
            }

            @chmod($target, 0666 & ~umask());

It seems like you do not handle an error condition for chmod(). This can introduce security issues, and is generally not recommended.

            return $target;
        }

        throw new FileException($this->getErrorMessage());
    }

    /**
     * 获取错误信息
     * @access public
     * @return string
     */
    protected function getErrorMessage(): string
    {
        switch ($this->error) {
            case 1:

Line indented incorrectly; expected 8 spaces, found 12

            case 2:

Line indented incorrectly; expected 8 spaces, found 12

                $message = 'upload File size exceeds the maximum value';
                break;
            case 3:

Line indented incorrectly; expected 8 spaces, found 12

                $message = 'only the portion of file is uploaded';
                break;
            case 4:

Line indented incorrectly; expected 8 spaces, found 12

                $message = 'no file to uploaded';
                break;
            case 6:

Line indented incorrectly; expected 8 spaces, found 12

                $message = 'upload temp dir not found';
                break;
            case 7:

Line indented incorrectly; expected 8 spaces, found 12

                $message = 'file write error';
                break;
            default:

Line indented incorrectly; expected 8 spaces, found 12

                $message = 'unknown upload error';
        }

        return $message;
    }

    /**
     * 获取上传文件类型信息
     * @return string
     */
    public function getOriginalMime()
    {
        return $this->mimeType;
    }

    /**
     * 上传文件名
     * @return string
     */
    public function getOriginalName()
    {
        return $this->originalName;
    }

    /**
     * 获取上传文件扩展名
     * @return string
     */
    public function getOriginalExtension()
    {
        return pathinfo($this->originalName, PATHINFO_EXTENSION);
    }

    /**
     * 获取文件扩展名
     * @return string
     */
    public function extension()
    {
        return $this->getOriginalExtension();
    }
}