think\File

Complexity

Total Complexity

24

Size/Duplication

Total Lines	154
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	hash()	0	7	2
A	__construct()	0	7	3
A	getName()	0	7	2
A	hashName()	0	22	5
A	move()	0	16	2
A	getTargetFile()	0	13	6
A	sha1()	0	3	1
A	getMime()	0	5	1
A	md5()	0	3	1
A	extension()	0	3	1

<?php
// +----------------------------------------------------------------------
// | ThinkPHP [ WE CAN DO IT JUST THINK ]
// +----------------------------------------------------------------------
// | Copyright (c) 2006~2019 http://thinkphp.cn All rights reserved.
// +----------------------------------------------------------------------
// | Licensed ( http://www.apache.org/licenses/LICENSE-2.0 )
// +----------------------------------------------------------------------
// | Author: liu21st <liu21st@gmail.com>
// +----------------------------------------------------------------------
declare (strict_types = 1);

namespace think;

use SplFileInfo;
use think\exception\FileException;

/**
 * 文件上传类
 */

Missing @category tag in class comment

Missing @package tag in class comment

Missing @author tag in class comment

Missing @license tag in class comment

Missing @link tag in class comment

class File extends SplFileInfo
{

    /**
     * 文件hash规则
     * @var array
     */
    protected $hash = [];

    protected $hashName;

    public function __construct(string $path, bool $checkPath = true)

Missing doc comment for function __construct()

    {
        if ($checkPath && !is_file($path)) {
            throw new FileException(sprintf('The file "%s" does not exist', $path));
        }

        parent::__construct($path);
    }

    /**
     * 获取文件的哈希散列值
     * @access public
     * @param string $type

Missing parameter comment

Tag value for @param tag indented incorrectly; expected 2 spaces but found 1

     * @return string
     */
    public function hash(string $type = 'sha1'): string
    {
        if (!isset($this->hash[$type])) {
            $this->hash[$type] = hash_file($type, $this->getPathname());
        }

        return $this->hash[$type];
    }

    public function md5()

Missing doc comment for function md5()

    {
        return $this->hash('md5');
    }

    public function sha1()

Missing doc comment for function sha1()

    {
        return $this->hash('sha1');
    }

    /**
     * 获取文件类型信息
     * @access public
     * @return string
     */
    public function getMime(): string
    {
        $finfo = finfo_open(FILEINFO_MIME_TYPE);

        return finfo_file($finfo, $this->getPathname());
    }

    /**
     * 移动文件
     * @access public
     * @param string      $directory 保存路径

Tag value for @param tag indented incorrectly; expected 2 spaces but found 1

     * @param string|bool $name      保存的文件名

Tag value for @param tag indented incorrectly; expected 2 spaces but found 1

     * @return File
     */
    public function move(string $directory, $name = null)
    {
        $target = $this->getTargetFile($directory, $name);

        set_error_handler(function ($type, $msg) use (&$error) {

The opening parenthesis of a multi-line function call should be the last content on the line.

            $error = $msg;
        });

For multi-line function calls, the closing parenthesis should be on a new line.

        $renamed = rename($this->getPathname(), $target);
        restore_error_handler();
        if (!$renamed) {
            throw new FileException(sprintf('Could not move the file "%s" to "%s" (%s)', $this->getPathname(), $target, strip_tags($error)));
        }

        @chmod($target, 0666 & ~umask());

It seems like you do not handle an error condition for chmod(). This can introduce security issues, and is generally not recommended.

        return $target;
    }

    /**
     * 实例化一个新文件
     * @param string      $directory

Missing parameter comment

Tag value for @param tag indented incorrectly; expected 2 spaces but found 1

     * @param null|string $name

Missing parameter comment

Tag value for @param tag indented incorrectly; expected 2 spaces but found 1

     * @return File
     */
    protected function getTargetFile($directory, $name = null)
    {
        if (!is_dir($directory)) {
            if (false === @mkdir($directory, 0777, true) && !is_dir($directory)) {
                throw new FileException(sprintf('Unable to create the "%s" directory', $directory));
            }
        } elseif (!is_writable($directory)) {
            throw new FileException(sprintf('Unable to write in the "%s" directory', $directory));
        }

        $target = rtrim($directory, '/\\') . \DIRECTORY_SEPARATOR . (null === $name ? $this->getBasename() : $this->getName($name));

        return new self($target, false);
    }

    /**

Parameter $name should have a doc-comment as per coding-style.

     * 获取文件名
     * @param $name

Missing parameter name

Tag value for @param tag indented incorrectly; expected 2 spaces but found 1

     * @return bool|mixed|string
     */
    protected function getName($name)
    {
        $originalName = str_replace('\\', '/', $name);
        $pos          = strrpos($originalName, '/');
        $originalName = false === $pos ? $originalName : substr($originalName, $pos + 1);

        return $originalName;
    }

    /**
     * 文件扩展名
     * @return string
     */
    public function extension()
    {
        return $this->getExtension();
    }

    /**
     * 自动生成文件名
     * @access protected
     * @param string|\Closure $rule

Missing parameter comment

Tag value for @param tag indented incorrectly; expected 2 spaces but found 1

     * @return string
     */
    public function hashName($rule = 'date'): string
    {
        if (!$this->hashName) {
            if ($rule instanceof \Closure) {
                $this->hashName = call_user_func_array($rule, [$this]);
            } else {
                switch (true) {
                    case in_array($rule, hash_algos()):

Line indented incorrectly; expected 16 spaces, found 20

                        $hash           = $this->hash($rule);
                        $this->hashName = substr($hash, 0, 2) . DIRECTORY_SEPARATOR . substr($hash, 2);
                        break;
                    case is_callable($rule):

Line indented incorrectly; expected 16 spaces, found 20

                        $this->hashName = call_user_func($rule);
                        break;
                    default:

Line indented incorrectly; expected 16 spaces, found 20

                        $this->hashName = date('Ymd') . DIRECTORY_SEPARATOR . md5((string) microtime(true));
                        break;
                }
            }
        }

        return $this->hashName . '.' . $this->extension();
    }
}