think\debug\Html::output()

Complexity

Conditions	14
Paths	50

Size

Total Lines	66
Code Lines	44

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	210

Importance

Changes

0

<?php
    public function output(App $app, Response $response, array $log = [])
    {
        $request = $app->request;

        $contentType = $response->getHeader('Content-Type');
        $accept      = $request->header('accept');
        if (strpos($accept, 'application/json') === 0 || $request->isAjax()) {

It seems like $accept can also be of type array; however, parameter $haystack of strpos() does only seem to accept string, maybe add an additional type check?

            return false;
        } elseif (!empty($contentType) && strpos($contentType, 'html') === false) {
            return false;
        }

        // 获取基本信息
        $runtime = number_format(microtime(true) - $app->getBeginTime(), 10, '.', '');
        $reqs    = $runtime > 0 ? number_format(1 / $runtime, 2) : '∞';
        $mem     = number_format((memory_get_usage() - $app->getBeginMem()) / 1024, 2);

        // 页面Trace信息
        if ($request->host()) {
            $uri = $request->protocol() . ' ' . $request->method() . ' : ' . $request->url(true);
        } else {
            $uri = 'cmd:' . implode(' ', $_SERVER['argv']);
        }

        $base = [
            '请求信息' => date('Y-m-d H:i:s', $request->time()) . ' ' . $uri,

It seems like $request->time() can also be of type double; however, parameter $timestamp of date() does only seem to accept integer, maybe add an additional type check?

            '运行时间' => number_format((float) $runtime, 6) . 's [ 吞吐率：' . $reqs . 'req/s ] 内存消耗：' . $mem . 'kb 文件加载：' . count(get_included_files()),
            '查询信息' => $app->db->getQueryTimes() . ' queries',
            '缓存信息' => $app->cache->getReadTimes() . ' reads,' . $app->cache->getWriteTimes() . ' writes',

The method getWriteTimes() does not exist on think\Cache. Since you implemented __call, consider adding a @method annotation.

The method getReadTimes() does not exist on think\Cache. Since you implemented __call, consider adding a @method annotation.

        ];

        if ($app->session->getId(false)) {
            $base['会话信息'] = 'SESSION_ID=' . $app->session->getId();
        }

        $info = $this->getFileInfo();

        // 页面Trace信息
        $trace = [];
        foreach ($this->config['tabs'] as $name => $title) {
            $name = strtolower($name);
            switch ($name) {
                case 'base': // 基本信息

Line indented incorrectly; expected 12 spaces, found 16

                    $trace[$title] = $base;
                    break;
                case 'file': // 文件信息

Line indented incorrectly; expected 12 spaces, found 16

                    $trace[$title] = $info;
                    break;
                default: // 调试信息

Line indented incorrectly; expected 12 spaces, found 16

                    if (strpos($name, '|')) {

Line indented incorrectly; expected 16 spaces, found 20

                        // 多组信息
                        $names  = explode('|', $name);
                        $result = [];
                        foreach ($names as $item) {

Line indented incorrectly; expected 20 spaces, found 24

                            $result = array_merge($result, $log[$item] ?? []);
                        }

Line indented incorrectly; expected 20 spaces, found 24

                        $trace[$title] = $result;
                    } else {

Line indented incorrectly; expected 16 spaces, found 20

                        $trace[$title] = $log[$name] ?? '';
                    }

Line indented incorrectly; expected 16 spaces, found 20

            }
        }
        // 调用Trace页面模板
        ob_start();
        include $this->config['file'] ?: __DIR__ . '/../../tpl/page_trace.tpl';
        return ob_get_clean();
    }