top-think /
framework
| Total Complexity | 45 |
| Total Lines | 255 |
| Duplicated Lines | 0 % |
| Coverage | 0% |
| Changes | 0 | ||
Complex classes like JoinAndViewQuery often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use JoinAndViewQuery, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 23 | trait JoinAndViewQuery |
||
| 24 | { |
||
| 25 | |||
| 26 | /** |
||
| 27 | * 查询SQL组装 join |
||
| 28 | * @access public |
||
| 29 | * @param mixed $join 关联的表名 |
||
| 30 | * @param mixed $condition 条件 |
||
| 31 | * @param string $type JOIN类型 |
||
| 32 | * @param array $bind 参数绑定 |
||
| 33 | * @return $this |
||
| 34 | */ |
||
| 35 | public function join($join, string $condition = null, string $type = 'INNER', array $bind = []) |
||
| 36 | { |
||
| 37 | $table = $this->getJoinTable($join); |
||
| 38 | |||
| 39 | if (!empty($bind) && $condition) { |
||
| 40 | $this->bindParams($condition, $bind); |
||
|
Bug
introduced
by
|
|||
| 41 | } |
||
| 42 | |||
| 43 | $this->options['join'][] = [$table, strtoupper($type), $condition]; |
||
| 44 | |||
| 45 | return $this; |
||
| 46 | } |
||
| 47 | |||
| 48 | /** |
||
| 49 | * LEFT JOIN |
||
| 50 | * @access public |
||
| 51 | * @param mixed $join 关联的表名 |
||
| 52 | * @param mixed $condition 条件 |
||
| 53 | * @param array $bind 参数绑定 |
||
| 54 | * @return $this |
||
| 55 | */ |
||
| 56 | public function leftJoin($join, string $condition = null, array $bind = []) |
||
| 57 | { |
||
| 58 | return $this->join($join, $condition, 'LEFT', $bind); |
||
| 59 | } |
||
| 60 | |||
| 61 | /** |
||
| 62 | * RIGHT JOIN |
||
| 63 | * @access public |
||
| 64 | * @param mixed $join 关联的表名 |
||
| 65 | * @param mixed $condition 条件 |
||
| 66 | * @param array $bind 参数绑定 |
||
| 67 | * @return $this |
||
| 68 | */ |
||
| 69 | public function rightJoin($join, string $condition = null, array $bind = []) |
||
| 72 | } |
||
| 73 | |||
| 74 | /** |
||
| 75 | * FULL JOIN |
||
| 76 | * @access public |
||
| 77 | * @param mixed $join 关联的表名 |
||
| 78 | * @param mixed $condition 条件 |
||
| 79 | * @param array $bind 参数绑定 |
||
| 80 | * @return $this |
||
| 81 | */ |
||
| 82 | public function fullJoin($join, string $condition = null, array $bind = []) |
||
| 83 | { |
||
| 84 | return $this->join($join, $condition, 'FULL'); |
||
| 85 | } |
||
| 86 | |||
| 87 | /** |
||
| 88 | * 获取Join表名及别名 支持 |
||
| 89 | * ['prefix_table或者子查询'=>'alias'] 'table alias' |
||
| 90 | * @access protected |
||
| 91 | * @param array|string|Raw $join JION表名 |
||
| 92 | * @param string $alias 别名 |
||
| 93 | * @return string|array |
||
| 94 | */ |
||
| 95 | protected function getJoinTable($join, &$alias = null) |
||
| 96 | { |
||
| 97 | if (is_array($join)) { |
||
| 98 | $table = $join; |
||
| 99 | $alias = array_shift($join); |
||
| 100 | return $table; |
||
| 101 | } elseif ($join instanceof Raw) { |
||
| 102 | return $join; |
||
| 103 | } |
||
| 104 | |||
| 105 | $join = trim($join); |
||
| 106 | |||
| 107 | if (false !== strpos($join, '(')) { |
||
| 108 | // 使用子查询 |
||
| 109 | $table = $join; |
||
| 110 | } else { |
||
| 111 | // 使用别名 |
||
| 112 | if (strpos($join, ' ')) { |
||
| 113 | // 使用别名 |
||
| 114 | list($table, $alias) = explode(' ', $join); |
||
| 115 | } else { |
||
| 116 | $table = $join; |
||
| 117 | if (false === strpos($join, '.')) { |
||
| 118 | $alias = $join; |
||
| 119 | } |
||
| 120 | } |
||
| 121 | |||
| 122 | if ($this->prefix && false === strpos($table, '.') && 0 !== strpos($table, $this->prefix)) { |
||
| 123 | $table = $this->getTable($table); |
||
| 124 | } |
||
| 125 | } |
||
| 126 | |||
| 127 | if (!empty($alias) && $table != $alias) { |
||
| 128 | $table = [$table => $alias]; |
||
| 129 | } |
||
| 130 | |||
| 131 | return $table; |
||
| 132 | } |
||
| 133 | |||
| 134 | /** |
||
| 135 | * 关联预载入 JOIN方式 |
||
| 136 | * @access protected |
||
| 137 | * @param array|string $with 关联方法名 |
||
| 138 | * @param string $joinType JOIN方式 |
||
| 139 | * @return $this |
||
| 140 | */ |
||
| 141 | public function withJoin($with, string $joinType = '') |
||
| 184 | } |
||
| 185 | |||
| 186 | /** |
||
| 187 | * 指定JOIN查询字段 |
||
| 188 | * @access public |
||
| 189 | * @param string|array $join 数据表 |
||
| 190 | * @param string|array $field 查询字段 |
||
| 191 | * @param string $on JOIN条件 |
||
| 192 | * @param string $type JOIN类型 |
||
| 193 | * @param array $bind 参数绑定 |
||
| 194 | * @return $this |
||
| 195 | */ |
||
| 196 | public function view($join, $field = true, $on = null, string $type = 'INNER', array $bind = []) |
||
| 197 | { |
||
| 198 | $this->options['view'] = true; |
||
| 199 | |||
| 200 | $fields = []; |
||
| 201 | $table = $this->getJoinTable($join, $alias); |
||
| 202 | |||
| 203 | if (true === $field) { |
||
| 204 | $fields = $alias . '.*'; |
||
| 205 | } else { |
||
| 206 | if (is_string($field)) { |
||
| 207 | $field = explode(',', $field); |
||
| 208 | } |
||
| 209 | |||
| 210 | foreach ($field as $key => $val) { |
||
| 211 | if (is_numeric($key)) { |
||
| 212 | $fields[] = $alias . '.' . $val; |
||
| 213 | |||
| 214 | $this->options['map'][$val] = $alias . '.' . $val; |
||
| 215 | } else { |
||
| 216 | if (preg_match('/[,=\.\'\"\(\s]/', $key)) { |
||
| 217 | $name = $key; |
||
| 218 | } else { |
||
| 219 | $name = $alias . '.' . $key; |
||
| 220 | } |
||
| 221 | |||
| 222 | $fields[] = $name . ' AS ' . $val; |
||
| 223 | |||
| 224 | $this->options['map'][$val] = $name; |
||
| 225 | } |
||
| 226 | } |
||
| 227 | } |
||
| 228 | |||
| 229 | $this->field($fields); |
||
| 230 | |||
| 231 | if ($on) { |
||
| 232 | $this->join($table, $on, $type, $bind); |
||
| 233 | } else { |
||
| 234 | $this->table($table); |
||
| 235 | } |
||
| 236 | |||
| 237 | return $this; |
||
| 238 | } |
||
| 239 | |||
| 240 | /** |
||
| 241 | * 视图查询处理 |
||
| 242 | * @access protected |
||
| 243 | * @param array $options 查询参数 |
||
| 244 | * @return void |
||
| 245 | */ |
||
| 246 | protected function parseView(array &$options): void |
||
| 278 | } |
||
| 279 | } |
||
| 284 |
Loading history...