think\console\command\optimize\Schema

Complexity

Total Complexity

18

Size/Duplication

Total Lines	95
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	5
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	configure()	0	7	1
A	buildDataBaseSchema()	0	13	3
B	execute()	0	48	10
A	buildModelSchema()	0	18	4

<?php
// +----------------------------------------------------------------------
// | ThinkPHP [ WE CAN DO IT JUST THINK IT ]
// +----------------------------------------------------------------------
// | Copyright (c) 2006-2016 http://thinkphp.cn All rights reserved.
// +----------------------------------------------------------------------
// | Licensed ( http://www.apache.org/licenses/LICENSE-2.0 )
// +----------------------------------------------------------------------
// | Author: yunwuxin <448901948@qq.com>
// +----------------------------------------------------------------------
namespace think\console\command\optimize;

use think\console\Command;
use think\console\Input;
use think\console\input\Argument;
use think\console\input\Option;
use think\console\Output;

class Schema extends Command
{
    protected function configure()

Missing doc comment for function configure()

    {
        $this->setName('optimize:schema')
            ->addArgument('app', Argument::OPTIONAL, 'app name .')
            ->addOption('db', null, Option::VALUE_REQUIRED, 'db name .')
            ->addOption('table', null, Option::VALUE_REQUIRED, 'table name .')
            ->setDescription('Build database schema cache.');
    }

    protected function execute(Input $input, Output $output)

Missing doc comment for function execute()

    {
        $app = $input->getArgument('app');

        $schemaPath = $this->app->db->getConnection()->getConfig('schema_cache_path');

The method getConnection() does not exist on think\Db. Since you implemented __call, consider adding a @method annotation.

        if (!is_dir($schemaPath)) {
            mkdir($schemaPath, 0755, true);
        }

        if ($input->hasOption('table')) {
            $table = $input->getOption('table');
            if (false === strpos($table, '.')) {

It seems like $table can also be of type think\console\input\Option; however, parameter $haystack of strpos() does only seem to accept string, maybe add an additional type check?

                $dbName = $this->app->db->getConnection()->getConfig('database');
            }

            $tables[] = $table;

$tables was never initialized. Although not strictly required by PHP, it is generally a good practice to add $tables = array(); before regardless.

        } elseif ($input->hasOption('db')) {
            $dbName = $input->getOption('db');
            $tables = $this->app->db->getConnection()->getTables($dbName);
        } else {
            if ($app) {
                $appPath   = $this->app->getBasePath() . $app . DIRECTORY_SEPARATOR;

Are you sure $app of type mixed|think\console\input\Argument can be used in concatenation?

                $namespace = 'app\\' . $app;
            } else {
                $appPath   = $this->app->getBasePath();
                $namespace = 'app';
            }

            $path = $appPath . 'model';
            $list = is_dir($path) ? scandir($path) : [];

            foreach ($list as $file) {
                if (0 === strpos($file, '.')) {
                    continue;
                }
                $class = '\\' . $namespace . '\\model\\' . pathinfo($file, PATHINFO_FILENAME);
                $this->buildModelSchema($class);
            }

            $output->writeln('<info>Succeed!</info>');
            return;
        }

        $db = isset($dbName) ? $dbName . '.' : '';
        $this->buildDataBaseSchema($schemaPath, $tables, $db);

        $output->writeln('<info>Succeed!</info>');
    }

    protected function buildModelSchema(string $class): void

Missing doc comment for function buildModelSchema()

    {
        $reflect = new \ReflectionClass($class);
        if (!$reflect->isAbstract() && $reflect->isSubclassOf('\think\Model')) {
            /** @var \think\Model $model */

The open comment tag must be the only content on the line

Missing short description in doc comment

The close comment tag must be the only content on the line

            $model = new $class;

            $table  = $model->getTable();
            $dbName = $model->getConnection()->getConfig('database');
            $path   = $model->getConnection()->getConfig('schema_cache_path');
            if (!is_dir($path)) {
                mkdir($path, 0755, true);
            }
            $content = '<?php ' . PHP_EOL . 'return ';
            $info    = $model->db()->getConnection()->getTableFieldsInfo($table);

The method getTableFieldsInfo() does not exist on think\db\Connection.

            $content .= var_export($info, true) . ';';

            file_put_contents($path . $dbName . '.' . $table . '.php', $content);
        }
    }

    protected function buildDataBaseSchema(string $path, array $tables, string $db): void

Missing doc comment for function buildDataBaseSchema()

    {
        if ('' == $db) {
            $dbName = $this->app->db->getConnection()->getConfig('database') . '.';
        } else {
            $dbName = $db;
        }

        foreach ($tables as $table) {
            $content = '<?php ' . PHP_EOL . 'return ';
            $info    = $this->app->db->getConnection()->getTableFieldsInfo($db . $table);
            $content .= var_export($info, true) . ';';
            file_put_contents($path . $dbName . $table . '.php', $content);
        }
    }
}