Sqlsrv::column() - Code Metrics - Inspection of "FIX SQL BUILDER BUG" - top-think/framework - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — 5.1 (#1746)

unknown

created 2019-04-07 11:36 UTC

Sqlsrv::column() F

↳ Parent: Sqlsrv

Complexity

Conditions	22
Paths	1117

Size

Total Lines	84
Code Lines	47

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	22
eloc	47
nc	1117
nop	3
dl	0
loc	84
rs	0
c	0
b	0
f	0

How to fix Long Method Complexity

<?php
// +----------------------------------------------------------------------

// | ThinkPHP [ WE CAN DO IT JUST THINK IT ]
// +----------------------------------------------------------------------
// | Copyright (c) 2006-2012 http://thinkphp.cn All rights reserved.
// +----------------------------------------------------------------------
// | Licensed ( http://www.apache.org/licenses/LICENSE-2.0 )
// +----------------------------------------------------------------------
// | Author: liu21st <[email protected]>
// +----------------------------------------------------------------------

namespace think\db\connector;

use PDO;
use think\db\Connection;
use think\db\Query;

/**
 * Sqlsrv数据库驱动
 */

class Sqlsrv extends Connection
{
    // PDO连接参数
    protected $params = [
        PDO::ATTR_CASE              => PDO::CASE_NATURAL,
        PDO::ATTR_ERRMODE           => PDO::ERRMODE_EXCEPTION,
        PDO::ATTR_ORACLE_NULLS      => PDO::NULL_NATURAL,
        PDO::ATTR_STRINGIFY_FETCHES => false,
    ];

    protected $builder = '\\think\\db\\builder\\Sqlsrv';

    /**
     * 解析pdo连接的dsn信息
     * @access protected
     * @param  array $config 连接信息
     * @return string
     */
    protected function parseDsn($config)
    {
        $dsn = 'sqlsrv:Database=' . $config['database'] . ';Server=' . $config['hostname'];

        if (!empty($config['hostport'])) {
            $dsn .= ',' . $config['hostport'];
        }

        return $dsn;
    }

    /**
     * 取得数据表的字段信息
     * @access public
     * @param  string $tableName

     * @return array
     */
    public function getFields($tableName)
    {
        list($tableName) = explode(' ', $tableName);
        $tableNames      = explode('.', $tableName);
        $tableName       = isset($tableNames[1]) ? $tableNames[1] : $tableNames[0];

        $sql = "SELECT   column_name,   data_type,   column_default,   is_nullable
        FROM    information_schema.tables AS t
        JOIN    information_schema.columns AS c
        ON  t.table_catalog = c.table_catalog
        AND t.table_schema  = c.table_schema
        AND t.table_name    = c.table_name
        WHERE   t.table_name = '$tableName'";

        $pdo    = $this->query($sql, [], false, true);
        $result = $pdo->fetchAll(PDO::FETCH_ASSOC);
        $info   = [];

        if ($result) {
            foreach ($result as $key => $val) {
                $val                       = array_change_key_case($val);
                $info[$val['column_name']] = [
                    'name'    => $val['column_name'],
                    'type'    => $val['data_type'],
                    'notnull' => (bool) ('' === $val['is_nullable']), // not null is empty, null is yes
                    'default' => $val['column_default'],
                    'primary' => false,
                    'autoinc' => false,
                ];
            }
        }

        $sql = "SELECT column_name FROM information_schema.key_column_usage WHERE table_name='$tableName'";

        // 调试开始
        $this->debug(true);

        $pdo = $this->linkID->query($sql);

        // 调试结束
        $this->debug(false, $sql);

        $result = $pdo->fetch(PDO::FETCH_ASSOC);

        if ($result) {
            $info[$result['column_name']]['primary'] = true;
        }

        return $this->fieldCase($info);
    }

    /**
     * 取得数据表的字段信息
     * @access public
     * @param  string $dbName

     * @return array
     */
    public function getTables($dbName = '')
    {
        $sql = "SELECT TABLE_NAME
            FROM INFORMATION_SCHEMA.TABLES
            WHERE TABLE_TYPE = 'BASE TABLE'
            ";

        $pdo    = $this->query($sql, [], false, true);
        $result = $pdo->fetchAll(PDO::FETCH_ASSOC);
        $info   = [];

        foreach ($result as $key => $val) {
            $info[$key] = current($val);
        }

        return $info;
    }

    /**
     * 得到某个列的数组
     * @access public
     * @param  Query     $query 查询对象
     * @param  string    $field 字段名 多个字段用逗号分隔
     * @param  string    $key   索引
     * @return array
     */
    public function column(Query $query, $field, $key = '')
    {
        $options = $query->getOptions();

        if (empty($options['fetch_sql']) && !empty($options['cache'])) {
            // 判断查询缓存
            $cache = $options['cache'];

            $guid = is_string($cache['key']) ? $cache['key'] : $this->getCacheKey($query, $field);

            $result = Container::get('cache')->get($guid);
filter:
    dependency_paths: ["lib/*"]

            if (false !== $result) {
                return $result;
            }
        }

        if (isset($options['field'])) {
            $query->removeOption('field');
        }

        if (is_null($field)) {

            $field = '*';
        } elseif ($key && '*' != $field) {
            $field = $key . ',' . $field;
        }

        if (is_string($field)) {

            $field = array_map('trim', explode(',', $field));
        }

        $query->setOption('field', $field);

        // 生成查询SQL
        $sql = $this->builder->select($query);

        $bind = $query->getBind();

        if (!empty($options['fetch_sql'])) {
            // 获取实际执行的SQL语句
            return $this->getRealSql($sql, $bind);

        }

        // 执行查询操作
        $pdo = $this->query($sql, $bind, $options['master'], true);

        if (1 == $pdo->columnCount()) {
            $result = $pdo->fetchAll(PDO::FETCH_COLUMN);
        } else {
            $resultSet = $pdo->fetchAll(PDO::FETCH_ASSOC);

            if ('*' == $field && $key) {
                $result = array_column($resultSet, null, $key);
            } elseif ($resultSet) {
                $fields = array_keys($resultSet[0]);
                $count  = count($fields);
                $key1   = array_shift($fields);
                $key2   = $fields ? array_shift($fields) : '';
                $key    = $key ?: $key1;

                if (strpos($key, '.')) {
                    list($alias, $key) = explode('.', $key);
                }

                if (3 == $count) {
                    $column = $key2;
                } elseif ($count < 3) {
                    $column = $key1;
                } else {
                    $column = null;
                }

                $result = array_column($resultSet, $column, $key);
            } else {
                $result = [];
            }
        }

        if (isset($cache) && isset($guid)) {
            // 缓存数据
            $this->cacheData($guid, $result, $cache);
        }

        return $result;
    }

    /**
     * SQL性能分析
     * @access protected
     * @param  string $sql

     * @return array
     */
    protected function getExplain($sql)
    {
        return [];
    }
}


1			<?php
2			// +----------------------------------------------------------------------
			1 ignored issue – show Coding Style introduced 2019-02-27 06:16 UTC by Report Bug Copy Issue Report You must use "/**" style comments for a file comment Loading history...
3			// \| ThinkPHP [ WE CAN DO IT JUST THINK IT ]
4			// +----------------------------------------------------------------------
5			// \| Copyright (c) 2006-2012 http://thinkphp.cn All rights reserved.
6			// +----------------------------------------------------------------------
7			// \| Licensed ( http://www.apache.org/licenses/LICENSE-2.0 )
8			// +----------------------------------------------------------------------
9			// \| Author: liu21st <[email protected]>
10			// +----------------------------------------------------------------------
11
12			namespace think\db\connector;
13
14			use PDO;
15			use think\db\Connection;
16			use think\db\Query;
17
18			/**
19			* Sqlsrv数据库驱动
20			*/
			5 ignored issues – show Coding Style introduced 2019-02-27 06:16 UTC by Report Bug Copy Issue Report Missing @category tag in class comment Loading history... Coding Style introduced 2019-02-27 06:16 UTC by Report Bug Copy Issue Report Missing @package tag in class comment Loading history... Coding Style introduced 2019-02-27 06:16 UTC by Report Bug Copy Issue Report Missing @author tag in class comment Loading history... Coding Style introduced 2019-02-27 06:16 UTC by Report Bug Copy Issue Report Missing @license tag in class comment Loading history... Coding Style introduced 2019-02-27 06:16 UTC by Report Bug Copy Issue Report Missing @link tag in class comment Loading history...
21			class Sqlsrv extends Connection
22			{
23			// PDO连接参数
24			protected $params = [
25			PDO::ATTR_CASE => PDO::CASE_NATURAL,
26			PDO::ATTR_ERRMODE => PDO::ERRMODE_EXCEPTION,
27			PDO::ATTR_ORACLE_NULLS => PDO::NULL_NATURAL,
28			PDO::ATTR_STRINGIFY_FETCHES => false,
29			];
30
31			protected $builder = '\\think\\db\\builder\\Sqlsrv';
32
33			/**
34			* 解析pdo连接的dsn信息
35			* @access protected
36			* @param array $config 连接信息
37			* @return string
38			*/
39			protected function parseDsn($config)
40			{
41			$dsn = 'sqlsrv:Database=' . $config['database'] . ';Server=' . $config['hostname'];
42
43			if (!empty($config['hostport'])) {
44			$dsn .= ',' . $config['hostport'];
45			}
46
47			return $dsn;
48			}
49
50			/**
51			* 取得数据表的字段信息
52			* @access public
53			* @param string $tableName
			0 ignored issues – show Coding Style introduced 2019-02-27 06:16 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history...
54			* @return array
55			*/
56			public function getFields($tableName)
57			{
58			list($tableName) = explode(' ', $tableName);
59			$tableNames = explode('.', $tableName);
60			$tableName = isset($tableNames[1]) ? $tableNames[1] : $tableNames[0];
61
62			$sql = "SELECT column_name, data_type, column_default, is_nullable
63			FROM information_schema.tables AS t
64			JOIN information_schema.columns AS c
65			ON t.table_catalog = c.table_catalog
66			AND t.table_schema = c.table_schema
67			AND t.table_name = c.table_name
68			WHERE t.table_name = '$tableName'";
69
70			$pdo = $this->query($sql, [], false, true);
71			$result = $pdo->fetchAll(PDO::FETCH_ASSOC);
72			$info = [];
73
74			if ($result) {
75			foreach ($result as $key => $val) {
76			$val = array_change_key_case($val);
77			$info[$val['column_name']] = [
78			'name' => $val['column_name'],
79			'type' => $val['data_type'],
80			'notnull' => (bool) ('' === $val['is_nullable']), // not null is empty, null is yes
81			'default' => $val['column_default'],
82			'primary' => false,
83			'autoinc' => false,
84			];
85			}
86			}
87
88			$sql = "SELECT column_name FROM information_schema.key_column_usage WHERE table_name='$tableName'";
89
90			// 调试开始
91			$this->debug(true);
92
93			$pdo = $this->linkID->query($sql);
94
95			// 调试结束
96			$this->debug(false, $sql);
97
98			$result = $pdo->fetch(PDO::FETCH_ASSOC);
99
100			if ($result) {
101			$info[$result['column_name']]['primary'] = true;
102			}
103
104			return $this->fieldCase($info);
105			}
106
107			/**
108			* 取得数据表的字段信息
109			* @access public
110			* @param string $dbName
			0 ignored issues – show Coding Style introduced 2019-02-27 06:16 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history...
111			* @return array
112			*/
113			public function getTables($dbName = '')
114			{
115			$sql = "SELECT TABLE_NAME
116			FROM INFORMATION_SCHEMA.TABLES
117			WHERE TABLE_TYPE = 'BASE TABLE'
118			";
119
120			$pdo = $this->query($sql, [], false, true);
121			$result = $pdo->fetchAll(PDO::FETCH_ASSOC);
122			$info = [];
123
124			foreach ($result as $key => $val) {
125			$info[$key] = current($val);
126			}
127
128			return $info;
129			}
130
131			/**
132			* 得到某个列的数组
133			* @access public
134			* @param Query $query 查询对象
135			* @param string $field 字段名多个字段用逗号分隔
136			* @param string $key 索引
137			* @return array
138			*/
139			public function column(Query $query, $field, $key = '')
140			{
141			$options = $query->getOptions();
142
143			if (empty($options['fetch_sql']) && !empty($options['cache'])) {
144			// 判断查询缓存
145			$cache = $options['cache'];
146
147			$guid = is_string($cache['key']) ? $cache['key'] : $this->getCacheKey($query, $field);
148
149			$result = Container::get('cache')->get($guid);
			0 ignored issues – show Bug introduced 2019-04-05 02:29 UTC by Report Bug Copy Issue Report The type `think\db\connector\Container` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
150
151			if (false !== $result) {
152			return $result;
153			}
154			}
155
156			if (isset($options['field'])) {
157			$query->removeOption('field');
158			}
159
160			if (is_null($field)) {
			0 ignored issues – show introduced 2019-04-05 02:29 UTC by Report Bug Copy Issue Report The condition `is_null($field)` is always `false`. Loading history...
161			$field = '*';
162			} elseif ($key && '*' != $field) {
163			$field = $key . ',' . $field;
164			}
165
166			if (is_string($field)) {
			0 ignored issues – show introduced 2019-02-23 02:36 UTC by Report Bug Copy Issue Report The condition `is_string($field)` is always `true`. Loading history...
167			$field = array_map('trim', explode(',', $field));
168			}
169
170			$query->setOption('field', $field);
171
172			// 生成查询SQL
173			$sql = $this->builder->select($query);
174
175			$bind = $query->getBind();
176
177			if (!empty($options['fetch_sql'])) {
178			// 获取实际执行的SQL语句
179			return $this->getRealSql($sql, $bind);
			0 ignored issues – show Bug Best Practice introduced 2019-04-05 02:29 UTC by Report Bug Copy Issue Report The expression `return $this->getRealSql($sql, $bind)` returns the type `string` which is incompatible with the documented return type `array`. Loading history...
180			}
181
182			// 执行查询操作
183			$pdo = $this->query($sql, $bind, $options['master'], true);
184
185			if (1 == $pdo->columnCount()) {
186			$result = $pdo->fetchAll(PDO::FETCH_COLUMN);
187			} else {
188			$resultSet = $pdo->fetchAll(PDO::FETCH_ASSOC);
189
190			if ('*' == $field && $key) {
191			$result = array_column($resultSet, null, $key);
192			} elseif ($resultSet) {
193			$fields = array_keys($resultSet[0]);
194			$count = count($fields);
195			$key1 = array_shift($fields);
196			$key2 = $fields ? array_shift($fields) : '';
197			$key = $key ?: $key1;
198
199			if (strpos($key, '.')) {
200			list($alias, $key) = explode('.', $key);
201			}
202
203			if (3 == $count) {
204			$column = $key2;
205			} elseif ($count < 3) {
206			$column = $key1;
207			} else {
208			$column = null;
209			}
210
211			$result = array_column($resultSet, $column, $key);
212			} else {
213			$result = [];
214			}
215			}
216
217			if (isset($cache) && isset($guid)) {
218			// 缓存数据
219			$this->cacheData($guid, $result, $cache);
220			}
221
222			return $result;
223			}
224
225			/**
226			* SQL性能分析
227			* @access protected
228			* @param string $sql
			0 ignored issues – show Coding Style introduced 2019-02-27 06:16 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history...
229			* @return array
230			*/
231			protected function getExplain($sql)
232			{
233			return [];
234			}
235			}
236

top-think / framework

Pull Request — 5.1 (#1746)

Sqlsrv::column() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like