Issues in SDImportJob.php (master) - Issues in master - toniher/SemanticDataImport - Measure and Improve Code Quality continuously with Scrutinizer

Issues (48)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

includes/SDImportJob.php (3 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * Background job to import a page into the wiki, adapted from Data Transfer
 *
 * @author Yaron Koren
 * @author Toni Hermoso
 */
class SDImportJob extends Job {

   function __construct( $title, $params = '', $id = 0 ) {

       parent::__construct( 'sdImport', $title, $params, $id );
   }

   /**
    * Run a dtImport job
    * @return boolean success
    */
   function run() {

       wfProfileIn( __METHOD__ );

       if ( is_null( $this->title ) ) {
           $this->error = "sdImport: Invalid title";
           wfProfileOut( __METHOD__ );
           return false;
       }

       if ( method_exists( 'WikiPage', 'getContent' ) ) {
           $wikiPage = new WikiPage( $this->title );
           if ( !$wikiPage ) {
               $this->error = 'sdImport: Wiki page not found "' . $this->title->getPrefixedDBkey() . '"';
               wfProfileOut( __METHOD__ );
               return false;
           }
       } else {
         // Remove old support
         return false;
       }
       $for_pages_that_exist = $this->params['for_pages_that_exist'];
       if ( $for_pages_that_exist == 'skip' && $this->title->exists() ) {
           return true;
       }

       // Change global $wgUser variable to the one specified by
       // the job only for the extent of this import.
       global $wgUser;
       $actual_user = $wgUser;
       $wgUser = User::newFromId( $this->params['user_id'] );
       $text = $this->params['text'];
       $edit_summary = $this->params['edit_summary'];

       // Act according to storage here
       if ( $this->params['storage'] == "json" ) {
          // TODO: to evaluate if check destination page here or before

          // Handle JSON new content
    			$contentModel = $wikiPage->getContentModel();
    			if ( $contentModel === "json" || ! $wikiPage->exists() ) {
    				$new_content = new JSONContent( $text );
    			}

       } else {

         if ( $this->title->exists() ) {
             if ( $for_pages_that_exist == 'append' ) {
                     // MW >= 1.21
               $existingText = $wikiPage->getContent()->getNativeData();
               $text = $existingText . "\n" . $text;

             }
         }

         $new_content = new WikitextContent( $text );

       }

       $wikiPage->doEditContent( $new_content, $edit_summary );
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

       $wgUser = $actual_user;
       wfProfileOut( __METHOD__ );
       return true;
   }
}


1			<?php
2
3			/**
4			* Background job to import a page into the wiki, adapted from Data Transfer
5			*
6			* @author Yaron Koren
7			* @author Toni Hermoso
8			*/
9			class SDImportJob extends Job {
10
11			function __construct( $title, $params = '', $id = 0 ) {
			0 ignored issues – show Best Practice introduced 2018-09-18 16:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
12			parent::__construct( 'sdImport', $title, $params, $id );
13			}
14
15			/**
16			* Run a dtImport job
17			* @return boolean success
18			*/
19			function run() {
			0 ignored issues – show Best Practice introduced 2018-09-18 16:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
20			wfProfileIn( __METHOD__ );
21
22			if ( is_null( $this->title ) ) {
23			$this->error = "sdImport: Invalid title";
24			wfProfileOut( __METHOD__ );
25			return false;
26			}
27
28			if ( method_exists( 'WikiPage', 'getContent' ) ) {
29			$wikiPage = new WikiPage( $this->title );
30			if ( !$wikiPage ) {
31			$this->error = 'sdImport: Wiki page not found "' . $this->title->getPrefixedDBkey() . '"';
32			wfProfileOut( __METHOD__ );
33			return false;
34			}
35			} else {
36			// Remove old support
37			return false;
38			}
39			$for_pages_that_exist = $this->params['for_pages_that_exist'];
40			if ( $for_pages_that_exist == 'skip' && $this->title->exists() ) {
41			return true;
42			}
43
44			// Change global $wgUser variable to the one specified by
45			// the job only for the extent of this import.
46			global $wgUser;
47			$actual_user = $wgUser;
48			$wgUser = User::newFromId( $this->params['user_id'] );
49			$text = $this->params['text'];
50			$edit_summary = $this->params['edit_summary'];
51
52			// Act according to storage here
53			if ( $this->params['storage'] == "json" ) {
54			// TODO: to evaluate if check destination page here or before
55
56			// Handle JSON new content
57			$contentModel = $wikiPage->getContentModel();
58			if ( $contentModel === "json" \|\| ! $wikiPage->exists() ) {
59			$new_content = new JSONContent( $text );
60			}
61
62			} else {
63
64			if ( $this->title->exists() ) {
65			if ( $for_pages_that_exist == 'append' ) {
66			// MW >= 1.21
67			$existingText = $wikiPage->getContent()->getNativeData();
68			$text = $existingText . "\n" . $text;
69
70			}
71			}
72
73			$new_content = new WikitextContent( $text );
74
75			}
76
77			$wikiPage->doEditContent( $new_content, $edit_summary );
			0 ignored issues – show Bug introduced 2018-09-18 16:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$new_content` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
78
79			$wgUser = $actual_user;
80			wfProfileOut( __METHOD__ );
81			return true;
82			}
83			}
84

toniher / SemanticDataImport

Issues (48)

Security Analysis no request data

includes/SDImportJob.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like