ArgumentCollection::getIterator() - Code Metrics - tonicospinelli/class-generation - Measure and Improve Code Quality continuously with Scrutinizer

ArgumentCollection::getIterator() A
last analyzed 2016-01-09 01:36 UTC

↳ Parent: ArgumentCollection

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
c	1
b	1
f	0
dl	0
loc	4
ccs	2
cts	2
cp	1
rs	10
cc	1
eloc	2
nc	1
nop	0
crap	1

<?php

/*
 * This file is part of the ClassGeneration package.
 *
 * (c) Antonio Spinelli <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace ClassGeneration;

use ClassGeneration\Collection\ArrayCollection;

/**
 * Argument Collection ClassGeneration
 * @author Antonio Spinelli <[email protected]>
 */
class ArgumentCollection extends ArrayCollection
{

    /**
     * Add a Argument on collection.<br />
     * The index is a argument name, then will replace
     * if exist a index with the same name.
     *
     * @param ArgumentInterface $argument
     *
     * @throws \InvalidArgumentException
     * @return boolean
     */
    public function add($argument)
    {
        if (!$argument instanceof ArgumentInterface) {
            throw new \InvalidArgumentException(
                'This Argument must be a instance of \ClassGeneration\ArgumentInterface'
            );
        }
        if ($argument->getName() === null) {
            $argument->setName('param' . ($this->count() + 1));
        }

        parent::offsetSet($argument->getName(), $argument);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}

        return true;
    }

    /**
     * Gets Argument Iterator
     * @return ArgumentIterator|Argument[]
     */
    public function getIterator()
    {
        return new ArgumentIterator($this);
    }

    /**
     * Returns the arguments in string.
     * @return string
     */
    public function toString()
    {
        $arguments = $this->getIterator();
        $params = array();
        $optionals = array();
        foreach ($arguments as $argument) {
            if ($argument->isOptional()) {
                $optionals[] = $argument->toString();
            } else {
                $params[] = $argument->toString();
            }
        }

        return implode(', ', array_merge($params, $optionals));
    }

    /**
     * Removes tags by name.
     *
     * @param string|array|Argument $argumentName
     *
     * @return \ClassGeneration\ArgumentCollection
     */
    public function removeByName($argumentName)
    {
        $removedList = new self();
        $list = $this->getIterator();
        foreach ($list as $index => $argument) {
            if (($argumentName instanceof Argument && $argumentName->getName() != $argument->getName())
                || (is_string($argumentName) && $argument->getName() !== $argumentName)
            ) {
                continue;
            }
            $removedList->add(clone $argument);
            $this->remove($index);
        }

        return $removedList;
    }
}


1		<?php
2
3		/*
4		* This file is part of the ClassGeneration package.
5		*
6		* (c) Antonio Spinelli <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace ClassGeneration;
13
14		use ClassGeneration\Collection\ArrayCollection;
15
16		/**
17		* Argument Collection ClassGeneration
18		* @author Antonio Spinelli <[email protected]>
19		*/
20		class ArgumentCollection extends ArrayCollection
21		{
22
23		/**
24		* Add a Argument on collection.<br />
25		* The index is a argument name, then will replace
26		* if exist a index with the same name.
27		*
28		* @param ArgumentInterface $argument
29		*
30		* @throws \InvalidArgumentException
31		* @return boolean
32		*/
33	13	public function add($argument)
34		{
35	13	if (!$argument instanceof ArgumentInterface) {
36	1	throw new \InvalidArgumentException(
37		'This Argument must be a instance of \ClassGeneration\ArgumentInterface'
38	1	);
39		}
40	13	if ($argument->getName() === null) {
41	2	$argument->setName('param' . ($this->count() + 1));
42	2	}
43
44	13	parent::offsetSet($argument->getName(), $argument);
		0 ignored issues – show Comprehensibility Bug introduced 2016-01-09 01:28 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`offsetSet()` instead of `add()`). Are you sure this is correct? If so, you might want to change this to `$this->offsetSet()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
45
46	13	return true;
47		}
48
49		/**
50		* Gets Argument Iterator
51		* @return ArgumentIterator\|Argument[]
52		*/
53	20	public function getIterator()
54		{
55	20	return new ArgumentIterator($this);
56		}
57
58		/**
59		* Returns the arguments in string.
60		* @return string
61		*/
62	18	public function toString()
63		{
64	18	$arguments = $this->getIterator();
65	18	$params = array();
66	18	$optionals = array();
67	18	foreach ($arguments as $argument) {
68	10	if ($argument->isOptional()) {
69	1	$optionals[] = $argument->toString();
70	1	} else {
71	10	$params[] = $argument->toString();
72		}
73	18	}
74
75	18	return implode(', ', array_merge($params, $optionals));
76		}
77
78		/**
79		* Removes tags by name.
80		*
81		* @param string\|array\|Argument $argumentName
82		*
83		* @return \ClassGeneration\ArgumentCollection
84		*/
85	1	public function removeByName($argumentName)
86		{
87	1	$removedList = new self();
88	1	$list = $this->getIterator();
89	1	foreach ($list as $index => $argument) {
90	1	if (($argumentName instanceof Argument && $argumentName->getName() != $argument->getName())
91	1	\|\| (is_string($argumentName) && $argument->getName() !== $argumentName)
92	1	) {
93	1	continue;
94		}
95	1	$removedList->add(clone $argument);
96	1	$this->remove($index);
97	1	}
98
99	1	return $removedList;
100		}
101		}
102

tonicospinelli / class-generation

ArgumentCollection::getIterator() A last analyzed 2016-01-09 01:36 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

ArgumentCollection::getIterator() A
last analyzed 2016-01-09 01:36 UTC