TonicForHealth\PagerDutyClient\RepresentProcessor\Representation\Traits\JSONRepresentationTrait

Complexity

Total Complexity

10

Size/Duplication

Total Lines	99
Duplicated Lines	12.12 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

40%

Importance

Changes	1
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	persistRepresentJSON()	0	7	1
A	cameCaseTransformToUnderscores()	0	4	1
A	loadRepresentJSON()	0	6	1
A	persistRepresentObj()	0	15	3
A	loadRepresentObj()	12	12	3
A	underscoresTransformToCameCase()	0	13	1

<?php

namespace TonicForHealth\PagerDutyClient\RepresentProcessor\Representation\Traits;

use stdClass;
use TonicForHealth\PagerDutyClient\Entity\PagerDutyEntityInterface;

/**
 * Trait JSONRepresentationTrait.
 */
trait JSONRepresentationTrait
{
    /**
     * @param PagerDutyEntityInterface $pagerDutyEntity
     *
     * @return string
     */
    public function persistRepresentJSON(PagerDutyEntityInterface $pagerDutyEntity)
    {
        return json_encode(
           $this->persistRepresentObj($pagerDutyEntity),
           JSON_PRETTY_PRINT
       );
    }

    /**
     * @param string                        $jsonString
     * @param PagerDutyEntityInterface|null $pagerDutyEntity
     *
     * @return PagerDutyEntityInterface
     */
    public function loadRepresentJSON($jsonString, PagerDutyEntityInterface $pagerDutyEntity = null)

The parameter $pagerDutyEntity is not used and could be removed.

    {
        return $this->loadRepresentObj(
            json_decode($jsonString)
        );
    }

    /**
     * @param PagerDutyEntityInterface $pagerDutyEntity
     *
     * @return stdClass
     */
    public function persistRepresentObj(PagerDutyEntityInterface $pagerDutyEntity)
    {
        $representObject = new stdClass();

        $objArray = (array) $pagerDutyEntity;
        foreach ($objArray as $key => $value) {
            if (null === $value) {
                continue;
            }
            $key = $this->cameCaseTransformToUnderscores($key);
            $representObject->$key = $value;
        }

        return $representObject;
    }

    /**
     * @param stdClass                      $obj
     * @param PagerDutyEntityInterface|null $pagerDutyEntity
     */
    public function loadRepresentObj(stdClass $obj, PagerDutyEntityInterface $pagerDutyEntity = null)

This method seems to be duplicated in your project.

    {
        if (null === $pagerDutyEntity) {
            $entityClassName = static::getEntityClassName();
            $pagerDutyEntity = new $entityClassName();

$pagerDutyEntity is not used, you could remove the assignment.

        }
        $objArray = (array) $obj;
        foreach ($objArray as $key => $value) {
            $key = $this->underscoresTransformToCameCase($key);
            $representObject->$key = $value;

The variable $representObject does not exist. Did you forget to declare it?

        }
    }

    /**
     * Decamelize str cameCase string to underscored.
     *
     * @param string $cameCaseStr
     *
     * @return string
     */
    protected function cameCaseTransformToUnderscores($cameCaseStr)
    {
        return ltrim(strtolower(preg_replace('/[A-Z]/', '_$0', $cameCaseStr)), '_');
    }

    /**
     * Decamelize str cameCase string to underscored.
     *
     * @param string $underscores
     *
     * @return string
     */
    protected function underscoresTransformToCameCase($underscores)
    {
        return ltrim(
            preg_replace_callback(
                '/_[a-z]/',
                function ($matches) {
                    return substr(strtolower($matches[0]), 1);
                },
                $underscores
            ),
            '_'
        );
    }
}