IncidentBundle\Controller\IncidentHookController

Complexity

Total Complexity

7

Size/Duplication

Total Lines	70
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Test Coverage

Coverage

100%

Importance

Changes	5
Bugs	2	Features	2

4 Methods

Rating	Name	Duplication	Size	Complexity
B	emailReciveCheckProcHookAction()	0	24	4
A	getIncident()	0	8	1
A	getErrorHandlerCallback()	0	6	1
A	getIdent()	0	4	1

<?php

namespace IncidentBundle\Controller;

use IncidentBundle\Entity\Incident;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Exception;

/**
 * Class IncidentHookController
 */
class IncidentHookController extends Controller
{
    /**
     * @Route("/dnnlpwo2cj287189282bbcnjskshewk/{checkIdent}")
     *
     * @param Request $request
     *
     * @return Response
     */
    public function emailReciveCheckProcHookAction($checkIdent, Request $request)

The parameter $request is not used and could be removed.

    {
        $ident = $this->getIdent($checkIdent);

        $errors = [];
        $responseData = [];
        set_error_handler($this->getErrorHandlerCallback($errors));

        try {
            $entityManager = $this->getDoctrine()->getManager();
            if (!$incident = $this->getIncident($ident)) {
                $incident = new Incident($ident);
                $entityManager->persist($incident);
            }
            $incident->setMessage('Can\'t send&receive email check fail');
            $incident->setStatus(500);
            $entityManager->flush();
        } catch (Exception $e) {
            $errors[] = $e;
        }
        $responseData['status'] = empty($errors) ? 'ok' : 'error';

        return new Response(json_encode($responseData));
    }

    /**
     * @param string $ident
     *
     * @return Incident
     */
    protected function getIncident($ident)
    {
        $incident = $this->getDoctrine()
            ->getRepository('IncidentBundle:Incident')
            ->findOneBy(['ident' => $ident], ['id' => 'desc']);

The call to ObjectRepository::findOneBy() has too many arguments starting with array('id' => 'desc').

        return $incident;
    }

    /**
     * @param array $errors
     *
     * @return \Closure
     */
    protected function getErrorHandlerCallback(&$errors)
    {
        return function ($errno, $errstr, $errfile, $errline) use (&$errors) {

The parameter $errfile is not used and could be removed.

The parameter $errline is not used and could be removed.

            $errors[] = ['code' => $errno, 'text' => $errstr];
        };
    }

    /**
     * @param $checkIdent
     *
     * @return string
     */
    protected function getIdent($checkIdent)
    {
        return sprintf('%s.%s', $checkIdent, date('Ymd'));
    }
}