IncidentCreateTrait::createIncidentMock() - Code Metrics - tonicforhealth/health-checker-incident-component - Measure and Improve Code Quality continuously with Scrutinizer

IncidentCreateTrait::createIncidentMock() A
last analyzed 2016-11-24 12:30 UTC

↳ Parent: IncidentCreateTrait

Complexity

Conditions	1
Paths	1

Size

Total Lines	16
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	16
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	11
nc	1
nop	2

<?php

namespace TonicHealthCheck\Test\Incident;

use PHPUnit_Framework_MockObject_MockObject;
use TonicHealthCheck\Incident\IncidentInterface;

trait IncidentCreateTrait
{
    /**
     * @param null|string $iIdent
     * @param null|string $iMessage
     *
     * @return PHPUnit_Framework_MockObject_MockObject|IncidentInterface
     */
    protected function createIncidentMock($iIdent = 'node_name.some_check', $iMessage = 'check error')
    {
        $incident = $this->getMockBuilder(IncidentInterface::class)->getMock();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        $incident
            ->expects($this->any())
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            ->method('getIdent')
            ->willReturn($iIdent);

        $incident
            ->expects($this->any())
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            ->method('getMessage')
            ->willReturn($iMessage);

        return $incident;
    }
}


1			<?php
2
3			namespace TonicHealthCheck\Test\Incident;
4
5			use PHPUnit_Framework_MockObject_MockObject;
6			use TonicHealthCheck\Incident\IncidentInterface;
7
8			trait IncidentCreateTrait
9			{
10			/**
11			* @param null\|string $iIdent
12			* @param null\|string $iMessage
13			*
14			* @return PHPUnit_Framework_MockObject_MockObject\|IncidentInterface
15			*/
16			protected function createIncidentMock($iIdent = 'node_name.some_check', $iMessage = 'check error')
17			{
18			$incident = $this->getMockBuilder(IncidentInterface::class)->getMock();
			0 ignored issues – show Bug introduced 2016-04-18 07:58 UTC by Report Bug Copy Issue Report It seems like `getMockBuilder()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
19
20			$incident
21			->expects($this->any())
			0 ignored issues – show Bug introduced 2016-04-18 07:58 UTC by Report Bug Copy Issue Report It seems like `any()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
22			->method('getIdent')
23			->willReturn($iIdent);
24
25			$incident
26			->expects($this->any())
			0 ignored issues – show Bug introduced 2016-04-18 07:58 UTC by Report Bug Copy Issue Report It seems like `any()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
27			->method('getMessage')
28			->willReturn($iMessage);
29
30			return $incident;
31			}
32			}
33

tonicforhealth / health-checker-incident-component

IncidentCreateTrait::createIncidentMock() A last analyzed 2016-11-24 12:30 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

IncidentCreateTrait::createIncidentMock() A
last analyzed 2016-11-24 12:30 UTC