TonicHealthCheck\Test\Incident\Siren\NotificationType\RequestNotificationTypeTest

Complexity

Total Complexity

10

Size/Duplication

Total Lines	175
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes

0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	20	1
B	testNotifyCreate()	0	43	1
A	testNotifyUpdate()	0	19	1
A	getMockClient()	0	4	1
A	setMockClient()	0	4	1
A	getHttpClient()	0	4	1
A	setHttpClient()	0	4	1
A	getResourceUrl()	0	4	1
A	getRequestNType()	0	4	1
A	setRequestNType()	0	4	1

<?php

namespace TonicHealthCheck\Test\Incident\Siren\NotificationType;

use Http\Client\Common\HttpMethodsClient;
use Http\Discovery\MessageFactoryDiscovery;
use Http\Mock\Client as MockClient;
use PHPUnit_Framework_MockObject_MockObject;
use PHPUnit_Framework_TestCase;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\StreamInterface;
use TonicHealthCheck\Incident\IncidentInterface;
use TonicHealthCheck\Incident\Siren\NotificationType\RequestNotificationType;
use TonicHealthCheck\Test\Incident\IncidentCreateTrait;
use TonicHealthCheck\Test\Incident\Subject\SubjectCreateTrait;

/**
 * Class RequestNotificationTypeTest.
 */
class RequestNotificationTypeTest extends PHPUnit_Framework_TestCase
{
    use SubjectCreateTrait;
    use IncidentCreateTrait;

    /**
     * @var PHPUnit_Framework_MockObject_MockObject|MockClient
     */
    private $mockClient;

    /**
     * @var HttpMethodsClient
     */
    private $httpClient;

    /**
     * @var RequestNotificationType;
     */
    private $requestNType;

    /**
     * @var string
     */
    private $resourceUrl = '/incident';

    /**
     * set up base env Request type test.
     */
    public function setUp()
    {
        $this->setMockClient(new MockClient());

        $this->setHttpClient(
            $this
                ->getMockBuilder(HttpMethodsClient::class)
                ->setConstructorArgs([
                    $this->getMockClient(),
                    MessageFactoryDiscovery::find(),
                ])
                ->enableProxyingToOriginalMethods()
                ->getMock()
        );

        $this->setRequestNType(new RequestNotificationType(
            $this->getHttpClient(),

It seems like $this->getHttpClient() targeting TonicHealthCheck\Test\Incident\Siren\NotificationType\RequestNotificationTypeTest::getHttpClient() can also be of type object<PHPUnit_Framework_MockObject_MockObject>; however, TonicHealthCheck\Incident\Siren\NotificationType\RequestNotificationType::__construct() does only seem to accept object<Http\Client\Common\HttpMethodsClient>, maybe add an additional type check?

            $this->getResourceUrl()
        ));
    }

    /**
     * Test request notify create.
     */
    public function testNotifyCreate()
    {
        $this->assertEquals($this->getResourceUrl(), $this->getRequestNType()->getResourceUrl());

        $incident = $this->createIncidentMock();

        $incident

The method expects does only exist in PHPUnit_Framework_MockObject_MockObject, but not in TonicHealthCheck\Incident\IncidentInterface.

            ->expects($this->any())
            ->method('getStatus')
            ->willReturn(IncidentInterface::STATUS_OK + 1);

        $subject = $this->createSubject('target', '* * * * *');

        $streamMock = $this->getMockBuilder(StreamInterface::class)->getMock();

        $streamMock
            ->expects($this->once())
            ->method('getContents')
            ->willReturn('{"data":{"id":22}}');

        $response = $this->getMockBuilder(ResponseInterface::class)->getMock();

        $response->expects($this->once())->method('getBody')->willReturn($streamMock);

        $this->getMockClient()->addResponse($response);

        $this->getHttpClient()

The method expects does only exist in PHPUnit_Framework_MockObject_MockObject, but not in Http\Client\Common\HttpMethodsClient.

            ->expects($this->once())
            ->method('post')
            ->with(
                $this->identicalTo($subject->getTarget().$this->getResourceUrl()),
                $this->identicalTo(['Content-type' => 'application/json']),
                $this->identicalTo(
                    sprintf(
                        '{"name":"%s","message":"%s","status":1,"visible":1}',
                        $incident->getIdent(),

The method getIdent does only exist in TonicHealthCheck\Incident\IncidentInterface, but not in PHPUnit_Framework_MockObject_MockObject.

                        $incident->getMessage()

The method getMessage does only exist in TonicHealthCheck\Incident\IncidentInterface, but not in PHPUnit_Framework_MockObject_MockObject.

                        )
                )
            );

        $this->getRequestNType()->notify($subject, $incident);

It seems like $incident defined by $this->createIncidentMock() on line 76 can also be of type object<PHPUnit_Framework_MockObject_MockObject>; however, TonicHealthCheck\Incident\Siren\NotificationType\RequestNotificationType::notify() does only seem to accept object<TonicHealthCheck\Incident\IncidentInterface>, maybe add an additional type check?

    }

    /**
     * Test request notify update.
     */
    public function testNotifyUpdate()
    {
        $incident = $this->createIncidentMock();

        $incident->expects($this->any())->method('getStatus')->willReturn(IncidentInterface::STATUS_OK);

The method expects does only exist in PHPUnit_Framework_MockObject_MockObject, but not in TonicHealthCheck\Incident\IncidentInterface.

        $subject = $this->createSubject('target', '* * * * *');

        $this->getHttpClient()

The method expects does only exist in PHPUnit_Framework_MockObject_MockObject, but not in Http\Client\Common\HttpMethodsClient.

            ->expects($this->once())
            ->method('put')
            ->with(
                $this->identicalTo($subject->getTarget().$this->getResourceUrl().'/'),
                $this->identicalTo(['Content-type' => 'application/json']),
                $this->identicalTo('{"status":4}')
            );

        $this->getRequestNType()->notify($subject, $incident);

It seems like $incident defined by $this->createIncidentMock() on line 121 can also be of type object<PHPUnit_Framework_MockObject_MockObject>; however, TonicHealthCheck\Incident\Siren\NotificationType\RequestNotificationType::notify() does only seem to accept object<TonicHealthCheck\Incident\IncidentInterface>, maybe add an additional type check?

    }

    /**
     * @return MockClient
     */
    protected function getMockClient()
    {
        return $this->mockClient;

The expression $this->mockClient; of type PHPUnit_Framework_MockObject_MockObject|Http\Mock\Client adds the type PHPUnit_Framework_MockObject_MockObject to the return on line 144 which is incompatible with the return type documented by TonicHealthCheck\Test\Incident\Siren\NotificationType\RequestNotificationTypeTest::getMockClient of type Http\Mock\Client.

    }

    /**
     * @param MockClient $mockClient
     */
    protected function setMockClient(MockClient $mockClient)
    {
        $this->mockClient = $mockClient;
    }

    /**
     * @return PHPUnit_Framework_MockObject_MockObject|HttpMethodsClient
     */
    protected function getHttpClient()
    {
        return $this->httpClient;
    }

    /**
     * @param HttpMethodsClient $httpClient
     */
    protected function setHttpClient(HttpMethodsClient $httpClient)
    {
        $this->httpClient = $httpClient;
    }

    /**
     * @return string
     */
    protected function getResourceUrl()
    {
        return $this->resourceUrl;
    }

    /**
     * @return RequestNotificationType
     */
    protected function getRequestNType()
    {
        return $this->requestNType;
    }

    /**
     * @param RequestNotificationType $requestNType
     */
    protected function setRequestNType(RequestNotificationType $requestNType)
    {
        $this->requestNType = $requestNType;
    }
}