tomzx /
php-semver-checker
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 8 | View Code Duplication | class FunctionParameterNameChanged extends Operation { |
|
|
|
|||
| 9 | /** |
||
| 10 | * @var string |
||
| 11 | */ |
||
| 12 | protected $code = 'V067'; |
||
| 13 | /** |
||
| 14 | * @var string |
||
| 15 | */ |
||
| 16 | protected $reason = 'Function parameter name changed.'; |
||
| 17 | /** |
||
| 18 | * @var string |
||
| 19 | */ |
||
| 20 | protected $fileBefore; |
||
| 21 | /** |
||
| 22 | * @var \PhpParser\Node\Stmt\Function_ |
||
| 23 | */ |
||
| 24 | protected $functionBefore; |
||
| 25 | /** |
||
| 26 | * @var string |
||
| 27 | */ |
||
| 28 | protected $fileAfter; |
||
| 29 | /** |
||
| 30 | * @var \PhpParser\Node\Stmt\Function_ |
||
| 31 | */ |
||
| 32 | protected $functionAfter; |
||
| 33 | |||
| 34 | /** |
||
| 35 | * @param string $fileBefore |
||
| 36 | * @param \PhpParser\Node\Stmt\Function_ $functionBefore |
||
| 37 | * @param string $fileAfter |
||
| 38 | * @param \PhpParser\Node\Stmt\Function_ $functionAfter |
||
| 39 | */ |
||
| 40 | 1 | public function __construct($fileBefore, Function_ $functionBefore, $fileAfter, Function_ $functionAfter) |
|
| 47 | |||
| 48 | /** |
||
| 49 | * @return string |
||
| 50 | */ |
||
| 51 | public function getLocation() |
||
| 52 | { |
||
| 53 | return $this->fileBefore; |
||
| 54 | } |
||
| 55 | |||
| 56 | /** |
||
| 57 | * @return int |
||
| 58 | */ |
||
| 59 | public function getLine() |
||
| 60 | { |
||
| 61 | return $this->functionAfter->getLine(); |
||
| 62 | } |
||
| 63 | |||
| 64 | /** |
||
| 65 | * @return string |
||
| 66 | */ |
||
| 67 | 1 | public function getTarget() |
|
| 71 | } |
||
| 72 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.