Application   A
last analyzed

Complexity

Total Complexity 3

Size/Duplication

Total Lines 38
Duplicated Lines 0 %

Coupling/Cohesion

Components 1
Dependencies 2

Test Coverage

Coverage 0%

Importance

Changes 0
Metric Value
wmc 3
lcom 1
cbo 2
dl 0
loc 38
ccs 0
cts 14
cp 0
rs 10
c 0
b 0
f 0

3 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 0 4 1
A getHelp() 0 4 1
A getDefaultCommands() 0 6 1
1
<?php
2
3
namespace PHPSemVerChecker\Console;
4
5
use PHPSemVerChecker\Console\Command\CompareCommand;
6
use Symfony\Component\Console\Application as SymfonyApplication;
7
8
class Application extends SymfonyApplication
9
{
10
11
	const VERSION = '@package_version@';
12
13
	/**
14
	 * @var string
15
	 */
16
	private static $logo = '    ____  ______   _______
17
   / __ \/ ___/ | / / ___/
18
  / /_/ /__  /| |/ / /__
19
 / .___/____/ |___/\___/
20
/_/
21
';
22
23
	public function __construct()
24
	{
25
		parent::__construct('PHP Semantic Versioning Checker by Tom Rochette', self::VERSION);
26
	}
27
28
	/**
29
	 * @return string
30
	 */
31
	public function getHelp()
32
	{
33
		return self::$logo . parent::getHelp();
34
	}
35
36
	/**
37
	 * @return array|\Symfony\Component\Console\Command\Command[]
38
	 */
39
	protected function getDefaultCommands()
40
	{
41
		$commands = parent::getDefaultCommands();
42
		$commands[] = $this->add(new CompareCommand());
43
		return $commands;
0 ignored issues
show
Best Practice introduced by
The expression return $commands; seems to be an array, but some of its elements' types (null) are incompatible with the return type of the parent method Symfony\Component\Consol...ion::getDefaultCommands of type array<Symfony\Component\...le\Command\ListCommand>.

If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design.

Let’s take a look at an example:

class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}

Our function my_function expects a Post object, and outputs the author of the post. The base class Post returns a simple string and outputting a simple string will work just fine. However, the child class BlogPost which is a sub-type of Post instead decided to return an object, and is therefore violating the SOLID principles. If a BlogPost were passed to my_function, PHP would not complain, but ultimately fail when executing the strtoupper call in its body.

Loading history...
44
	}
45
}
46