spec\TomPHP\HalClient\Resource\FieldMapSpec

Complexity

Total Complexity

7

Size/Duplication

Total Lines	53
Duplicated Lines	37.74 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	let()	0	7	1
A	it_returns_field_via_field_method()	0	4	1
A	it_throws_if_field_is_not_found()	0	5	1
A	it_returns_field_via_magic_method()	0	4	1
A	it_does_not_match_if_critera_includes_unknown_field()	0	4	1
A	it_does_match_if_all_criteria_fields_match()	10	10	1
A	it_does_not_match_if_any_criteria_fields_fail_to_match()	10	10	1

<?php

namespace spec\TomPHP\HalClient\Resource;

use PhpSpec\ObjectBehavior;
use TomPHP\HalClient\Exception\FieldNotFoundException;
use TomPHP\HalClient\Resource\FieldNode;

class FieldMapSpec extends ObjectBehavior
{
    function let(FieldNode $f1, FieldNode $f2)
    {
        $this->beConstructedWith([
            'field1' => $f1,
            'field2' => $f2,
        ]);
    }

    function it_returns_field_via_field_method(FieldNode $f1)
    {
        $this->getField('field1')->shouldReturn($f1);
    }

    function it_throws_if_field_is_not_found()
    {
        $this->shouldThrow(new FieldNotFoundException('unknown-field'))
             ->duringGetField('unknown-field');
    }

    function it_returns_field_via_magic_method(FieldNode $f1)
    {
        $this->field1->shouldReturn($f1);

The property field1 does not exist on object<spec\TomPHP\HalClient\Resource\FieldMapSpec>. Since you implemented __get, maybe consider adding a @property annotation.

    }

    function it_does_not_match_if_critera_includes_unknown_field()
    {
        $this->matches(['unknown_field' => 'some-value'])->shouldReturn(false);
    }

    function it_does_match_if_all_criteria_fields_match(FieldNode $f1, FieldNode $f2)

This method seems to be duplicated in your project.

    {
        $f1->matches('search-value1')->willReturn(true);
        $f2->matches('search-value2')->willReturn(true);

        $this->matches([
            'field1' => 'search-value1',
            'field2' => 'search-value2',
        ])->shouldReturn(true);
    }

    function it_does_not_match_if_any_criteria_fields_fail_to_match(FieldNode $f1, FieldNode $f2)

This method seems to be duplicated in your project.

    {
        $f1->matches('search-value1')->willReturn(true);
        $f2->matches('search-value2')->willReturn(false);

        $this->matches([
            'field1' => 'search-value1',
            'field2' => 'search-value2',
        ])->shouldReturn(false);
    }
}