Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
10 | View Code Duplication | class FieldCollectionSpec extends ObjectBehavior |
|
|
|||
11 | { |
||
12 | function let(FieldNode $f1, FieldNode $f2) |
||
16 | |||
17 | function it_is_accessible_via_ArrayAccess(FieldNode $f1, FieldNode $f2) |
||
22 | |||
23 | function it_is_accessible_can_be_checked_if_index_exists() |
||
28 | |||
29 | function it_is_immutable() |
||
34 | |||
35 | function it_finds_matching_nodes(FieldNode $f1, FieldNode $f2) |
||
44 | |||
45 | function it_is_countable() |
||
49 | } |
||
50 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.