TomPHP\HalClient\Resource\Resource

Complexity

Total Complexity

22

Size/Duplication

Total Lines	153
Duplicated Lines	5.23 %

Coupling/Cohesion

Components	2
Dependencies	4

Importance

Changes

0

11 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	10	1
A	__get()	0	4	1
A	getField()	8	8	2
A	getLinks()	0	4	1
A	getLink()	0	8	2
A	getResource()	0	8	2
A	matches()	0	10	3
A	matchesItem()	0	8	2
A	isResourceSearchCriteria()	0	7	4
A	matchesResource()	0	11	2
A	matchField()	0	8	2

<?php

namespace TomPHP\HalClient\Resource;

use Assert\Assertion;
use TomPHP\HalClient\Exception\FieldNotFoundException;
use TomPHP\HalClient\Exception\LinkNotFoundException;
use TomPHP\HalClient\Exception\ResourceNotFoundException;

final class Resource implements ResourceNode
{
    /** @var array */
    private $fields = [];

    /** @var Link[] */
    private $links = [];

    /** @var Resource[] */
    private $resources = [];

    /**
     * @param FieldNode[]    $fields
     * @param Link[]         $links
     * @param ResourceNode[] $resources
     */
    public function __construct(array $fields, array $links = [], array $resources = [])
    {
        Assertion::allIsInstanceOf($fields, FieldNode::class);
        Assertion::allIsInstanceOf($links, Link::class);
        Assertion::allIsInstanceOf($resources, ResourceNode::class);

        $this->fields    = $fields;
        $this->links     = $links;
        $this->resources = $resources;

It seems like $resources of type array<integer,object<TomPHP\HalClient\Resource\ResourceNode>> is incompatible with the declared type array<integer,resource> of property $resources.

    }

    /**
     * @param string $name
     *
     * @return FieldNode
     */
    public function __get($name)
    {
        return $this->getField($name);
    }

    /**
     * @param string $name
     *
     * @return FieldNode
     *
     * @throws FieldNotFoundException
     */
    public function getField($name)

This method seems to be duplicated in your project.

    {
        if (!array_key_exists($name, $this->fields)) {
            throw new FieldNotFoundException($name);
        }

        return $this->fields[$name];
    }

    /** @return string[] */

Should the return type not be integer[]?

    public function getLinks()
    {
        return array_keys($this->links);
    }

    /**
     * @return Link
     *
     * @throws LinkNotFoundException
     */
    public function getLink($name)
    {
        if (!array_key_exists($name, $this->links)) {
            throw new LinkNotFoundException($name);
        }

        return $this->links[$name];
    }

    /**
     * @return Resource
     */
    public function getResource($name)
    {
        if (!array_key_exists($name, $this->resources)) {
            throw new ResourceNotFoundException($name);
        }

        return $this->resources[$name];
    }

    public function matches($criteria)
    {
        foreach ($criteria as $name => $value) {
            if (!$this->matchesItem($name, $value)) {
                return false;
            }
        }

        return true;
    }

    /**
     * @param string|int $name
     * @param mixed      $value
     *
     * @return bool
     */
    private function matchesItem($name, $value)
    {
        if ($this->isResourceSearchCriteria($name, $value)) {
            return $this->matchesResource($value);
        }

        return $this->matchField($name, $value);
    }

    /**
     * @param string|int $name
     * @param mixed      $value
     *
     * @return bool
     */
    private function isResourceSearchCriteria($name, $value)
    {
        return is_int($name)
            && is_array($value)
            && array_key_exists(0, $value)
            && $value[0] === 'resource';
    }

    /** @return bool */
    private function matchesResource(array $value)
    {
        $name = $value[1];

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

        $search = $value[2];

        if (!array_key_exists($name, $this->resources)) {
            return false;
        }

        return $this->resources[$name]->matches($search);

The method matches cannot be called on $this->resources[$name] (of type resource).

    }

    /**
     * @param string $name
     * @param mixed  $value
     *
     * @return bool
     */
    public function matchField($name, $value)
    {
        if (!array_key_exists($name, $this->fields)) {
            return false;
        }

        return $this->fields[$name]->matches($value);
    }
}