ApplicationConfigServiceProvider::__construct() - Code Metrics - Inspection of "[WIP] v0.5.0" - tomphp/container-configurator - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#28)

by Tom

created 2016-08-29 16:21 UTC

ApplicationConfigServiceProvider::__construct() A

↳ Parent: ApplicationConfigServiceProvider

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	11
rs	9.4285
cc	1
eloc	7
nc	1
nop	2

<?php

namespace TomPHP\ConfigServiceProvider\League;

use League\Container\ServiceProvider\AbstractServiceProvider;
use TomPHP\ConfigServiceProvider\ApplicationConfig;

final class ApplicationConfigServiceProvider extends AbstractServiceProvider
{
    /**
     * @var ApplicationConfig
     */
    private $config;

    /**
     * @var string
     */
    private $prefix;

    /**
     * @param ApplicationConfig $config
     * @param string            $prefix
     */
    public function __construct(ApplicationConfig $config, $prefix)
    {
        $this->prefix   = $prefix;
        $this->config   = $config;
        $this->provides = array_map(
            function ($key) {
                return $this->keyPrefix() . $key;
            },
            $config->getKeys()
        );
    }

    public function register()
    {
        $container = $this->getContainer();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $prefix    = $this->keyPrefix();

        foreach ($this->config as $key => $value) {
            $this->getContainer()->share($prefix . $key, function () use ($value) {
                return $value;
            });
        }
    }

    /**
     * @return string
     */
    private function keyPrefix()
    {
        if (empty($this->prefix)) {
            return '';
        }

        return $this->prefix . $this->config->getSeparator();
    }
}


1			<?php
2
3			namespace TomPHP\ConfigServiceProvider\League;
4
5			use League\Container\ServiceProvider\AbstractServiceProvider;
6			use TomPHP\ConfigServiceProvider\ApplicationConfig;
7
8			final class ApplicationConfigServiceProvider extends AbstractServiceProvider
9			{
10			/**
11			* @var ApplicationConfig
12			*/
13			private $config;
14
15			/**
16			* @var string
17			*/
18			private $prefix;
19
20			/**
21			* @param ApplicationConfig $config
22			* @param string $prefix
23			*/
24			public function __construct(ApplicationConfig $config, $prefix)
25			{
26			$this->prefix = $prefix;
27			$this->config = $config;
28			$this->provides = array_map(
29			function ($key) {
30			return $this->keyPrefix() . $key;
31			},
32			$config->getKeys()
33			);
34			}
35
36			public function register()
37			{
38			$container = $this->getContainer();
			0 ignored issues – show Unused Code introduced 2016-08-19 08:20 UTC by Report Bug Copy Issue Report `$container` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
39			$prefix = $this->keyPrefix();
40
41			foreach ($this->config as $key => $value) {
42			$this->getContainer()->share($prefix . $key, function () use ($value) {
43			return $value;
44			});
45			}
46			}
47
48			/**
49			* @return string
50			*/
51			private function keyPrefix()
52			{
53			if (empty($this->prefix)) {
54			return '';
55			}
56
57			return $this->prefix . $this->config->getSeparator();
58			}
59			}
60

tomphp / container-configurator

Pull Request — master (#28)

ApplicationConfigServiceProvider::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like