ConfigIterator::next() - Code Metrics - Inspection of "[WIP] v0.5.0" - tomphp/container-configurator - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#28)

by Tom

created 2016-08-18 06:53 UTC

ConfigIterator::next() A

↳ Parent: ConfigIterator

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	11
rs	9.4285
cc	2
eloc	8
nc	2
nop	0

<?php

namespace TomPHP\ConfigServiceProvider;

use Iterator;
use RecursiveArrayIterator;

final class ConfigIterator implements Iterator
{
    /**
     * @var string[]
     */
    private $path = [];

    /**
     * @var RecursiveArrayIterator
     */
    private $stack = [];

    /**
     * @var RecursiveArrayIterator
     */
    private $current;

    /**
     * @var string
     */
    private $separator;

    /**
     * @param Config $config
     */
    public function __construct(Config $config)
    {
        $this->separator = $config->getSeparator();
        $this->current   = new RecursiveArrayIterator($config->asArray());
    }

    public function current()
    {
        return $this->current->current();
    }

    public function key()
    {
        return implode($this->separator, array_merge($this->path, [$this->current->key()]));
    }

    public function next()
    {
        if ($this->current->hasChildren()) {
            $it = &$this->current;
            array_push($this->stack, $it);
            array_push($this->path, $it->key());
            $this->current = $it->getChildren();
        } else {
            $this->current->next();
        }
    }

    public function rewind()
    {
        if (!empty($this->stack)) {
            $this->current = array_shift($this->stack);
        }

        $this->stack = [];

        $this->path = [];
$a = "a";
$ab = "ab";
$abc = "abc";

        $this->current->rewind();
    }

    public function valid()
    {
        if ($this->current->valid()) {
            return true;
        }

        if (empty($this->stack)) {
            return false;
        }

        array_pop($this->path);
        $this->current = array_pop($this->stack);
        $this->current->next();

        return $this->valid();
    }
}


1			<?php
2
3			namespace TomPHP\ConfigServiceProvider;
4
5			use Iterator;
6			use RecursiveArrayIterator;
7
8			final class ConfigIterator implements Iterator
9			{
10			/**
11			* @var string[]
12			*/
13			private $path = [];
14
15			/**
16			* @var RecursiveArrayIterator
17			*/
18			private $stack = [];
19
20			/**
21			* @var RecursiveArrayIterator
22			*/
23			private $current;
24
25			/**
26			* @var string
27			*/
28			private $separator;
29
30			/**
31			* @param Config $config
32			*/
33			public function __construct(Config $config)
34			{
35			$this->separator = $config->getSeparator();
36			$this->current = new RecursiveArrayIterator($config->asArray());
37			}
38
39			public function current()
40			{
41			return $this->current->current();
42			}
43
44			public function key()
45			{
46			return implode($this->separator, array_merge($this->path, [$this->current->key()]));
47			}
48
49			public function next()
50			{
51			if ($this->current->hasChildren()) {
52			$it = &$this->current;
53			array_push($this->stack, $it);
54			array_push($this->path, $it->key());
55			$this->current = $it->getChildren();
56			} else {
57			$this->current->next();
58			}
59			}
60
61			public function rewind()
62			{
63			if (!empty($this->stack)) {
64			$this->current = array_shift($this->stack);
65			}
66
67			$this->stack = [];
			0 ignored issues – show Documentation Bug introduced 2016-08-17 21:03 UTC by Report Bug Copy Issue Report It seems like `array()` of type `array` is incompatible with the declared type `object<RecursiveArrayIterator>` of property `$stack`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
68			$this->path = [];
			0 ignored issues – show Coding Style introduced 2016-08-17 21:03 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
69
70			$this->current->rewind();
71			}
72
73			public function valid()
74			{
75			if ($this->current->valid()) {
76			return true;
77			}
78
79			if (empty($this->stack)) {
80			return false;
81			}
82
83			array_pop($this->path);
84			$this->current = array_pop($this->stack);
85			$this->current->next();
86
87			return $this->valid();
88			}
89			}
90

tomphp / container-configurator

Pull Request — master (#28)

ConfigIterator::next() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like