DataController::fetchCandidatesAction() - Code Metrics - Inspection of "Remove constructors from controllers" - tomeightyeight/general-election-polling - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 00cd39...47d74e )

by Tom

created 2016-04-26 20:16 UTC

DataController::fetchCandidatesAction() A

↳ Parent: DataController

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	0	Features	1

Metric	Value
c	4
b	0
f	1
dl	0
loc	10
rs	9.4285
cc	2
eloc	6
nc	2
nop	1

<?php
namespace Kineo\Controller;

use Silex\Application;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Kineo\Component\Database;
use Kineo\Component\ApiResponse;
use Kineo\Model\ConstituenciesModel;
use Kineo\Model\CandidatesModel;

class DataController
{	

	public function fetchConstituenciesAction()
	{		
		$constituenciesModel = new ConstituenciesModel(new Database());
		
		if($constituenciesModel->getAllConstituencies()) {
			return json_encode($constituenciesModel->constituencies);
		} else {
			return ApiResponse::error('NO_CONSTITUENCIES_FOUND');	
		}
	}
	
	public function fetchCandidatesAction($constituencyId) 
	{
		$candidatesModel = new CandidatesModel(new Database());
		
		if($candidatesModel->getCandidatesByConstituencyId($constituencyId)) {
			return json_encode($candidatesModel->candidates);
		} else {
			return ApiResponse::error('NO_CANDIDATES_FOUND');	
		}
	}
}

1			<?php
2			namespace Kineo\Controller;
3
4			use Silex\Application;
5			use Symfony\Component\HttpFoundation\Request;
6			use Symfony\Component\HttpFoundation\Response;
7			use Kineo\Component\Database;
8			use Kineo\Component\ApiResponse;
9			use Kineo\Model\ConstituenciesModel;
10			use Kineo\Model\CandidatesModel;
11
12			class DataController
13			{
			0 ignored issues – show Coding Style introduced 2016-04-26 20:21 UTC by Report Bug Copy Issue Report The opening class brace should be on a newline by itself. Loading history...
14			public function fetchConstituenciesAction()
15			{
16			$constituenciesModel = new ConstituenciesModel(new Database());
17
18			if($constituenciesModel->getAllConstituencies()) {
19			return json_encode($constituenciesModel->constituencies);
20			} else {
21			return ApiResponse::error('NO_CONSTITUENCIES_FOUND');
22			}
23			}
24
25			public function fetchCandidatesAction($constituencyId)
26			{
27			$candidatesModel = new CandidatesModel(new Database());
28
29			if($candidatesModel->getCandidatesByConstituencyId($constituencyId)) {
30			return json_encode($candidatesModel->candidates);
31			} else {
32			return ApiResponse::error('NO_CANDIDATES_FOUND');
33			}
34			}
35			}

tomeightyeight / general-election-polling

Push — master ( 00cd39...47d74e )

DataController::fetchCandidatesAction() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like