ExtensionSettingsUtility::getAllSettings() - Code Metrics - Inspection of "[TASK] Create extension settings" - tomasnorre/golf_courses - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7c0d93...1c072c )

by Tomas Norre

created 2017-04-20 15:32 UTC

ExtensionSettingsUtility::getAllSettings() A

↳ Parent: ExtensionSettingsUtility

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	0

<?php
namespace TNM\GolfCourses\Utility;

/***************************************************************
 *  Copyright notice
 *
 *  (c) 2017 Tomas Norre Mikkelsen <[email protected]>
 *
 *  All rights reserved
 *
 *  This script is part of the TYPO3 project. The TYPO3 project is
 *  free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
 *  the Free Software Foundation; either version 3 of the License, or
 *  (at your option) any later version.
 *
 *  The GNU General Public License can be found at
 *  http://www.gnu.org/copyleft/gpl.html.
 *
 *  This script is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  GNU General Public License for more details.
 *
 *  This copyright notice MUST APPEAR in all copies of the script!
 ***************************************************************/

/**
 * Class ExtensionSettingsUtility
 *
 * @package TNM\GolfCourses\Utility
 */
class ExtensionSettingsUtility
{

    /**
     * @param $settingKey
     *
     * @return string
     */
    public static function getSetting($settingKey)
    {
        $extensionSetting = self::getAllSettings();
        if ( key_exists($settingKey, $extensionSetting)) {
            return $extensionSetting[$settingKey];
        }

        return '';
    }

    /**
     * @return array
     */
    private function getAllSettings()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        return unserialize($GLOBALS['TYPO3_CONF_VARS']['EXT']['extConf']['golf_courses']);
    }
}

1			<?php
2			namespace TNM\GolfCourses\Utility;
3
4			/***************************************************************
5			* Copyright notice
6			*
7			* (c) 2017 Tomas Norre Mikkelsen <[email protected]>
8			*
9			* All rights reserved
10			*
11			* This script is part of the TYPO3 project. The TYPO3 project is
12			* free software; you can redistribute it and/or modify
13			* it under the terms of the GNU General Public License as published by
14			* the Free Software Foundation; either version 3 of the License, or
15			* (at your option) any later version.
16			*
17			* The GNU General Public License can be found at
18			* http://www.gnu.org/copyleft/gpl.html.
19			*
20			* This script is distributed in the hope that it will be useful,
21			* but WITHOUT ANY WARRANTY; without even the implied warranty of
22			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
23			* GNU General Public License for more details.
24			*
25			* This copyright notice MUST APPEAR in all copies of the script!
26			***************************************************************/
27
28			/**
29			* Class ExtensionSettingsUtility
30			*
31			* @package TNM\GolfCourses\Utility
32			*/
33			class ExtensionSettingsUtility
34			{
35
36			/**
37			* @param $settingKey
38			*
39			* @return string
40			*/
41			public static function getSetting($settingKey)
42			{
43			$extensionSetting = self::getAllSettings();
44			if ( key_exists($settingKey, $extensionSetting)) {
45			return $extensionSetting[$settingKey];
46			}
47
48			return '';
49			}
50
51			/**
52			* @return array
53			*/
54			private function getAllSettings()
			0 ignored issues – show Coding Style introduced 2017-04-20 15:49 UTC by Report Bug Copy Issue Report `getAllSettings` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
55			{
56			return unserialize($GLOBALS['TYPO3_CONF_VARS']['EXT']['extConf']['golf_courses']);
57			}
58			}

tomasnorre / golf_courses

Push — master ( 7c0d93...1c072c )

ExtensionSettingsUtility::getAllSettings() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like